Reuse reference reads within session feedback generation

src/agent-session.ts

@@ -4,6 +4,13 @@ import { env } from "./config.js";
 type ActionResult = { id: string; label: string; rawAnalytics?: Record<string, unknown>; inActionMetrics?: { name: string; value: unknown; unit?: string }[] };
 type SessionResult = { id: string; playerId: string; actions: ActionResult[] };
 
+// Scoped to one generation: reuse reads without serving stale coach annotations
+// to a later request or retaining player data in a process-wide cache.
+class ReferenceCache {
+  results = new Map<string, ActionResult[] | null>();
+  pages = new Map<string, any[]>();
+}
+
 function numericMetrics(action: ActionResult) {
   const values = new Map<string, number>();
   const metrics = [...Object.entries(action.rawAnalytics ?? {}).map(([name, value]) => ({ name, value })), ...(action.inActionMetrics ?? [])];
@@ -54,20 +61,25 @@ export async function analysisResults(sessionId: string, userId: string, isAdmin
   return await response.json() as SessionResult;
 }
 
-export async function actionReferences(db: SupabaseClient, current: ActionResult, actionType: string, currentSession?: SessionResult) {
+export async function actionReferences(db: SupabaseClient, current: ActionResult, actionType: string, currentSession?: SessionResult, cache = new ReferenceCache()) {
   const closest = [];
   if (!numericMetrics(current).size) return [];
-  const referenceResults = new Map<string, ActionResult[] | null>();
+  const referenceResults = cache.results;
   if (currentSession) referenceResults.set(currentSession.id, currentSession.actions);
   for (let from = 0; ; from += 100) {
-    const { data: examples, error: examplesError } = await db.from("annotations")
-      .select("action_id,score,annotations_notes!inner(note),actions!inner(action_id,session_id,type,sessions!inner(user_id,player_id,players!inner(gender,bdate,height,weight,position)))")
-      .eq("actions.type", actionType)
-      .neq("action_id", current.id)
-      .order("action_id").range(from, from + 99);
-    if (examplesError) throw new Error(`Unable to load human annotations: ${examplesError.message}`);
+    const pageKey = JSON.stringify([actionType, from]);
+    let examples = cache.pages.get(pageKey);
+    if (!examples) {
+      const { data, error: examplesError } = await db.from("annotations")
+        .select("action_id,score,annotations_notes!inner(note),actions!inner(action_id,session_id,type,sessions!inner(user_id,player_id,players!inner(gender,bdate,height,weight,position)))")
+        .eq("actions.type", actionType)
+        .order("action_id").range(from, from + 99);
+      if (examplesError) throw new Error(`Unable to load human annotations: ${examplesError.message}`);
+      examples = data ?? [];
+      cache.pages.set(pageKey, examples);
+    }
     const referenceRows = (examples ?? []).filter((row: any) =>
-      (row.annotations_notes ?? []).some((note: { note: string }) => typeof note.note === "string" && note.note.trim().length > 0))
+      row.action_id !== current.id && (row.annotations_notes ?? []).some((note: { note: string }) => typeof note.note === "string" && note.note.trim().length > 0))
       .map((row: any) => ({ ...row, actions: Array.isArray(row.actions) ? row.actions[0] : row.actions }));
     const sessions = new Map<string, string>();
     for (const row of referenceRows) {
@@ -125,10 +137,11 @@ export async function generateSessionFeedback(db: SupabaseClient, sessionId: str
   if (actionsError) throw new Error(`Unable to load completed actions: ${actionsError.message}`);
 
   const actions = [];
+  const referenceCache = new ReferenceCache();
   for (const action of currentActions ?? []) {
     const current = actionResults.get(action.action_id);
     if (!current) continue;
-    const references = await actionReferences(db, current, action.type, result);
+    const references = await actionReferences(db, current, action.type, result, referenceCache);
     actions.push({ action_id: action.action_id, action_type: action.type,
       results: { metrics: current.inActionMetrics ?? [], analytics: current.rawAnalytics ?? {} }, references });
   }

tests/agent-chat.test.ts

@@ -250,10 +250,14 @@ test("action chat sends measurements and annotated references on every message a
     assert.equal(actionDistance(sample({ active_foot_speed: 10, ball_speed: 10, touch_frame: 1 }), { id: "metric", label: "Pass",
       inActionMetrics: [{ name: "Active Foot Speed", value: 10 }, { name: "Ball Speed", value: 9999 }, { name: "Touch Frame", value: 9999 }] }), 0);
     const db = createClient(upstreamOrigin, "test-service", { auth: { persistSession: false } });
+    const readsBeforeGeneration = referenceReads;
     await generateSessionFeedback(db, sessionId, owner);
+    assert.equal(referenceReads - readsBeforeGeneration, 2, "all actions in a generation share reference session downloads");
     assert.deepEqual(generations[0].actions.find((item) => item.action_id === actionId)?.references.map((item) => item.action_id), expectedReferences);
     assert.deepEqual(generations[0].actions.find((item) => item.action_id === otherActionId)?.references.map((item) => item.action_id), ["shoot-reference"]);
     assert.equal(mutations, 6, "automatic generation still persists feedback for both actions and the session");
+    await generateSessionFeedback(db, sessionId, owner);
+    assert.equal(referenceReads - readsBeforeGeneration, 4, "a new generation fetches fresh reference measurements");
   } finally {
     if (child.exitCode === null && child.signalCode === null) {
       const exited = once(child, "exit");