Update src/streamlit_app.py

src/streamlit_app.py

@@ -5,14 +5,14 @@ import streamlit as st
 import torch
 
 # ==========================================================
-# ✅ Page Configuration
+# ✅ PAGE CONFIG
 # ==========================================================
 st.set_page_config(page_title="Enterprise Knowledge Assistant", layout="wide")
+print("CUDA available:", torch.cuda.is_available())
 
 # ==========================================================
-# ⚙️ Environment Setup
+# ⚙️ CACHE DIR
 # ==========================================================
-print("CUDA available:", torch.cuda.is_available())
 CACHE_DIR = "/tmp/hf_cache"
 os.makedirs(CACHE_DIR, exist_ok=True)
 os.environ.update({
@@ -23,14 +23,14 @@ os.environ.update({
 })
 
 # ==========================================================
-# 📦 Imports (Your existing modules)
+# 📦 IMPORTS
 # ==========================================================
 from ingestion import extract_text_from_pdf, chunk_text
 from vectorstore import build_faiss_index
 from qa import retrieve_chunks, generate_answer, cache_embeddings, embed_chunks, genai_generate
 
 # ==========================================================
-# 🧠 Dynamic Suggestions (Document-Based)
+# 🧠 SMART SUGGESTION GENERATOR
 # ==========================================================
 def generate_dynamic_suggestions_from_toc(toc, chunks, doc_name="Document"):
     if not toc or not chunks:
@@ -52,7 +52,7 @@ def generate_dynamic_suggestions_from_toc(toc, chunks, doc_name="Document"):
     TEXT SAMPLE:
     {context_sample}
 
-    Generate 5–7 questions that are short, relevant, and strictly document-based.
+    Generate 5–7 short, relevant, strictly document-based questions.
     Each question should be under 18 words.
     """
     try:
@@ -66,26 +66,15 @@ def generate_dynamic_suggestions_from_toc(toc, chunks, doc_name="Document"):
                 final.append(q)
         return final[:7]
     except Exception:
-        return ["What is this document about?", "How do I start using this process?"]
+        return ["What is this document about?", "How do I begin using this guide?"]
 
 # ==========================================================
-# 🎨 UI Styling (Subtle Enhancements)
+# 🎨 STYLING — MINIMAL, ENTERPRISE UI
 # ==========================================================
 st.markdown("""
 <style>
-div.block-container {
-    padding-top: 1.2rem;
-    max-width: 1080px;
-}
-h1, h2, h3 {
-    color: #f3f4f6;
-    font-weight: 600;
-}
-hr {
-    border: none;
-    border-top: 1px solid #2c2c2c;
-    margin: 1rem 0;
-}
+div.block-container {padding-top: 1.2rem; max-width: 1080px;}
+h1, h2, h3 {color: #f3f4f6; font-weight: 600;}
 .suggest-chip {
     background: #0f1724;
     border: 1px solid #374151;
@@ -98,10 +87,7 @@ hr {
     display: inline-block;
     transition: background 0.2s, transform 0.1s;
 }
-.suggest-chip:hover {
-    background: #1e3a8a;
-    transform: translateY(-2px);
-}
+.suggest-chip:hover {background: #1e3a8a; transform: translateY(-2px);}
 .answer-box {
     background: linear-gradient(180deg,#0b1220,#071027);
     border-left: 4px solid #3b82f6;
@@ -122,7 +108,7 @@ hr {
 """, unsafe_allow_html=True)
 
 # ==========================================================
-# 🧭 Sidebar (Simplified for Users)
+# 🧭 SIDEBAR — SIMPLE
 # ==========================================================
 with st.sidebar:
     st.markdown("### 🧭 Response Mode")
@@ -130,35 +116,34 @@ with st.sidebar:
         "",
         ("Strict (Document-only)", "Extended (Document + general)"),
         index=0,
-        help="Strict = answers only from the document. Extended = may include helpful general info.",
+        help="Strict = answers only from the document. Extended = may include general context.",
     )
+
     st.markdown("---")
-    show_advanced = st.checkbox("Show advanced settings (for devs)", value=False)
+    show_advanced = st.checkbox("Show advanced settings (for developers)", value=False)
     if show_advanced:
         st.markdown("### Developer Settings")
-        chunk_size = st.slider("Chunk Size (chars)", 200, 1500, 1000, step=50)
-        overlap = st.slider("Chunk Overlap (chars)", 50, 200, 120, step=10)
+        chunk_size = st.slider("Chunk Size (characters)", 200, 1500, 1000, step=50)
+        overlap = st.slider("Chunk Overlap (characters)", 50, 200, 120, step=10)
         top_k = st.slider("Top K Results", 1, 10, 5)
     else:
-        chunk_size = 1000
-        overlap = 120
-        top_k = 5
+        chunk_size, overlap, top_k = 1000, 120, 5
+
     st.markdown("---")
     st.caption("✨ Built by Shubham Sharma")
 
 # ==========================================================
-# 🧠 Session State
+# 🧠 SESSION STATE
 # ==========================================================
-if "user_query_input" not in st.session_state:
-    st.session_state["user_query_input"] = ""
-if "show_more" not in st.session_state:
-    st.session_state["show_more"] = False
-if "selected_suggestion" not in st.session_state:
-    st.session_state["selected_suggestion"] = None
-if "query_suggestions_fixed" not in st.session_state:
-    st.session_state["query_suggestions_fixed"] = None
-if "last_doc" not in st.session_state:
-    st.session_state["last_doc"] = None
+for key, val in {
+    "user_query_input": "",
+    "show_more": False,
+    "selected_suggestion": None,
+    "query_suggestions_fixed": None,
+    "last_doc": None,
+}.items():
+    if key not in st.session_state:
+        st.session_state[key] = val
 
 def set_user_query(q, idx):
     st.session_state["user_query_input"] = q
@@ -166,26 +151,33 @@ def set_user_query(q, idx):
     st.experimental_rerun()
 
 # ==========================================================
-# 📄 Main UI
+# 📄 MAIN LAYOUT
 # ==========================================================
 st.title("📄 Enterprise Knowledge Assistant")
 st.caption("Query SAP documentation and enterprise PDFs — powered by reasoning and retrieval.")
 
-doc_choice = st.radio("Select a document:", ["-- Select --", "Sample PDF", "Upload Custom PDF"], index=0)
+doc_choice = st.radio(
+    "Select a document:",
+    ["-- Select --", "Sample PDF", "Upload Custom PDF"],
+    index=0
+)
 
+# ==========================================================
+# 📂 DOCUMENT HANDLING
+# ==========================================================
 if doc_choice == "-- Select --":
-    st.info("⬅️ Please select a document to begin.")
+    st.info("⬅️ Select a document to begin.")
 else:
     if doc_choice == "Sample PDF":
         temp_path = os.path.join(os.path.dirname(__file__), "sample.pdf")
-        st.success("📘 Using built-in Sample PDF.")
+        st.success("📘 Sample PDF loaded successfully. Ask questions below.")
     else:
-        uploaded_file = st.file_uploader("📂 Upload your PDF", type="pdf")
+        uploaded_file = st.file_uploader("", type="pdf", label_visibility="collapsed")
         if uploaded_file:
             temp_path = os.path.join("/tmp", uploaded_file.name)
             with open(temp_path, "wb") as f:
                 f.write(uploaded_file.getbuffer())
-            st.success(f"✅ '{uploaded_file.name}' uploaded successfully — ready to query below.")
+            st.success("✅ Document loaded successfully. You can now ask questions below.")
         else:
             temp_path = None
 
@@ -193,10 +185,12 @@ else:
         with st.spinner("🔍 Processing document..."):
             text, toc = extract_text_from_pdf(temp_path)
             chunks = chunk_text(text, chunk_size=chunk_size)
-        with st.spinner("⚙️ Preparing search index..."):
+
+        with st.spinner("⚙️ Preparing index..."):
             embeddings = cache_embeddings(os.path.basename(temp_path), chunks, embed_chunks)
             index = build_faiss_index(embeddings)
-            st.success("✅ Document ready — you can now ask questions below.")
+
+        st.success("✅ Ready. Ask below!")
 
         doc_name = os.path.basename(temp_path)
         if st.session_state["last_doc"] != doc_name:
@@ -207,15 +201,13 @@ else:
             query_suggestions = st.session_state["query_suggestions_fixed"]
 
         # ----------------------------------------------------------
-        # 💬 Ask a Question Section
+        # 💬 ASK ASSISTANT SECTION
         # ----------------------------------------------------------
         st.markdown("### Ask the Assistant")
 
         if query_suggestions:
             visible = query_suggestions if st.session_state["show_more"] else query_suggestions[:3]
             cols = st.columns(min(3, len(visible)))
-            
-            # ✅ FIXED - Only display one instance of suggestions
             for i, q in enumerate(visible):
                 if cols[i % 3].button(f"🔍 {q}", key=f"sugg_{i}"):
                     set_user_query(q, i)
@@ -227,18 +219,18 @@ else:
 
         user_query = st.text_input("Type your question or click one above:", key="user_query_input")
 
+        # ----------------------------------------------------------
+        # 💡 RESPONSE
+        # ----------------------------------------------------------
         if user_query.strip():
-            with st.spinner("💭 Generating response..."):
+            with st.spinner("💭 Thinking..."):
                 retrieved = retrieve_chunks(user_query, index, chunks, top_k=top_k)
                 answer = generate_answer(user_query, retrieved)
             st.markdown("### Assistant")
             st.markdown(f"<div class='answer-box'>💡 {answer}</div>", unsafe_allow_html=True)
 
-            # 👇 Smooth scroll to answer
             st.markdown("""
-            <script>
-            window.scrollTo({ top: document.body.scrollHeight, behavior: 'smooth' });
-            </script>
+            <script>window.scrollTo({top: document.body.scrollHeight, behavior: 'smooth'});</script>
             """, unsafe_allow_html=True)
 
             with st.expander("📄 Supporting Context"):