Wrap run_analysis_fn in try-except to return structured tracebacks

app.py

@@ -228,28 +228,27 @@ def get_case_photos_fn(case_id):
 @spaces.GPU(duration=120)
 def run_analysis_fn(case_id, progress=gr.Progress()):
     """Run the full AI analysis pipeline (GPU-accelerated)."""
-    if not case_id:
-        return "❌ Enter a Case ID.", "", ""
-    ensure_init()
-
+    import traceback
     try:
+        if not case_id:
+            return "❌ Enter a Case ID.", "", ""
+        ensure_init()
+
         case = run_async(db.get_case(int(case_id)))
         if not case:
             return "❌ Case not found.", "", ""
         photos = run_async(db.get_photos_by_case(int(case_id)))
         if not photos:
             return "❌ No photos uploaded.", "", ""
-    except Exception as e:
-        return f"❌ {e}", "", ""
 
-    if not inference_engine.is_loaded:
-        inference_engine.load_model()
+        if not inference_engine.is_loaded:
+            inference_engine.load_model()
 
-    # Step 1: Analyze each photo
-    analysis_results = []
-    for i, photo in enumerate(photos):
-        progress((i + 1) / len(photos) * 0.5, desc=f"Analyzing photo {i+1}/{len(photos)}...")
-        try:
+        # Step 1: Analyze each photo
+        analysis_results = []
+        for i, photo in enumerate(photos):
+            progress((i + 1) / len(photos) * 0.5, desc=f"Analyzing photo {i+1}/{len(photos)}...")
+            try:
             img = Image.open(photo["filepath"])
             start = time.perf_counter()
             raw = gpu_run_inference(img, SCENE_ANALYSIS_PROMPT)
@@ -268,42 +267,45 @@ def run_analysis_fn(case_id, progress=gr.Progress()):
         except Exception as e:
             analysis_results.append({"filename": photo["filename"], "analysis": f"Error: {e}", "time_ms": 0})
 
-    # Identify parties
-    progress(0.55, desc="Identifying parties...")
-    all_analyses = run_async(db.get_analyses_by_case(int(case_id)))
-    parties_data = scene_analyzer._identify_parties(all_analyses)
-    run_async(db.clear_parties(int(case_id)))
-    for p in parties_data:
-        run_async(db.add_party(
-            case_id=int(case_id), label=p.get("label", "Unknown"),
-            vehicle_type=p.get("vehicle_type"), vehicle_color=p.get("vehicle_color"),
-            vehicle_description=p.get("description"),
-        ))
+        # Identify parties
+        progress(0.55, desc="Identifying parties...")
+        all_analyses = run_async(db.get_analyses_by_case(int(case_id)))
+        parties_data = scene_analyzer._identify_parties(all_analyses)
+        run_async(db.clear_parties(int(case_id)))
+        for p in parties_data:
+            run_async(db.add_party(
+                case_id=int(case_id), label=p.get("label", "Unknown"),
+                vehicle_type=p.get("vehicle_type"), vehicle_color=p.get("vehicle_color"),
+                vehicle_description=p.get("description"),
+            ))
+
+        # Step 2: Rule matching
+        progress(0.65, desc="Matching traffic rules...")
+        violations = run_async(rule_matcher.match_violations(int(case_id)))
+
+        # Step 3: Fault deduction
+        progress(0.8, desc="Deducing fault...")
+        fault_result = run_async(fault_deducer.deduce_fault(int(case_id)))
+        run_async(db.update_case_status(int(case_id), "complete"))
 
-    # Step 2: Rule matching
-    progress(0.65, desc="Matching traffic rules...")
-    violations = run_async(rule_matcher.match_violations(int(case_id)))
-
-    # Step 3: Fault deduction
-    progress(0.8, desc="Deducing fault...")
-    fault_result = run_async(fault_deducer.deduce_fault(int(case_id)))
-    run_async(db.update_case_status(int(case_id), "complete"))
-
-    # Format output
-    total_time = sum(r["time_ms"] for r in analysis_results)
-    analysis_text = ""
-    for r in analysis_results:
-        analysis_text += f"### 📷 {r['filename']} ({r['time_ms']}ms)\n```\n{r['analysis']}\n```\n---\n\n"
-
-    violations_text = f"Found {len(violations)} violation(s):\n"
-    for v in violations:
-        violations_text += f"\n• **{v.get('rule_title', '?')}** ({v.get('severity', '?')}) — {v.get('confidence', 0):.0%}"
-    violations_text += f"\n\n### Fault: {fault_result.get('primary_fault_party', 'N/A')}"
-    violations_text += f"\nConfidence: {fault_result.get('overall_confidence', 0):.0%}"
-    violations_text += f"\n\n{fault_result.get('analysis_summary', '')}"
-
-    progress(1.0, desc="Complete!")
-    return f"✅ Done! {len(photos)} photos in {total_time/1000:.1f}s", analysis_text, violations_text
+        # Format output
+        total_time = sum(r["time_ms"] for r in analysis_results)
+        analysis_text = ""
+        for r in analysis_results:
+            analysis_text += f"### 📷 {r['filename']} ({r['time_ms']}ms)\n```\n{r['analysis']}\n```\n---\n\n"
+
+        violations_text = f"Found {len(violations)} violation(s):\n"
+        for v in violations:
+            violations_text += f"\n• **{v.get('rule_title', '?')}** ({v.get('severity', '?')}) — {v.get('confidence', 0):.0%}"
+        violations_text += f"\n\n### Fault: {fault_result.get('primary_fault_party', 'N/A')}"
+        violations_text += f"\nConfidence: {fault_result.get('overall_confidence', 0):.0%}"
+        violations_text += f"\n\n{fault_result.get('analysis_summary', '')}"
+
+        progress(1.0, desc="Complete!")
+        return f"✅ Done! {len(photos)} photos in {total_time/1000:.1f}s", analysis_text, violations_text
+    except Exception as e:
+        import traceback
+        return f"❌ Python Error: {e}", traceback.format_exc(), ""
 
 
 def generate_report_fn(case_id):