Spaces:
Running
Running
File size: 6,383 Bytes
c745a99 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 | """Unit tests for EnvironmentDesigner — tests provisioning and drift integration.
Run:
docker exec <container> python -m pytest env/tests/test_environment_designer.py -v
"""
from unittest.mock import MagicMock, patch
import pytest
from models import Task, TaskID, TaskDifficulty, SuccessCriteria, SetupCommand
from server.services.environment_designer import (
EnvironmentDesigner,
ProvisionMethod,
ProvisionResult,
)
def _task(
setup_commands: list[SetupCommand] | None = None,
possible_drifts: list[SetupCommand] | None = None,
) -> Task:
return Task(
task_id=TaskID(1),
difficulty=TaskDifficulty.BEGINNER,
description="test",
success_criteria=SuccessCriteria(),
setup_commands=setup_commands or [],
possible_drifts=possible_drifts or [],
)
@pytest.fixture
def mock_backend() -> MagicMock:
backend = MagicMock()
backend.execute_command.return_value = (True, "", "")
return backend
@pytest.fixture
def designer(mock_backend: MagicMock) -> EnvironmentDesigner:
return EnvironmentDesigner(mock_backend)
# ===================================================================
# apply — no setup commands
# ===================================================================
class TestApplyNoSetup:
def test_no_commands_returns_success(self, designer: EnvironmentDesigner) -> None:
result = designer.apply(_task())
assert result.success
assert result.resources_created == 0
def test_no_commands_no_backend_calls(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
designer.apply(_task())
mock_backend.execute_command.assert_not_called()
# ===================================================================
# apply — CLI commands
# ===================================================================
class TestApplyCliCommands:
def test_all_succeed(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
task = _task(
setup_commands=[
SetupCommand(command="aws s3api create-bucket --bucket a"),
SetupCommand(command="aws s3api create-bucket --bucket b"),
]
)
result = designer.apply(task)
assert result.success
assert result.resources_created == 2
assert result.method == ProvisionMethod.CLI_COMMANDS
assert mock_backend.execute_command.call_count == 2
def test_failure_recorded_in_errors(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
mock_backend.execute_command.side_effect = [
(True, "", ""),
(False, "", "bucket already exists"),
]
task = _task(
setup_commands=[
SetupCommand(command="aws s3api create-bucket --bucket a"),
SetupCommand(command="aws s3api create-bucket --bucket a"),
]
)
result = designer.apply(task)
assert not result.success
assert result.resources_created == 1
assert len(result.errors) == 1
assert "bucket already exists" in result.errors[0]
def test_ignore_failure_continues(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
mock_backend.execute_command.side_effect = [
(False, "", "already exists"),
(True, "", ""),
]
task = _task(
setup_commands=[
SetupCommand(command="cmd1", ignore_failure=True),
SetupCommand(command="cmd2"),
]
)
result = designer.apply(task)
assert result.success # ignored failure doesn't count
assert result.resources_created == 1
assert len(result.errors) == 0
def test_multiple_failures(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
mock_backend.execute_command.return_value = (False, "", "err")
task = _task(
setup_commands=[
SetupCommand(command="cmd1"),
SetupCommand(command="cmd2"),
SetupCommand(command="cmd3"),
]
)
result = designer.apply(task)
assert not result.success
assert result.resources_created == 0
assert len(result.errors) == 3
def test_commands_executed_in_order(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
task = _task(
setup_commands=[
SetupCommand(command="first"),
SetupCommand(command="second"),
SetupCommand(command="third"),
]
)
designer.apply(task)
calls = [c.args[0] for c in mock_backend.execute_command.call_args_list]
assert calls == ["first", "second", "third"]
# ===================================================================
# apply — drift integration
# ===================================================================
class TestApplyWithDrifts:
def test_drifts_applied_after_setup(
self, designer: EnvironmentDesigner, mock_backend: MagicMock
) -> None:
task = _task(
setup_commands=[SetupCommand(command="setup-cmd")],
possible_drifts=[SetupCommand(command="drift-cmd", description="d")],
)
with patch.object(
designer._drift_engine, "apply_drift", return_value=["d"]
) as mock_drift:
result = designer.apply(task)
mock_drift.assert_called_once_with(task)
assert result.success
def test_no_drifts_skips_drift_engine(self, designer: EnvironmentDesigner) -> None:
task = _task(setup_commands=[SetupCommand(command="cmd")])
with patch.object(designer._drift_engine, "apply_drift") as mock_drift:
designer.apply(task)
mock_drift.assert_not_called()
# ===================================================================
# ProvisionResult model
# ===================================================================
class TestProvisionResult:
def test_defaults(self) -> None:
r = ProvisionResult()
assert r.success is True
assert r.method == ProvisionMethod.CLI_COMMANDS
assert r.resources_created == 0
assert r.errors == []
|