File size: 7,703 Bytes
c745a99
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
"""Unit tests for HintProvider — tests progressive hint generation.

Run:
    docker exec <container> python -m pytest env/tests/test_hint_provider.py -v
"""

import pytest

from models import (
    Task,
    TaskID,
    TaskDifficulty,
    SuccessCriteria,
    StepCriteria,
    ResourceExistsCheck,
)
from server.services.hint_provider import HintProvider, MAX_HINT_LEVEL, _infer_service


@pytest.fixture
def provider() -> HintProvider:
    return HintProvider()


def _task(criteria: SuccessCriteria) -> Task:
    return Task(
        task_id=TaskID(1),
        difficulty=TaskDifficulty.WARMUP,
        description="test",
        success_criteria=criteria,
    )


# ===================================================================
# Level 1: Service hints
# ===================================================================


class TestHintServices:
    def test_explicit_services(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria(services=["s3", "iam"]))
        hint = provider.get_hint(task, 1)
        assert "s3" in hint
        assert "iam" in hint

    def test_inferred_from_steps(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-bucket", resource="b"),
                    StepCriteria(operation="create-function", resource="fn"),
                ]
            )
        )
        hint = provider.get_hint(task, 1)
        assert "s3api" in hint
        assert "lambda" in hint

    def test_inferred_from_operation(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(command_contains="dynamodb", operation="create-table")
        )
        hint = provider.get_hint(task, 1)
        assert "dynamodb" in hint

    def test_no_services_fallback(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria())
        hint = provider.get_hint(task, 1)
        assert "Review" in hint

    def test_no_duplicate_services(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-bucket"),
                    StepCriteria(operation="put-object"),  # both map to s3api
                ]
            )
        )
        hint = provider.get_hint(task, 1)
        assert hint.count("s3api") == 1


# ===================================================================
# Level 2: Operation hints
# ===================================================================


class TestHintOperations:
    def test_from_steps(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-table", resource="t"),
                    StepCriteria(operation="put-item", resource="t"),
                ]
            )
        )
        hint = provider.get_hint(task, 2)
        assert "create-table" in hint
        assert "put-item" in hint
        assert "in order" in hint.lower()

    def test_from_single_operation(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria(operation="list-buckets"))
        hint = provider.get_hint(task, 2)
        assert "list-buckets" in hint

    def test_no_operations_fallback(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria())
        hint = provider.get_hint(task, 2)
        assert "documentation" in hint.lower()


# ===================================================================
# Level 3: Command structure hints
# ===================================================================


class TestHintCommands:
    def test_from_steps_with_resource(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-bucket", resource="my-bucket"),
                ]
            )
        )
        hint = provider.get_hint(task, 3)
        assert "create-bucket" in hint
        assert "my-bucket" in hint
        assert "aws" in hint

    def test_from_steps_without_resource(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-role"),
                ]
            )
        )
        hint = provider.get_hint(task, 3)
        assert "create-role" in hint
        assert "..." in hint

    def test_from_operation_with_resource_exists(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                operation="create-bucket",
                resource_exists=ResourceExistsCheck(service="s3", name="data-bucket"),
            )
        )
        hint = provider.get_hint(task, 3)
        assert "create-bucket" in hint
        assert "data-bucket" in hint

    def test_multi_step_uses_arrow_separator(self, provider: HintProvider) -> None:
        task = _task(
            SuccessCriteria(
                steps=[
                    StepCriteria(operation="create-bucket", resource="b"),
                    StepCriteria(operation="put-object", resource="b"),
                ]
            )
        )
        hint = provider.get_hint(task, 3)
        assert "→" in hint

    def test_no_commands_fallback(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria())
        hint = provider.get_hint(task, 3)
        assert "help" in hint.lower()


# ===================================================================
# Level clamping
# ===================================================================


class TestLevelClamping:
    def test_level_zero_clamped_to_one(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria(services=["s3"]))
        hint = provider.get_hint(task, 0)
        assert "s3" in hint  # level 1 output

    def test_negative_level_clamped(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria(services=["s3"]))
        hint = provider.get_hint(task, -5)
        assert "s3" in hint

    def test_level_above_max_clamped(self, provider: HintProvider) -> None:
        task = _task(SuccessCriteria(operation="create-bucket"))
        hint = provider.get_hint(task, 99)
        # Should return level 3 (command structure)
        assert "create-bucket" in hint

    def test_max_hint_level_is_three(self) -> None:
        assert MAX_HINT_LEVEL == 3


# ===================================================================
# _infer_service helper
# ===================================================================


class TestInferService:
    @pytest.mark.parametrize(
        "operation,expected",
        [
            ("create-bucket", "s3api"),
            ("put-object", "s3api"),
            ("create-table", "dynamodb"),
            ("create-function", "lambda"),
            ("create-queue", "sqs"),
            ("create-topic", "sns"),
            ("create-role", "iam"),
            ("create-policy", "iam"),
            ("create-user", "iam"),
            ("create-rest-api", "apigateway"),
            ("create-secret", "secretsmanager"),
            ("describe-instances", "ec2"),
            ("create-security-group", "iam"),  # "group" keyword matches iam before ec2
        ],
    )
    def test_known_operations(self, operation: str, expected: str) -> None:
        assert _infer_service(operation) == expected

    def test_unknown_operation_returns_none(self) -> None:
        assert _infer_service("unknown-operation") is None

    def test_empty_operation_returns_none(self) -> None:
        assert _infer_service("") is None