File size: 13,658 Bytes
d9f5c15
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
"""

Tests for business metrics in the Portfolio Optimization quickstart.



These tests verify the financial KPIs calculated by the domain model:

- Herfindahl-Hirschman Index (HHI) for concentration

- Diversification score (1 - HHI)

- Max sector exposure

- Expected return

- Return volatility

- Sharpe proxy (return / volatility)



These metrics provide business insight beyond the solver score.

"""
import pytest
import math

from portfolio_optimization.domain import (
    StockSelection,
    PortfolioOptimizationPlan,
    PortfolioConfig,
    PortfolioMetricsModel,
    SELECTED,
    NOT_SELECTED,
)
from portfolio_optimization.converters import plan_to_metrics


def create_stock(

    stock_id: str,

    sector: str = "Technology",

    predicted_return: float = 0.10,

    selected: bool = True

) -> StockSelection:
    """Create a test stock with sensible defaults."""
    return StockSelection(
        stock_id=stock_id,
        stock_name=f"{stock_id} Corp",
        sector=sector,
        predicted_return=predicted_return,
        selection=SELECTED if selected else NOT_SELECTED,
    )


def create_plan(stocks: list[StockSelection]) -> PortfolioOptimizationPlan:
    """Create a test plan with given stocks."""
    return PortfolioOptimizationPlan(
        stocks=stocks,
        target_position_count=20,
        max_sector_percentage=0.25,
        portfolio_config=PortfolioConfig(target_count=20, max_per_sector=5, unselected_penalty=10000),
    )


class TestHerfindahlIndex:
    """Tests for the Herfindahl-Hirschman Index (HHI) calculation."""

    def test_single_sector_hhi_is_one(self) -> None:
        """All stocks in one sector should have HHI = 1.0 (max concentration)."""
        stocks = [create_stock(f"STK{i}", sector="Technology") for i in range(5)]
        plan = create_plan(stocks)

        # All in one sector: HHI = 1.0^2 = 1.0
        assert plan.get_herfindahl_index() == 1.0

    def test_two_equal_sectors_hhi(self) -> None:
        """Two sectors with equal stocks should have HHI = 0.5."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(5)],
        ]
        plan = create_plan(stocks)

        # 50% in each sector: HHI = 0.5^2 + 0.5^2 = 0.5
        assert abs(plan.get_herfindahl_index() - 0.5) < 0.001

    def test_four_equal_sectors_hhi(self) -> None:
        """Four sectors with equal stocks should have HHI = 0.25."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(5)],
            *[create_stock(f"FIN{i}", sector="Finance") for i in range(5)],
            *[create_stock(f"NRG{i}", sector="Energy") for i in range(5)],
        ]
        plan = create_plan(stocks)

        # 25% in each sector: HHI = 4 * 0.25^2 = 0.25
        assert abs(plan.get_herfindahl_index() - 0.25) < 0.001

    def test_empty_portfolio_hhi_is_zero(self) -> None:
        """Empty portfolio should have HHI = 0."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_herfindahl_index() == 0.0

    def test_unequal_sectors_hhi(self) -> None:
        """Unequal sector distribution should give correct HHI."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(6)],  # 60%
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(4)],  # 40%
        ]
        plan = create_plan(stocks)

        # HHI = 0.6^2 + 0.4^2 = 0.36 + 0.16 = 0.52
        assert abs(plan.get_herfindahl_index() - 0.52) < 0.001


class TestDiversificationScore:
    """Tests for the diversification score (1 - HHI)."""

    def test_single_sector_diversification_is_zero(self) -> None:
        """All stocks in one sector should have diversification = 0."""
        stocks = [create_stock(f"STK{i}", sector="Technology") for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_diversification_score() == 0.0

    def test_two_equal_sectors_diversification(self) -> None:
        """Two equal sectors should have diversification = 0.5."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(5)],
        ]
        plan = create_plan(stocks)

        assert abs(plan.get_diversification_score() - 0.5) < 0.001

    def test_four_equal_sectors_diversification(self) -> None:
        """Four equal sectors should have diversification = 0.75."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(5)],
            *[create_stock(f"FIN{i}", sector="Finance") for i in range(5)],
            *[create_stock(f"NRG{i}", sector="Energy") for i in range(5)],
        ]
        plan = create_plan(stocks)

        # 1 - HHI = 1 - 0.25 = 0.75
        assert abs(plan.get_diversification_score() - 0.75) < 0.001


class TestMaxSectorExposure:
    """Tests for max sector exposure calculation."""

    def test_single_sector_max_exposure_is_one(self) -> None:
        """All stocks in one sector should have max exposure = 1.0."""
        stocks = [create_stock(f"STK{i}", sector="Technology") for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_max_sector_exposure() == 1.0

    def test_two_equal_sectors_max_exposure(self) -> None:
        """Two equal sectors should have max exposure = 0.5."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(5)],
        ]
        plan = create_plan(stocks)

        assert abs(plan.get_max_sector_exposure() - 0.5) < 0.001

    def test_unequal_sectors_max_exposure(self) -> None:
        """Unequal sectors should return the larger weight."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology") for i in range(7)],  # 70%
            *[create_stock(f"HLTH{i}", sector="Healthcare") for i in range(3)],  # 30%
        ]
        plan = create_plan(stocks)

        assert abs(plan.get_max_sector_exposure() - 0.7) < 0.001

    def test_empty_portfolio_max_exposure_is_zero(self) -> None:
        """Empty portfolio should have max exposure = 0."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_max_sector_exposure() == 0.0


class TestSectorCount:
    """Tests for sector count calculation."""

    def test_single_sector(self) -> None:
        """All stocks in one sector should return count = 1."""
        stocks = [create_stock(f"STK{i}", sector="Technology") for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_sector_count() == 1

    def test_multiple_sectors(self) -> None:
        """Stocks in multiple sectors should return correct count."""
        stocks = [
            create_stock("TECH1", sector="Technology"),
            create_stock("HLTH1", sector="Healthcare"),
            create_stock("FIN1", sector="Finance"),
            create_stock("NRG1", sector="Energy"),
        ]
        plan = create_plan(stocks)

        assert plan.get_sector_count() == 4

    def test_empty_portfolio_sector_count_is_zero(self) -> None:
        """Empty portfolio should have sector count = 0."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_sector_count() == 0


class TestExpectedReturn:
    """Tests for expected return calculation."""

    def test_uniform_returns(self) -> None:
        """Stocks with same returns should give that return."""
        stocks = [create_stock(f"STK{i}", predicted_return=0.10) for i in range(5)]
        plan = create_plan(stocks)

        assert abs(plan.get_expected_return() - 0.10) < 0.001

    def test_mixed_returns(self) -> None:
        """Mixed returns should give weighted average."""
        stocks = [
            create_stock("STK1", predicted_return=0.10),  # 10%
            create_stock("STK2", predicted_return=0.20),  # 20%
        ]
        plan = create_plan(stocks)

        # Equal weight: (0.10 + 0.20) / 2 = 0.15
        assert abs(plan.get_expected_return() - 0.15) < 0.001

    def test_empty_portfolio_return_is_zero(self) -> None:
        """Empty portfolio should have return = 0."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_expected_return() == 0.0


class TestReturnVolatility:
    """Tests for return volatility (std dev) calculation."""

    def test_uniform_returns_zero_volatility(self) -> None:
        """All same returns should give volatility = 0."""
        stocks = [create_stock(f"STK{i}", predicted_return=0.10) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_return_volatility() == 0.0

    def test_varied_returns_nonzero_volatility(self) -> None:
        """Varied returns should give positive volatility."""
        stocks = [
            create_stock("STK1", predicted_return=0.05),
            create_stock("STK2", predicted_return=0.10),
            create_stock("STK3", predicted_return=0.15),
            create_stock("STK4", predicted_return=0.20),
        ]
        plan = create_plan(stocks)

        # Mean = 0.125, variance = ((0.05-0.125)^2 + (0.10-0.125)^2 + (0.15-0.125)^2 + (0.20-0.125)^2) / 4
        # = (0.005625 + 0.000625 + 0.000625 + 0.005625) / 4 = 0.003125
        # Std dev = sqrt(0.003125) ≈ 0.0559
        expected_vol = math.sqrt(0.003125)
        assert abs(plan.get_return_volatility() - expected_vol) < 0.0001

    def test_single_stock_zero_volatility(self) -> None:
        """Single stock should have volatility = 0 (need at least 2)."""
        stocks = [create_stock("STK1", predicted_return=0.10)]
        plan = create_plan(stocks)

        assert plan.get_return_volatility() == 0.0


class TestSharpeProxy:
    """Tests for Sharpe ratio proxy calculation."""

    def test_positive_sharpe(self) -> None:
        """Positive return with volatility should give positive Sharpe."""
        stocks = [
            create_stock("STK1", predicted_return=0.05),
            create_stock("STK2", predicted_return=0.10),
            create_stock("STK3", predicted_return=0.15),
            create_stock("STK4", predicted_return=0.20),
        ]
        plan = create_plan(stocks)

        # Return = 0.125, volatility = 0.0559
        # Sharpe = 0.125 / 0.0559 ≈ 2.24
        sharpe = plan.get_sharpe_proxy()
        assert sharpe > 2.0
        assert sharpe < 2.5

    def test_zero_volatility_zero_sharpe(self) -> None:
        """Zero volatility should give Sharpe = 0 (undefined)."""
        stocks = [create_stock(f"STK{i}", predicted_return=0.10) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_sharpe_proxy() == 0.0

    def test_empty_portfolio_zero_sharpe(self) -> None:
        """Empty portfolio should have Sharpe = 0."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        assert plan.get_sharpe_proxy() == 0.0


class TestPlanToMetrics:
    """Tests for the plan_to_metrics converter function."""

    def test_metrics_from_valid_portfolio(self) -> None:
        """plan_to_metrics should return all metrics for valid portfolio."""
        stocks = [
            *[create_stock(f"TECH{i}", sector="Technology", predicted_return=0.12) for i in range(5)],
            *[create_stock(f"HLTH{i}", sector="Healthcare", predicted_return=0.08) for i in range(5)],
        ]
        plan = create_plan(stocks)

        metrics = plan_to_metrics(plan)

        assert metrics is not None
        assert isinstance(metrics, PortfolioMetricsModel)
        assert metrics.sector_count == 2
        assert abs(metrics.expected_return - 0.10) < 0.001
        assert abs(metrics.diversification_score - 0.5) < 0.001
        assert abs(metrics.herfindahl_index - 0.5) < 0.001
        assert abs(metrics.max_sector_exposure - 0.5) < 0.001

    def test_metrics_from_empty_portfolio_is_none(self) -> None:
        """plan_to_metrics should return None for empty portfolio."""
        stocks = [create_stock(f"STK{i}", selected=False) for i in range(5)]
        plan = create_plan(stocks)

        metrics = plan_to_metrics(plan)

        assert metrics is None

    def test_metrics_serialization(self) -> None:
        """Metrics should serialize with camelCase aliases."""
        stocks = [create_stock(f"STK{i}") for i in range(5)]
        plan = create_plan(stocks)

        metrics = plan_to_metrics(plan)
        assert metrics is not None

        data = metrics.model_dump(by_alias=True)
        assert "expectedReturn" in data
        assert "sectorCount" in data
        assert "maxSectorExposure" in data
        assert "herfindahlIndex" in data
        assert "diversificationScore" in data
        assert "returnVolatility" in data
        assert "sharpeProxy" in data