src/constraints/no_group_conflict.rs

use crate::domain::{Lesson, Plan, Timeslot, Weekday};
use chrono::NaiveTime;
use solverforge::prelude::*;
use solverforge::IncrementalConstraint;

/// HARD: No two lessons for the same group can overlap in time.
struct AssignedLessonSlot {
    lesson_index: usize,
    group_idx: usize,
    day_of_week: Weekday,
    start_time: NaiveTime,
    end_time: NaiveTime,
}

pub fn constraint() -> impl IncrementalConstraint<Plan, HardMediumSoftScore> {
    use solverforge::stream::joiner::{equal, equal_bi};

    ConstraintFactory::<Plan, HardMediumSoftScore>::new()
        .for_each(Plan::lessons())
        // First attach the assigned timeslot to each lesson. Unassigned
        // lessons do not join here, so this rule does not duplicate the medium
        // assignment penalty.
        .join((
            ConstraintFactory::<Plan, HardMediumSoftScore>::new().for_each(Plan::timeslots()),
            equal_bi(
                |lesson: &Lesson| lesson.timeslot_idx,
                |timeslot: &Timeslot| Some(timeslot.index),
            ),
        ))
        // Reduce each joined row to the fields needed to detect a cohort
        // collision. This keeps the later pairwise join small and readable.
        .project(|lesson: &Lesson, timeslot: &Timeslot| AssignedLessonSlot {
            lesson_index: lesson.index,
            group_idx: lesson.group_idx,
            day_of_week: timeslot.day_of_week,
            start_time: timeslot.start_time,
            end_time: timeslot.end_time,
        })
        .join(equal(|row: &AssignedLessonSlot| row.group_idx))
        // `lesson_index < b.lesson_index` avoids scoring the same conflicting
        // pair twice. The strict time comparisons implement ordinary interval
        // overlap, so a lesson ending at 10:00 does not conflict with one
        // starting at 10:00.
        .filter(|a: &AssignedLessonSlot, b: &AssignedLessonSlot| {
            a.lesson_index < b.lesson_index
                && a.day_of_week == b.day_of_week
                && a.start_time < b.end_time
                && b.start_time < a.end_time
        })
        .penalize(hard_weight(
            |_: &AssignedLessonSlot, _: &AssignedLessonSlot| HardMediumSoftScore::of_hard(1),
        ))
        .named("No Group Conflict")
}

#[cfg(test)]
mod tests {
    use crate::domain::Group;

    use super::*;

    fn time(hour: u32, min: u32) -> NaiveTime {
        NaiveTime::from_hms_opt(hour, min, 0).unwrap()
    }

    // Helper that only runs the No Group Conflict constraint
    fn evaluate_only_group_conflict(plan: &Plan) -> HardMediumSoftScore {
        let constraint_set = (constraint(),);
        constraint_set.evaluate_all(plan)
    }

    #[test]
    fn detects_group_conflict_same_timeslot() {
        let groups = vec![Group::new(0, "Group A", 30, [true; 10])];
        let timeslots = vec![Timeslot::new(0, Weekday::Mon, time(8, 0), time(10, 0))];
        let teachers = vec![];
        let rooms = vec![];
        // Same group, no teacher assignment to avoid teacher conflict, no room assignment to avoid room conflict
        let mut lessons = vec![
            Lesson::new(0, "Math".to_string(), 0, None, 120),
            Lesson::new(1, "Physics".to_string(), 0, None, 120),
        ];
        lessons[0].timeslot_idx = Some(0);
        lessons[1].timeslot_idx = Some(0);

        let plan = Plan::new(timeslots, teachers, groups, lessons, rooms);
        let score = evaluate_only_group_conflict(&plan);

        assert_eq!(
            score.hard(),
            -1,
            "Expected hard score -1 for group conflict"
        );
    }

    #[test]
    fn detects_group_conflict_overlapping_timeslots() {
        let groups = vec![Group::new(0, "Group A", 30, [true; 10])];
        let timeslots = vec![
            Timeslot::new(0, Weekday::Mon, time(8, 0), time(10, 0)),
            Timeslot::new(1, Weekday::Mon, time(9, 0), time(11, 0)),
        ];
        let teachers = vec![];
        let rooms = vec![];
        let mut lessons = vec![
            Lesson::new(0, "Math".to_string(), 0, None, 120),
            Lesson::new(1, "Physics".to_string(), 0, None, 120),
        ];
        lessons[0].timeslot_idx = Some(0);
        lessons[1].timeslot_idx = Some(1);

        let plan = Plan::new(timeslots, teachers, groups, lessons, rooms);
        let score = evaluate_only_group_conflict(&plan);

        assert_eq!(
            score.hard(),
            -1,
            "Expected hard score -1 for overlapping group conflict"
        );
    }

    #[test]
    fn no_conflict_different_groups() {
        let groups = vec![
            Group::new(0, "Group A", 30, [true; 10]),
            Group::new(1, "Group B", 30, [true; 10]),
        ];
        let timeslots = vec![Timeslot::new(0, Weekday::Mon, time(8, 0), time(10, 0))];
        let teachers = vec![];
        let rooms = vec![];
        let mut lessons = vec![
            Lesson::new(0, "Math".to_string(), 0, None, 120),
            Lesson::new(1, "Physics".to_string(), 1, None, 120),
        ];
        lessons[0].timeslot_idx = Some(0);
        lessons[1].timeslot_idx = Some(0);

        let plan = Plan::new(timeslots, teachers, groups, lessons, rooms);
        let score = evaluate_only_group_conflict(&plan);

        assert_eq!(
            score.hard(),
            0,
            "Expected hard score 0 for different groups"
        );
    }

    #[test]
    fn no_conflict_non_overlapping_timeslots() {
        let groups = vec![Group::new(0, "Group A", 30, [true; 10])];
        let timeslots = vec![
            Timeslot::new(0, Weekday::Mon, time(8, 0), time(10, 0)),
            Timeslot::new(1, Weekday::Mon, time(10, 0), time(12, 0)),
        ];
        let teachers = vec![];
        let rooms = vec![];
        let mut lessons = vec![
            Lesson::new(0, "Math".to_string(), 0, None, 120),
            Lesson::new(1, "Physics".to_string(), 0, None, 120),
        ];
        lessons[0].timeslot_idx = Some(0);
        lessons[1].timeslot_idx = Some(1);

        let plan = Plan::new(timeslots, teachers, groups, lessons, rooms);
        let score = evaluate_only_group_conflict(&plan);

        assert_eq!(
            score.hard(),
            0,
            "Expected hard score 0 for non-overlapping timeslots"
        );
    }
}