robust null checking for process_response

python_code_executor_service.py

@@ -43,10 +43,8 @@ class AnalysisOperation(BaseModel):
 class CsvChatResult(BaseModel):
     """Structured response for CSV-related AI interactions"""
     casual_response: str
-    # analysis_operations: List[AnalysisOperation]
-    # charts: Optional[List[ChartSpecification]] = None
-    analysis_operations: Optional[AnalysisOperation] = None
-    charts: Optional[ChartSpecification] = None
+    analysis_operations: Optional[AnalysisOperation] 
+    charts: Optional[ChartSpecification] 
 
 
 class PythonExecutor:
@@ -196,82 +194,74 @@ class PythonExecutor:
         return str(result)
     
     async def process_response(self, response: CsvChatResult, chat_id: str) -> str:
-     """Process the response with comprehensive error handling"""
-     if not response or not response.casual_response:
-        return "⚠️ Error: Empty response received"
-
-     output_parts = [response.casual_response]
+        """Process the response with proper variable handling and error checking"""
+        output_parts = [response.casual_response]
     
-     # Process analysis operation if present and valid
-     if hasattr(response, 'analysis_operations') and response.analysis_operations:
-        try:
-            operation = response.analysis_operations
-            
-            # Validate operation structure
-            if not hasattr(operation, 'code') or not operation.code:
-                output_parts.append("\n⚠️ Analysis operation missing code")
-            elif not hasattr(operation.code, 'code') or not operation.code.code:
-                output_parts.append("\n⚠️ Analysis operation has empty code")
-            elif not hasattr(operation, 'result_var') or not operation.result_var:
-                output_parts.append("\n⚠️ Analysis operation missing result variable")
-            else:
-                # Execute the operation if all checks pass
-                execution_result = self.execute_code(operation.code.code)
+        # Initialize execution_result to avoid reference before assignment
+        execution_result = None
+        operation = None
+    
+        # Process analysis operation if it exists
+        if response.analysis_operations is not None:
+            try:
+                operation = response.analysis_operations
+                if operation and operation.code and operation.code.code:
+                    execution_result = self.execute_code(operation.code.code)
                 
-                if execution_result.get('error'):
-                    output_parts.append(f"\n❌ Error in analysis operation:")
-                    output_parts.append("```python\n" + execution_result['error']['message'] + "\n```")
-                else:
+                    # Get the result from locals
                     result = self.exec_locals.get(operation.result_var)
-                    
-                    if result is None:
-                        output_parts.append(f"\n⚠️ Operation completed but no result found in variable '{operation.result_var}'")
-                    elif hasattr(result, '__len__') and len(result) == 0:
-                        output_parts.append("\n⚠️ Operation returned empty results")
+                
+                    if execution_result.get('error'):
+                        output_parts.append(f"\n❌ Error in operation '{operation.result_var}':")
+                        output_parts.append("```python\n" + execution_result['error']['message'] + "\n```")
+                    elif result is not None:
+                        # Handle empty/None results
+                        if result is None or (hasattr(result, '__len__') and len(result) == 0):
+                            output_parts.append(f"\n⚠️ Values are missing - Operation '{operation.result_var}' returned no data")
+                        else:
+                            output_parts.append(f"\n🔹 Result for '{operation.result_var}':")
+                            output_parts.append("```python\n" + self._format_result(result) + "\n```")
                     else:
-                        output_parts.append(f"\n🔹 Operation results:")
-                        output_parts.append("```python\n" + self._format_result(result) + "\n```")
-                        
-                    if execution_result.get('output'):
-                        output_parts.append("Console output:\n```\n" + execution_result['output'] + "\n```")
-                        
-        except Exception as e:
-            output_parts.append(f"\n❌ Unexpected error processing analysis operation: {str(e)}")
+                        output_str = execution_result.get('output', '').strip()
+                        if output_str:
+                            output_parts.append("```\n" + output_str + "\n```")
+                else:
+                    output_parts.append("\n⚠️ Invalid analysis operation - missing code or result variable")
+            except Exception as e:
+                output_parts.append(f"\n❌ Error processing analysis operation: {str(e)}")
+                if operation:
+                    output_parts.append(f"Operation: {operation.result_var}")
     
-     # Process chart if present and valid
-     if hasattr(response, 'charts') and response.charts:
-        try:
+        # Process chart if it exists
+        if response.charts is not None:
+            output_parts.append("\n📊 Visualizations:")
             chart = response.charts
-            
-            # Validate chart structure
-            if not hasattr(chart, 'image_description') or not chart.image_description:
-                output_parts.append("\n⚠️ Chart missing description")
-            elif not hasattr(chart, 'code') or not chart.code:
-                output_parts.append("\n⚠️ Chart specification missing code")
-            else:
-                chart_result = self.execute_code(chart.code)
-                
-                if chart_result.get('error'):
-                    output_parts.append(f"\n❌ Error generating chart '{chart.image_description}':")
-                    output_parts.append("```python\n" + chart_result['error']['message'] + "\n```")
-                elif not chart_result.get('plots'):
-                    output_parts.append(f"\n⚠️ No chart generated for '{chart.image_description}'")
+            try:
+                if chart and (chart.code or chart.image_description):
+                    if chart.code:
+                        chart_result = self.execute_code(chart.code)
+                        if chart_result.get('plots'):
+                            for plot_data in chart_result['plots']:
+                                try:
+                                    public_url = await self.save_plot_to_supabase(
+                                        plot_data=plot_data,
+                                        description=chart.image_description,
+                                        chat_id=chat_id
+                                    )
+                                    output_parts.append(f"\n🖼️ {chart.image_description}")
+                                    output_parts.append(f"![{chart.image_description}]({public_url})")
+                                except Exception as e:
+                                    output_parts.append(f"\n⚠️ Error uploading chart: {str(e)}")
+                        elif chart_result.get('error'):
+                            output_parts.append("```python\n" + f"Error generating {chart.image_description}: {chart_result['error']['message']}" + "\n```")
+                        else:
+                            output_parts.append(f"\n⚠️ No chart generated for '{chart.image_description}'")
+                    else:
+                        output_parts.append(f"\n⚠️ No code provided for chart: {chart.image_description}")
                 else:
-                    output_parts.append("\n📊 Visualization:")
-                    for plot_data in chart_result['plots']:
-                        try:
-                            public_url = await self.save_plot_to_supabase(
-                                plot_data=plot_data,
-                                description=chart.image_description,
-                                chat_id=chat_id
-                            )
-                            output_parts.append(f"\n🖼️ {chart.image_description}")
-                            output_parts.append(f"![{chart.image_description}]({public_url})")
-                        except Exception as upload_error:
-                            output_parts.append(f"\n⚠️ Failed to upload chart: {str(upload_error)}")
-                            
-        except Exception as e:
-            output_parts.append(f"\n❌ Unexpected error processing chart: {str(e)}")
+                    output_parts.append("\n⚠️ Invalid chart specification")
+            except Exception as e:
+                output_parts.append(f"\n❌ Error processing chart: {str(e)}")
     
         return "\n".join(output_parts)