File size: 6,754 Bytes
a21d9ae
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
import unittest
import sys
import os

sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))

from environment.env import CodeReviewEnv
from environment.models import ReviewAction, ReviewActionType, Comment, Suggestion


class TestCodeReviewEnv(unittest.TestCase):
    
    def setUp(self):
        self.env = CodeReviewEnv()
    
    def test_reset(self):
        obs = self.env.reset(task_id="bug_detection_easy_1")
        
        self.assertIsNotNone(obs)
        self.assertEqual(obs["task_difficulty"], "easy")
        self.assertEqual(obs["current_step"], 0)
        self.assertIn("code_diff", obs)
        self.assertIn("file_context", obs)
    
    def test_step_add_comment(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.ADD_COMMENT,
            comments=[
                Comment(
                    line_number=3,
                    content="Potential division by zero if list is empty",
                    is_issue=True,
                    severity="high"
                )
            ],
            suggestions=[]
        )
        
        obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertFalse(done)
        self.assertGreaterEqual(reward, 0)
        self.assertTrue(info["last_action_valid"])
        self.assertEqual(len(obs["previous_comments"]), 1)
    
    def test_step_suggest_fix(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.SUGGEST_FIX,
            comments=[],
            suggestions=[
                Suggestion(
                    original_line=3,
                    suggested_code="return total / len(numbers) if numbers else 0",
                    explanation="Add check for empty list"
                )
            ]
        )
        
        obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertFalse(done)
        self.assertEqual(len(obs["previous_suggestions"]), 1)
    
    def test_step_approve(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.APPROVE,
            comments=[],
            suggestions=[],
            final_decision="approved"
        )
        
        obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertTrue(done)
        self.assertEqual(obs["final_decision_made"], "approved")
    
    def test_step_request_changes(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.REQUEST_CHANGES,
            comments=[],
            suggestions=[],
            final_decision="changes_requested"
        )
        
        obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertTrue(done)
        self.assertEqual(obs["final_decision_made"], "changes_requested")
    
    def test_max_steps(self):
        self.env.reset(task_id="bug_detection_easy_1")
        self.env.max_steps = 3
        
        for i in range(3):
            action = ReviewAction(
                action_type=ReviewActionType.ADD_COMMENT,
                comments=[
                    Comment(
                        line_number=3,
                        content=f"Comment {i}",
                        is_issue=True
                    )
                ],
                suggestions=[]
            )
            obs, reward, done, info = self.env.step(action.model_dump())
            
            if i < 2:
                self.assertFalse(done)
            else:
                self.assertTrue(done)
    
    def test_invalid_line_number(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.ADD_COMMENT,
            comments=[
                Comment(
                    line_number=100,
                    content="Invalid line",
                    is_issue=True
                )
            ],
            suggestions=[]
        )
        
        obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertFalse(info["last_action_valid"])
        self.assertIsNotNone(info["error"])
        self.assertEqual(len(obs["previous_comments"]), 0)
    
    def test_get_task_score(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        action = ReviewAction(
            action_type=ReviewActionType.ADD_COMMENT,
            comments=[
                Comment(
                    line_number=3,
                    content="Division by zero issue",
                    is_issue=True,
                    severity="high"
                )
            ],
            suggestions=[
                Suggestion(
                    original_line=3,
                    suggested_code="return total / len(numbers) if numbers else 0",
                    explanation="Fix division by zero"
                )
            ],
            final_decision="changes_requested"
        )
        
        self.env.step(action.model_dump())
        
        score = self.env.get_task_score()
        
        self.assertGreaterEqual(score, 0)
        self.assertLessEqual(score, 1.0)
    
    def test_state_method(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        state = self.env.state()
        
        self.assertIsInstance(state, dict)
        self.assertIn("code_context", state)
        self.assertIn("task_metadata", state)
    
    def test_multiple_actions(self):
        self.env.reset(task_id="bug_detection_easy_1")
        
        actions = [
            ReviewAction(
                action_type=ReviewActionType.ADD_COMMENT,
                comments=[Comment(line_number=3, content="Issue 1", is_issue=True)],
                suggestions=[]
            ),
            ReviewAction(
                action_type=ReviewActionType.SUGGEST_FIX,
                comments=[],
                suggestions=[Suggestion(original_line=3, suggested_code="fix", explanation="Fix")]
            ),
            ReviewAction(
                action_type=ReviewActionType.REQUEST_CHANGES,
                comments=[],
                suggestions=[],
                final_decision="changes_requested"
            )
        ]
        
        for action in actions:
            obs, reward, done, info = self.env.step(action.model_dump())
        
        self.assertTrue(done)
        score = self.env.get_task_score()
        self.assertGreater(score, 0)


if __name__ == "__main__":
    unittest.main()