Fix all odds paths: per-event endpoint + regions + cache bypass

Upcoming path (Props page):
- Add regions=us to per-event odds_params (documented as required; absence
caused API to return bookmakers:[] silently, producing zero rows)
- Lower _MAX_EVENTS 20→15 (covers full Opening Day slate)
- Add event-ID dedup guard before each per-event request
- Track 429s specifically in per-event except block
- Replace final log with SUMMARY line (events_returned/attempted/rate_limited/rows)
- Fix render_props fallback: remove `not raw_props.empty` guard so cached empty
results are not bypassed, eliminating uncached re-fetch on every Streamlit rerun

Live path (Dashboard):
- Replace aggregate /odds endpoint (422 on player props) with two-step per-event
approach: GET /events (commenceTimeFrom=now-6h to capture live games) → match
teams via _canon_team → GET /events/{id}/odds with regions=us + requested markets
- Function signature and row dict schema unchanged; all callers unaffected

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

data/provider_theoddsapi.py

@@ -49,7 +49,7 @@ BOOK_KEY_MAP = {
     "williamhill_us": "Caesars",
 }
 
-_MAX_EVENTS = 20
+_MAX_EVENTS = 15
 
 TEAM_NAME_ALIASES = {
     "usa": "united states",
@@ -121,12 +121,54 @@ class TheOddsAPIProvider(MarketProviderBase):
         away_key = _canon_team(game_context.get("away_team", ""))
         home_key = _canon_team(game_context.get("home_team", ""))
 
-        # Current provider path uses MLB sport key.
-        # This may not return WBC prop markets even when books offer them.
-        sport_key = "baseball_mlb"
+        from datetime import datetime, timezone, timedelta
 
-        url = f"{ODDS_API_BASE}/{sport_key}/odds"
-        params = {
+        now = datetime.now(timezone.utc)
+        events_url = f"{ODDS_API_BASE}/baseball_mlb/events"
+        events_params = {
+            "apiKey": ODDS_API_KEY,
+            "dateFormat": "iso",
+            "commenceTimeFrom": (now - timedelta(hours=6)).strftime("%Y-%m-%dT%H:%M:%SZ"),
+            "commenceTimeTo": (now + timedelta(days=1)).strftime("%Y-%m-%dT%H:%M:%SZ"),
+        }
+
+        try:
+            r1 = requests.get(events_url, params=events_params, timeout=30)
+            r1.raise_for_status()
+        except requests.HTTPError as exc:
+            body = (exc.response.text[:300] if exc.response is not None else "")
+            raise RuntimeError(
+                f"Odds API events list HTTP {exc.response.status_code}: {body}"
+            ) from exc
+        except requests.RequestException as exc:
+            raise RuntimeError(f"Odds API events network error: {exc}") from exc
+
+        events = r1.json()
+
+        # Find the event matching this game's teams
+        event_id = None
+        away_team_orig = ""
+        home_team_orig = ""
+        commence_time = ""
+        for ev in events:
+            ev_away = _canon_team(ev.get("away_team", ""))
+            ev_home = _canon_team(ev.get("home_team", ""))
+            if ev_away == away_key and ev_home == home_key:
+                event_id = str(ev.get("id", "") or "")
+                away_team_orig = str(ev.get("away_team", "") or "")
+                home_team_orig = str(ev.get("home_team", "") or "")
+                commence_time = str(ev.get("commence_time", "") or "")
+                break
+
+        if not event_id:
+            _diag_log.info(
+                "[live_prop_odds] no matching event for %s@%s in %d events",
+                away_key, home_key, len(events),
+            )
+            return pd.DataFrame()
+
+        odds_url = f"{ODDS_API_BASE}/baseball_mlb/events/{event_id}/odds"
+        odds_params = {
             "apiKey": ODDS_API_KEY,
             "regions": "us",
             "markets": ",".join(mkts),
@@ -135,60 +177,60 @@ class TheOddsAPIProvider(MarketProviderBase):
             "dateFormat": "iso",
         }
 
-        response = requests.get(url, params=params, timeout=30)
-        response.raise_for_status()
-        payload = response.json()
-
-        rows: list[dict[str, Any]] = []
-
-        for event in payload:
-            event_away = _canon_team(event.get("away_team", ""))
-            event_home = _canon_team(event.get("home_team", ""))
-
-            if event_away != away_key or event_home != home_key:
-                continue
+        try:
+            r2 = requests.get(odds_url, params=odds_params, timeout=30)
+            r2.raise_for_status()
+        except requests.HTTPError as exc:
+            body = (exc.response.text[:300] if exc.response is not None else "")
+            raise RuntimeError(
+                f"Odds API event odds HTTP {exc.response.status_code}: {body}"
+            ) from exc
+        except requests.RequestException as exc:
+            raise RuntimeError(f"Odds API event odds network error: {exc}") from exc
 
-            event_id = str(event.get("id", "") or "")
-            commence_time = str(event.get("commence_time", "") or "")
+        event_data = r2.json()
+        bookmakers = (
+            event_data.get("bookmakers", []) if isinstance(event_data, dict) else []
+        )
 
-            for bookmaker in event.get("bookmakers", []) or []:
-                book_key = str(bookmaker.get("key", "") or "")
-                book_name = BOOK_KEY_MAP.get(book_key, book_key)
+        rows: list[dict[str, Any]] = []
 
-                for market in bookmaker.get("markets", []) or []:
-                    market_key = str(market.get("key", "") or "")
-                    market_name = MARKET_NAME_MAP.get(market_key, market_key)
+        for bookmaker in bookmakers:
+            book_key = str(bookmaker.get("key", "") or "")
+            book_name = BOOK_KEY_MAP.get(book_key, book_key)
 
-                    for outcome in market.get("outcomes", []) or []:
-                        player_name_raw = str(
-                            outcome.get("description", "") or outcome.get("name", "") or ""
-                        ).strip()
-                        if not player_name_raw:
-                            continue
+            for market in bookmaker.get("markets", []) or []:
+                market_key = str(market.get("key", "") or "")
+                market_name = MARKET_NAME_MAP.get(market_key, market_key)
 
-                        price = outcome.get("price")
-                        if price is None:
-                            continue
+                for outcome in market.get("outcomes", []) or []:
+                    player_name_raw = str(
+                        outcome.get("description", "") or outcome.get("name", "") or ""
+                    ).strip()
+                    if not player_name_raw:
+                        continue
 
-                        line = _safe_float(outcome.get("point"))
+                    price = outcome.get("price")
+                    if price is None:
+                        continue
 
-                        rows.append(
-                            {
-                                "provider": self.provider_name,
-                                "event_id": event_id,
-                                "commence_time": commence_time,
-                                "away_team": event.get("away_team", ""),
-                                "home_team": event.get("home_team", ""),
-                                "sportsbook": book_name,
-                                "sportsbook_key": book_key,
-                                "market_key": market_key,
-                                "market": market_name,
-                                "player_name_raw": player_name_raw,
-                                "player_name": map_odds_name_to_model_name(player_name_raw),
-                                "odds_american": int(price),
-                                "line": line,
-                            }
-                        )
+                    rows.append(
+                        {
+                            "provider": self.provider_name,
+                            "event_id": event_id,
+                            "commence_time": commence_time,
+                            "away_team": away_team_orig,
+                            "home_team": home_team_orig,
+                            "sportsbook": book_name,
+                            "sportsbook_key": book_key,
+                            "market_key": market_key,
+                            "market": market_name,
+                            "player_name_raw": player_name_raw,
+                            "player_name": map_odds_name_to_model_name(player_name_raw),
+                            "odds_american": int(price),
+                            "line": _safe_float(outcome.get("point")),
+                        }
+                    )
 
         return pd.DataFrame(rows)
 
@@ -249,11 +291,18 @@ class TheOddsAPIProvider(MarketProviderBase):
         events = events[:_MAX_EVENTS]
 
         rows: list[dict[str, Any]] = []
+        seen_ids: set[str] = set()
+        _events_attempted = 0
+        _events_rate_limited = 0
 
         for event in events:
             event_id = str(event.get("id", "") or "")
             if not event_id:
                 continue
+            if event_id in seen_ids:
+                continue
+            seen_ids.add(event_id)
+            _events_attempted += 1
             away_team = str(event.get("away_team", "") or "")
             home_team = str(event.get("home_team", "") or "")
             commence_time = str(event.get("commence_time", "") or "")
@@ -261,6 +310,7 @@ class TheOddsAPIProvider(MarketProviderBase):
             odds_url = f"{ODDS_API_BASE}/baseball_mlb/events/{event_id}/odds"
             odds_params = {
                 "apiKey": ODDS_API_KEY,
+                "regions": "us",
                 "markets": "batter_home_runs",
                 "bookmakers": ",".join(books),
                 "oddsFormat": "american",
@@ -286,9 +336,16 @@ class TheOddsAPIProvider(MarketProviderBase):
                 )
                 r2.raise_for_status()
             except (requests.HTTPError, requests.RequestException) as exc:
+                _is_429 = (
+                    isinstance(exc, requests.HTTPError)
+                    and exc.response is not None
+                    and exc.response.status_code == 429
+                )
+                if _is_429:
+                    _events_rate_limited += 1
                 _diag_log.warning(
-                    "[upcoming_hr_props] event %s@%s odds failed: %s",
-                    away_team, home_team, exc,
+                    "[upcoming_hr_props] event %s@%s odds failed (429=%s): %s",
+                    away_team, home_team, _is_429, exc,
                 )
                 continue
 
@@ -390,5 +447,12 @@ class TheOddsAPIProvider(MarketProviderBase):
                 _skip_market_mismatch, _skip_empty_name, _skip_missing_price,
             )
 
-        _diag_log.info("[upcoming_hr_props] total rows=%d", len(rows))
+        _diag_log.info(
+            "[upcoming_hr_props] SUMMARY events_returned=%d events_attempted=%d "
+            "events_rate_limited=%d total_rows=%d",
+            len(events),
+            _events_attempted,
+            _events_rate_limited,
+            len(rows),
+        )
         return pd.DataFrame(rows)

visualization/props_page.py

@@ -55,8 +55,9 @@ def _format_edge(val: float | None) -> str:
 def render_props(statcast_df: pd.DataFrame, conn=None, raw_props: pd.DataFrame | None = None) -> None:
     st.subheader("Props")
 
-    # Use pre-fetched (cached) props when available; fall back to direct fetch
-    if raw_props is not None and not raw_props.empty:
+    # Use pre-fetched (cached) props when available.
+    # If caller passed raw_props (even empty), use it — do not re-fetch and bypass the cache.
+    if raw_props is not None:
         raw = raw_props
     else:
         with st.spinner("Loading props..."):