Fix Discord command option ordering

src/commands.js

@@ -69,6 +69,25 @@ const MARKET_INTELLIGENCE_MARKET_CHOICES = [
 ];
 
 function addMarketIntelligenceFilters(command, options = {}) {
+  if (options.includeBook && options.bookRequired === true) {
+    command.addStringOption((option) =>
+      option
+        .setName('book')
+        .setDescription('Optional book filter.')
+        .setRequired(true)
+        .addChoices(...MARKET_INTELLIGENCE_BOOK_CHOICES)
+    );
+  }
+
+  if (options.includePlayer && options.playerRequired === true) {
+    command.addStringOption((option) =>
+      option
+        .setName('player')
+        .setDescription('Optional player filter.')
+        .setRequired(true)
+    );
+  }
+
   if (options.includeMarket !== false) {
     command.addStringOption((option) =>
       option
@@ -79,12 +98,12 @@ function addMarketIntelligenceFilters(command, options = {}) {
     );
   }
 
-  if (options.includeBook) {
+  if (options.includeBook && options.bookRequired !== true) {
     command.addStringOption((option) =>
       option
         .setName('book')
         .setDescription('Optional book filter.')
-        .setRequired(options.bookRequired === true)
+        .setRequired(false)
         .addChoices(...MARKET_INTELLIGENCE_BOOK_CHOICES)
     );
   }
@@ -98,12 +117,12 @@ function addMarketIntelligenceFilters(command, options = {}) {
     );
   }
 
-  if (options.includePlayer) {
+  if (options.includePlayer && options.playerRequired !== true) {
     command.addStringOption((option) =>
       option
         .setName('player')
         .setDescription('Optional player filter.')
-        .setRequired(options.playerRequired === true)
+        .setRequired(false)
     );
   }