Add Circa button pagination and odds sorting

src/embeds.js

@@ -540,7 +540,15 @@ function chunkTextPages(lines, maxLength = 3400) {
 }
 
 export function buildCircaMarketEmbeds(snapshot, marketLabel, entries, options = {}) {
-  const displayEntries = entries.filter((entry) => entry.side !== 'no');
+  const displayEntries = [...entries]
+    .filter((entry) => entry.side !== 'no')
+    .sort((left, right) => {
+      const leftOdds = Number(left.oddsInput);
+      const rightOdds = Number(right.oddsInput);
+      const leftValue = Number.isFinite(leftOdds) ? leftOdds : Number.MAX_SAFE_INTEGER;
+      const rightValue = Number.isFinite(rightOdds) ? rightOdds : Number.MAX_SAFE_INTEGER;
+      return leftValue - rightValue || left.playerName.localeCompare(right.playerName);
+    });
   const lines = displayEntries.map((entry) => {
     const team = entry.team ? ` (${entry.team})` : '';
     const side = `${String(entry.side ?? '').toUpperCase()}${entry.lineValue !== null && entry.lineValue !== undefined ? ` ${entry.lineValue}` : ''}`;
@@ -565,6 +573,55 @@ export function buildCircaMarketEmbeds(snapshot, marketLabel, entries, options =
   );
 }
 
+export function buildCircaPageId({ userId, marketType, totalPages }, page) {
+  return [
+    'circa-page',
+    userId,
+    marketType,
+    page,
+    totalPages,
+  ].join('|');
+}
+
+export function parseCircaPageId(customId) {
+  const [prefix, userId, marketType, pageText, totalPagesText] = String(customId ?? '').split('|');
+  if (prefix !== 'circa-page' || !userId || !marketType) {
+    return null;
+  }
+
+  const page = Number(pageText);
+  const totalPages = Number(totalPagesText);
+  if (!Number.isInteger(page) || !Number.isInteger(totalPages)) {
+    return null;
+  }
+
+  return {
+    userId,
+    marketType,
+    page,
+    totalPages,
+  };
+}
+
+export function buildCircaPaginationRow(state) {
+  if (!state || state.totalPages <= 1) {
+    return null;
+  }
+
+  return new ActionRowBuilder().addComponents(
+    new ButtonBuilder()
+      .setCustomId(buildCircaPageId(state, Math.max(1, state.page - 1)))
+      .setLabel('Prev')
+      .setStyle(ButtonStyle.Secondary)
+      .setDisabled(state.page <= 1),
+    new ButtonBuilder()
+      .setCustomId(buildCircaPageId(state, Math.min(state.totalPages, state.page + 1)))
+      .setLabel('Next')
+      .setStyle(ButtonStyle.Secondary)
+      .setDisabled(state.page >= state.totalPages),
+  );
+}
+
 export function buildCircaMovementEmbed(movement, snapshot) {
   return new EmbedBuilder()
     .setColor(PALETTE.blue)

src/index.js

@@ -36,6 +36,7 @@ import {
   buildCircaAlertEmbed,
   buildCircaFailureEmbed,
   buildCircaMarketEmbeds,
+  buildCircaPaginationRow,
   buildDeleteBetEmbed,
   buildEditBetEmbed,
   buildErrorEmbed,
@@ -51,6 +52,7 @@ import {
   parseAlertRoleButtonId,
   buildBetsPageId,
   parseBetsPageId,
+  parseCircaPageId,
 } from './embeds.js';
 import { parseBulkAddInput } from './bulk-add.js';
 import { parseBetIdList } from './resolve-bulk.js';
@@ -1002,15 +1004,16 @@ async function handleCircaShortcut(interaction, config, marketType) {
     const embeds = buildCircaMarketEmbeds(market.snapshot, market.marketLabel, market.entries, {
       footerText: `Manual Circa view requested by ${interaction.user.displayName ?? interaction.user.username}`,
     });
+    const paginationRow = buildCircaPaginationRow({
+      userId: interaction.user.id,
+      marketType,
+      page: 1,
+      totalPages: embeds.length,
+    });
     await interaction.editReply({
       embeds: [embeds[0]],
+      components: paginationRow ? [paginationRow] : [],
     });
-
-    for (let index = 1; index < embeds.length; index += 1) {
-      await interaction.followUp({
-        embeds: [embeds[index]],
-      });
-    }
   } catch (error) {
     await interaction.editReply({
       embeds: [buildErrorEmbed('Circa market unavailable', error.message || 'The Circa market lookup hit an unexpected error.')],
@@ -1026,25 +1029,62 @@ async function handleButton(interaction, store) {
   }
 
   const pageState = parseBetsPageId(interaction.customId);
-  if (!pageState) {
+  if (pageState) {
+    if (pageState.userId !== interaction.user.id) {
+      await interaction.reply({
+        embeds: [buildErrorEmbed('Not your pager', 'Only the original user can turn pages on this bet ledger view.')],
+        flags: MessageFlags.Ephemeral,
+      });
+      return;
+    }
+
+    interaction.__betsFilters = {
+      dateWindow: pageState.dateWindow,
+      book: pageState.book,
+      sport: pageState.sport,
+      status: pageState.status,
+    };
+    await handleBets(interaction, store, pageState.page, true);
     return;
   }
 
-  if (pageState.userId !== interaction.user.id) {
+  const circaPageState = parseCircaPageId(interaction.customId);
+  if (!circaPageState) {
+    return;
+  }
+
+  if (circaPageState.userId !== interaction.user.id) {
     await interaction.reply({
-      embeds: [buildErrorEmbed('Not your pager', 'Only the original user can turn pages on this bet ledger view.')],
+      embeds: [buildErrorEmbed('Not your pager', 'Only the original user can turn pages on this Circa market view.')],
       flags: MessageFlags.Ephemeral,
     });
     return;
   }
 
-  interaction.__betsFilters = {
-    dateWindow: pageState.dateWindow,
-    book: pageState.book,
-    sport: pageState.sport,
-    status: pageState.status,
-  };
-  await handleBets(interaction, store, pageState.page, true);
+  const scanner = interaction.client.__marketScanner;
+  try {
+    const market = await scanner.getLatestCircaMarket(circaPageState.marketType);
+    const embeds = buildCircaMarketEmbeds(market.snapshot, market.marketLabel, market.entries, {
+      footerText: `Manual Circa view requested by ${interaction.user.displayName ?? interaction.user.username}`,
+    });
+    const safePage = Math.max(1, Math.min(circaPageState.page, embeds.length));
+    const paginationRow = buildCircaPaginationRow({
+      userId: interaction.user.id,
+      marketType: circaPageState.marketType,
+      page: safePage,
+      totalPages: embeds.length,
+    });
+
+    await interaction.update({
+      embeds: [embeds[safePage - 1]],
+      components: paginationRow ? [paginationRow] : [],
+    });
+  } catch (error) {
+    await interaction.reply({
+      embeds: [buildErrorEmbed('Circa market unavailable', error.message || 'The Circa market pager hit an unexpected error.')],
+      flags: MessageFlags.Ephemeral,
+    });
+  }
 }
 
 async function handleAlertRoleToggle(interaction, roleName) {