Update functions/PitchPlotFunctions.py

functions/PitchPlotFunctions.py

@@ -311,68 +311,83 @@ class PitchPlotFunctions:
     def break_plot_big(self, df: pl.DataFrame, ax: plt.Axes, sport_id: int):
         """
         Plots a big break plot for the given DataFrame on the provided axis.
-
-        Parameters:
-        df (pl.DataFrame): The DataFrame containing pitch data.
-        ax (plt.Axes): The matplotlib axis to plot on.
-        sport_id (int): The sport ID to determine the plot title.
         """
-        # Set font properties for different elements of the plot
+        # Set font properties
         font_properties = {'size': 10}
         font_properties_titles = {'size': 16}
         font_properties_axes = {'size': 14}
         
-        # Get unique pitch types sorted by 'prop' and 'pitch_type'
+        # Get unique pitch types
         label_labels = df.sort(by=['prop', 'pitch_type'], descending=[False, True])['pitch_type'].unique()
-        j = 0
         dict_colour, dict_pitch = self.pitch_colours()
         custom_theme, colour_palette = self.sns_custom_theme()
         
-        # Loop through each pitch type and plot confidence ellipses
+        # Plot confidence ellipses
         for label in label_labels:
             subset = df.filter(pl.col('pitch_type') == label)
             if len(subset) > 4:
                 try:
-                    if df['pitcher_hand'][0] == 'R':
-                        self.confidence_ellipse(subset['hb']* 1, subset['ivb'], ax=ax, edgecolor=dict_colour[label], n_std=2, facecolor=dict_colour[label], alpha=0.2)
-                    if df['pitcher_hand'][0] == 'L':
-                        self.confidence_ellipse(subset['hb'] * 1, subset['ivb'], ax=ax, edgecolor=dict_colour[label], n_std=2, facecolor=dict_colour[label], alpha=0.2)
+                    mult = 1 if df['pitcher_hand'][0] == 'R' else -1
+                    self.confidence_ellipse(
+                        subset['hb'] * mult, 
+                        subset['ivb'], 
+                        ax=ax, 
+                        edgecolor=dict_colour[label], 
+                        n_std=2, 
+                        facecolor=dict_colour[label], 
+                        alpha=0.2
+                    )
                 except ValueError:
                     return
-                j += 1
-            else:
-                j += 1
         
-        # Plot scatter plot of pitch data
-        if df['pitcher_hand'][0] == 'R':
-            sns.scatterplot(ax=ax, x=df['hb'] * 1, y=df['ivb'] * 1, hue=df['pitch_type'], palette=dict_colour, ec='black', alpha=1, zorder=2, s=35)
-        if df['pitcher_hand'][0] == 'L':
-            sns.scatterplot(ax=ax, x=df['hb'] * 1, y=df['ivb'] * 1, hue=df['pitch_type'], palette=dict_colour, ec='black', alpha=1, zorder=2, s=35)
+        # Plot scatter points
+        mult = 1 if df['pitcher_hand'][0] == 'R' else -1
+        sns.scatterplot(
+            ax=ax, 
+            x=df['hb'] * mult, 
+            y=df['ivb'], 
+            hue=df['pitch_type'], 
+            palette=dict_colour, 
+            ec='black', 
+            alpha=1, 
+            zorder=2, 
+            s=35
+        )
         
         # Set plot limits and labels
         ax.set_xlim((-25, 25))
         ax.set_ylim((-25, 25))
         ax.hlines(y=0, xmin=-50, xmax=50, color=colour_palette[8], alpha=0.5, linestyles='--', zorder=1)
         ax.vlines(x=0, ymin=-50, ymax=50, color=colour_palette[8], alpha=0.5, linestyles='--', zorder=1)
-        ax.set_xlabel('Horizontal Break (in)', fontdict=font_properties_axes)
-        ax.set_ylabel('Induced Vertical Break (in)', fontdict=font_properties_axes)
-        ax.set_title(f"{self.sport_id_dict()[sport_id]} - Short Form Pitch Movement Plot", fontdict=font_properties_titles)
+        
+        # Set labels with proper padding
+        ax.set_xlabel('Horizontal Break (in)', fontdict=font_properties_axes, labelpad=10)
+        ax.set_ylabel('Induced Vertical Break (in)', fontdict=font_properties_axes, labelpad=10)
+        ax.set_title(
+            f"{self.sport_id_dict()[sport_id]} - Short Form Pitch Movement Plot", 
+            fontdict=font_properties_titles,
+            pad=20  # Add padding between title and plot
+        )
         
         # Remove legend and set tick labels
         ax.get_legend().remove()
         ax.set_xticklabels(ax.get_xticks(), fontdict=font_properties)
         ax.set_yticklabels(ax.get_yticks(), fontdict=font_properties)
         
-        # Add text annotations based on pitcher hand
+        # Add text annotations
         if df['pitcher_hand'][0] == 'R':
-            ax.text(-24.5, -24.5, s='← Glove Side', fontstyle='italic', ha='left', va='bottom', bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
-            ax.text(24.5, -24.5, s='Arm Side →', fontstyle='italic', ha='right', va='bottom', bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
-        if df['pitcher_hand'][0] == 'L':
+            ax.text(-24.5, -24.5, s='← Glove Side', fontstyle='italic', ha='left', va='bottom', 
+                    bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
+            ax.text(24.5, -24.5, s='Arm Side →', fontstyle='italic', ha='right', va='bottom', 
+                    bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
+        else:
             ax.invert_xaxis()
-            ax.text(24.5, -24.5, s='← Arm Side', fontstyle='italic', ha='left', va='bottom', bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
-            ax.text(-24.5, -24.5, s='Glove Side →', fontstyle='italic', ha='right', va='bottom', bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
+            ax.text(24.5, -24.5, s='← Arm Side', fontstyle='italic', ha='left', va='bottom', 
+                    bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
+            ax.text(-24.5, -24.5, s='Glove Side →', fontstyle='italic', ha='right', va='bottom', 
+                    bbox=dict(facecolor='white', edgecolor='black'), fontsize=13, zorder=3)
         
-        # Set aspect ratio and format tick labels
+        # Set aspect ratio and tick formatters
         ax.set_aspect('equal', adjustable='box')
         ax.xaxis.set_major_formatter(FuncFormatter(lambda x, _: int(x)))
         ax.yaxis.set_major_formatter(FuncFormatter(lambda x, _: int(x)))