Spaces:
Running
Running
File size: 11,498 Bytes
ff9fcbd | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 | """
Tests for CodeReviewEnvironment.
Run with: pytest tests/ -v
Or: python -m pytest tests/ -v
"""
import sys
import os
sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
import pytest
from models import ReviewAction, ReviewObservation, ReviewState
from server.environment import CodeReviewEnvironment
from tasks.data import ALL_TASKS, TASK_IDS
# ---------------------------------------------------------------------------
# Fixtures
# ---------------------------------------------------------------------------
@pytest.fixture
def env():
return CodeReviewEnvironment()
@pytest.fixture
def env_bug(env):
env.reset(task_id="bug-detection")
return env
@pytest.fixture
def env_sec(env):
env.reset(task_id="security-audit")
return env
@pytest.fixture
def env_hard(env):
env.reset(task_id="comprehensive-review")
return env
# ---------------------------------------------------------------------------
# reset() tests
# ---------------------------------------------------------------------------
class TestReset:
def test_reset_returns_observation(self, env):
obs = env.reset()
assert isinstance(obs, ReviewObservation)
def test_reset_done_is_false(self, env):
obs = env.reset()
assert obs.done is False
def test_reset_reward_is_none(self, env):
obs = env.reset()
assert obs.reward is None
def test_reset_has_code_files(self, env):
obs = env.reset()
assert isinstance(obs.code_files, dict)
assert len(obs.code_files) > 0
def test_reset_step_count_zero(self, env):
obs = env.reset()
assert obs.step_count == 0
def test_reset_no_flagged_issues(self, env):
obs = env.reset()
assert obs.flagged_issues == []
def test_reset_specific_task(self, env):
for task_id in TASK_IDS:
obs = env.reset(task_id=task_id)
assert obs.task_id == task_id
def test_reset_bug_detection(self, env):
obs = env.reset(task_id="bug-detection")
assert "utils.py" in obs.code_files
def test_reset_security_audit(self, env):
obs = env.reset(task_id="security-audit")
assert "app.py" in obs.code_files
def test_reset_comprehensive(self, env):
obs = env.reset(task_id="comprehensive-review")
assert "views.py" in obs.code_files
assert "models.py" in obs.code_files
def test_reset_with_seed_is_reproducible(self, env):
obs1 = env.reset(seed=42)
task1 = obs1.task_id
obs2 = env.reset(seed=42)
task2 = obs2.task_id
assert task1 == task2
def test_reset_clears_previous_state(self, env):
env.reset(task_id="bug-detection")
env.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
obs = env.reset(task_id="bug-detection")
assert obs.flagged_issues == []
assert obs.step_count == 0
# ---------------------------------------------------------------------------
# step() — flag_issue tests
# ---------------------------------------------------------------------------
class TestFlagIssue:
def test_flag_increments_step_count(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
assert obs.step_count == 1
def test_flag_adds_to_flagged_issues(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
assert len(obs.flagged_issues) == 1
def test_flag_true_positive_gives_positive_reward(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="off-by-one"
))
assert obs.reward is not None and obs.reward > 0
def test_flag_false_positive_gives_negative_reward(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="flag_issue", line_number=100, filename="utils.py",
issue_type="bug", severity="low", description="nonexistent issue"
))
assert obs.reward is not None and obs.reward < 0
def test_flag_missing_line_number_gives_penalty(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="flag_issue", filename="utils.py",
issue_type="bug", severity="high", description="test"
))
assert obs.reward is not None and obs.reward <= 0
def test_flag_duplicate_line_no_change(self, env_bug):
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
obs = env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="same line again"
))
assert len(obs.flagged_issues) == 1 # not doubled
def test_flag_multiple_issues(self, env_bug):
for line in [6, 13, 33]:
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=line, filename="utils.py",
issue_type="bug", severity="medium", description=f"bug at {line}"
))
obs = env_bug.state
assert len(obs.flagged_issues) == 3
# ---------------------------------------------------------------------------
# step() — clear_flag tests
# ---------------------------------------------------------------------------
class TestClearFlag:
def test_clear_removes_flag(self, env_bug):
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
obs = env_bug.step(ReviewAction(
action_type="clear_flag", line_number=6, filename="utils.py",
description=""
))
assert len(obs.flagged_issues) == 0
def test_clear_nonexistent_flag_no_reward(self, env_bug):
obs = env_bug.step(ReviewAction(
action_type="clear_flag", line_number=999, filename="utils.py",
description=""
))
assert obs.reward == 0.0
def test_clear_false_positive_gives_positive_reward(self, env_bug):
# First flag a FP
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=100, filename="utils.py",
issue_type="bug", severity="low", description="wrong"
))
obs = env_bug.step(ReviewAction(
action_type="clear_flag", line_number=100, filename="utils.py",
description=""
))
assert obs.reward is not None and obs.reward > 0
# ---------------------------------------------------------------------------
# step() — request_hint tests
# ---------------------------------------------------------------------------
class TestRequestHint:
def test_hint_gives_small_negative_reward(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="request_hint"))
assert obs.reward is not None and obs.reward < 0
def test_hint_decrements_hints_remaining(self, env_bug):
before = env_bug.state.step_count # proxy check
obs1 = env_bug.step(ReviewAction(action_type="request_hint"))
obs2 = env_bug.step(ReviewAction(action_type="request_hint"))
assert obs2.hints_remaining < obs1.hints_remaining
def test_hint_content_in_feedback(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="request_hint"))
assert "hint" in obs.feedback.lower() or "loop" in obs.feedback.lower()
# ---------------------------------------------------------------------------
# step() — submit_review tests
# ---------------------------------------------------------------------------
class TestSubmitReview:
def test_submit_ends_episode(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="submit_review"))
assert obs.done is True
def test_submit_reward_is_float_in_range(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="submit_review"))
assert obs.reward is not None
assert 0.0 <= obs.reward <= 1.0
def test_submit_all_bugs_gives_high_score(self, env_bug):
# Flag all 3 correct bugs
for line, sev in [(6, "high"), (13, "medium"), (33, "low")]:
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=line, filename="utils.py",
issue_type="bug", severity=sev, description=f"bug at line {line}"
))
obs = env_bug.step(ReviewAction(action_type="submit_review"))
assert obs.reward is not None and obs.reward >= 0.7
def test_submit_no_flags_gives_zero(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="submit_review"))
assert obs.reward == 0.0
def test_submit_after_done_is_noop(self, env_bug):
env_bug.step(ReviewAction(action_type="submit_review"))
obs2 = env_bug.step(ReviewAction(action_type="submit_review"))
assert obs2.done is True # still done
# ---------------------------------------------------------------------------
# state property tests
# ---------------------------------------------------------------------------
class TestState:
def test_state_returns_review_state(self, env):
env.reset(task_id="bug-detection")
st = env.state
assert isinstance(st, ReviewState)
def test_state_has_episode_id(self, env):
env.reset(task_id="bug-detection")
assert env.state.episode_id is not None
def test_state_tracks_step_count(self, env_bug):
env_bug.step(ReviewAction(action_type="request_hint"))
assert env_bug.state.step_count == 1
def test_state_tracks_flagged_issues(self, env_bug):
env_bug.step(ReviewAction(
action_type="flag_issue", line_number=6, filename="utils.py",
issue_type="bug", severity="high", description="test"
))
assert len(env_bug.state.flagged_issues) == 1
# ---------------------------------------------------------------------------
# Unknown action type
# ---------------------------------------------------------------------------
class TestUnknownAction:
def test_unknown_action_type_no_crash(self, env_bug):
obs = env_bug.step(ReviewAction(action_type="invalid_action"))
assert obs is not None
assert obs.done is False or obs.done is True
# ---------------------------------------------------------------------------
# Max steps auto-end
# ---------------------------------------------------------------------------
class TestMaxSteps:
def test_episode_auto_ends_at_max_steps(self):
"""Verify episode ends when step budget is exhausted."""
env = CodeReviewEnvironment()
obs = env.reset(task_id="bug-detection")
max_steps = obs.max_steps
for _ in range(max_steps):
obs = env.step(ReviewAction(action_type="request_hint"))
if obs.done:
break
assert obs.done is True
|