Spaces:
Sleeping
Sleeping
File size: 16,811 Bytes
5bce7ac 5d330b7 5bce7ac 5d330b7 606e517 38457df 5d330b7 606e517 5d330b7 606e517 5d330b7 38457df 5d330b7 5bce7ac 703b668 5bce7ac 703b668 5bce7ac 860d7e4 38457df 5bce7ac 860d7e4 5bce7ac 38457df 860d7e4 5bce7ac 38457df 5bce7ac 1c6aad2 5bce7ac 1c6aad2 860d7e4 5bce7ac 5d330b7 5bce7ac 5d330b7 5bce7ac 703b668 5bce7ac 1c6aad2 5bce7ac 1c6aad2 860d7e4 5bce7ac 1c6aad2 38457df 1c6aad2 860d7e4 5bce7ac 1c6aad2 5bcbe7f 5e6d53a 1c6aad2 5e6d53a 5bce7ac 1c6aad2 5bce7ac 1c6aad2 5bce7ac 860d7e4 5bce7ac 860d7e4 5bce7ac 1c6aad2 5bce7ac 1c6aad2 5bce7ac 38457df 5bce7ac 38457df 5bce7ac 860d7e4 38457df 5bce7ac | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 | """Multi-turn rollout function for PM-Ops GRPO training.
History design (no duplicates):
Each turn record stores the obs that TRIGGERED the completion, not the result.
build_messages reconstructs:
[sys] [user:obs_0] [asst:comp_0] [user:obs_1] [asst:comp_1] ... [user:current_obs]
current_obs is never in history β it becomes the final user message.
Other design decisions:
- Action format B: chain-of-thought reasoning + ```json block
- Truncation: runbook-pinned sliding window (runbook pair always kept)
- Fallback cascade: read_runbook (early) β noop (mid) β finish (late)
- Three-pass JSON extraction: code block β raw JSON β regex
"""
import json
import re
from typing import Any
import torch
import torch.nn.functional as F
from training.dataset import parse_seed_from_prompt
from training.prompts import SYSTEM_PROMPT, format_observation
# ---------------------------------------------------------------------------
# HF model.generate() β replaces generate_rollout_completions (vLLM-only)
# ---------------------------------------------------------------------------
def _get_model_for_generation(trainer):
"""Unwrap the model safely regardless of accelerate/PEFT/DDP wrapping.
Priority:
1. accelerator.unwrap_model β handles DDP + PEFT + DeepSpeed
2. trainer.model.module β plain DDP wrapping
3. trainer.model β unwrapped (local or single-GPU)
"""
if hasattr(trainer, "accelerator"):
return trainer.accelerator.unwrap_model(trainer.model)
if hasattr(trainer.model, "module"):
return trainer.model.module
return trainer.model
def _generate_no_vllm(trainer, prompt_text: str, tokenizer,
max_new_tokens: int = 512, temperature: float = 1.1) -> dict:
"""Generate one completion using HF model.generate() without vLLM.
Returns the same dict shape as generate_rollout_completions so the rest
of rollout_once is unchanged:
prompt_ids: list[int]
completion_ids: list[int]
logprobs: list[float] (per-token log-prob under current policy)
text: str
"""
model = _get_model_for_generation(trainer)
# Device: prefer accelerator.device, fall back to first param device
if hasattr(trainer, "accelerator"):
device = trainer.accelerator.device
else:
device = next(model.parameters()).device
enc = tokenizer(prompt_text, return_tensors="pt").to(device)
prompt_len = enc["input_ids"].shape[1]
with torch.no_grad():
out = model.generate(
**enc,
max_new_tokens=max_new_tokens,
do_sample=True,
temperature=temperature,
top_p=0.95,
top_k=50,
pad_token_id=tokenizer.pad_token_id or tokenizer.eos_token_id,
output_scores=True,
return_dict_in_generate=True,
)
prompt_ids = enc["input_ids"][0].tolist()
completion_ids = out.sequences[0][prompt_len:].tolist()
# Per-token log-probs from output.scores (one score tensor per new token)
logprobs = [
F.log_softmax(score[0], dim=-1)[tok_id].item()
for score, tok_id in zip(out.scores, completion_ids)
]
text = tokenizer.decode(completion_ids, skip_special_tokens=True)
return {
"prompt_ids": prompt_ids,
"completion_ids": completion_ids,
"logprobs": logprobs,
"text": text,
}
MAX_STEPS = 40
# ~3000 tokens at 4 chars/token; leaves room for completion tokens
MAX_PROMPT_CHARS = 12_000
RUNBOOK_RESPONSE_MAX_CHARS = 3_000
HISTORY_PAIRS = 6 # max (user+asst) pairs kept from non-runbook history
# ---------------------------------------------------------------------------
# JSON extraction β three-pass, most-specific first
# ---------------------------------------------------------------------------
def extract_json_action(text: str) -> dict | None:
# Pass 1: last ```json ... ``` block
matches = re.findall(r"```json\s*(\{.*?\})\s*```", text, re.DOTALL)
if matches:
try:
return json.loads(matches[-1])
except json.JSONDecodeError:
pass
# Pass 2: entire output is JSON
stripped = text.strip()
if stripped.startswith("{"):
try:
return json.loads(stripped)
except json.JSONDecodeError:
pass
# Pass 3: any {...action_type...} pattern β allow one level of nested {} (e.g. "args": {})
matches = re.findall(
r'\{(?:[^{}]|\{[^{}]*\})*"action_type"\s*:\s*"[^"]*"(?:[^{}]|\{[^{}]*\})*\}',
text, re.DOTALL,
)
if matches:
try:
return json.loads(matches[-1])
except json.JSONDecodeError:
pass
return None
def step_aware_fallback(step: int, max_steps: int = MAX_STEPS) -> dict:
"""Safe fallback that degrades gracefully across the episode."""
if step <= 1:
return {"action_type": "meta.read_runbook", "args": {}}
elif step >= max_steps - 3:
return {"action_type": "meta.finish", "args": {}}
return {"action_type": "meta.noop", "args": {}}
# ---------------------------------------------------------------------------
# Context builder β runbook-pinned sliding window, no duplicate user turns
# ---------------------------------------------------------------------------
def _chars(messages: list[dict]) -> int:
return sum(len(m["content"]) for m in messages)
def build_messages(
turn_history: list[dict],
current_obs_text: str,
) -> list[dict]:
"""Build prompt messages with runbook-pinned sliding window truncation.
turn_history entries: {"obs_text": str, "completion": str, "is_runbook": bool}
obs_text = observation that triggered this completion (user side)
completion = model output for that step (assistant side)
Final conversation shape:
[sys] [user:obs_0][asst:comp_0] ... [user:obs_k][asst:comp_k] [user:current_obs]
No entry in turn_history represents current_obs β it's only the final user turn.
"""
# Task brief is always prepended to current_obs so it stays visible even
# when old context is truncated.
messages: list[dict] = [{"role": "system", "content": SYSTEM_PROMPT}]
# Separate the runbook exchange from the rest
runbook_turn: dict | None = None
general: list[dict] = []
for turn in turn_history:
if turn["is_runbook"] and runbook_turn is None:
runbook_turn = turn
else:
general.append(turn)
# Pin runbook exchange (truncate only if absurdly large)
if runbook_turn is not None:
rb_comp = runbook_turn["completion"][:RUNBOOK_RESPONSE_MAX_CHARS]
messages.append({"role": "user", "content": runbook_turn["obs_text"]})
messages.append({"role": "assistant", "content": rb_comp})
# Fill budget with most-recent general turns (newest first, then reverse)
fixed_chars = _chars(messages) + len(current_obs_text)
budget = MAX_PROMPT_CHARS - fixed_chars
window: list[dict] = []
for turn in reversed(general[-HISTORY_PAIRS:]):
pair_chars = len(turn["obs_text"]) + len(turn["completion"])
if budget - pair_chars < 0:
break
window.append(turn)
budget -= pair_chars
for turn in reversed(window):
messages.append({"role": "user", "content": turn["obs_text"]})
messages.append({"role": "assistant", "content": turn["completion"]})
# Current observation is always the final user turn (never stored in history)
messages.append({"role": "user", "content": current_obs_text})
return messages
# ---------------------------------------------------------------------------
# Observation normaliser β handles both object and dict forms
# ---------------------------------------------------------------------------
def _obs_to_dict(obs: Any) -> dict:
if isinstance(obs, dict):
return obs
fields = ("task_brief", "last_action_result", "step", "steps_remaining",
"reward", "done", "token_budget_remaining")
return {f: getattr(obs, f, None) for f in fields}
def _current_obs_text(obs_dict: dict, step: int, task_brief: str) -> str:
"""Format observation, prepending a task reminder so it survives truncation."""
reminder = f"**Task reminder:** {task_brief[:200]}\n\n"
return reminder + format_observation(obs_dict, step, obs_dict.get("last_action_result"))
# ---------------------------------------------------------------------------
# Single-episode rollout
# ---------------------------------------------------------------------------
def rollout_once(
trainer,
sync_env,
tokenizer,
dataset_prompt: str,
max_steps: int = 15,
gen_offset: int = 0,
) -> dict:
"""Play one full PM-Ops episode. Returns trajectory + reward signals.
gen_offset: added to seed so each GRPO generation explores a different env
episode even when receiving the same prompt (same base seed).
"""
seed = parse_seed_from_prompt(dataset_prompt)
if seed is not None:
result = sync_env.reset(seed=seed + gen_offset)
else:
result = sync_env.reset()
obs = result.observation if hasattr(result, "observation") else result
obs_dict = _obs_to_dict(obs)
task_brief: str = obs_dict.get("task_brief") or dataset_prompt
# Flat trajectory buffers (TRL expects flat lists across all steps)
prompt_ids: list = []
completion_ids: list = []
logprobs: list = []
# Turn history for context building
# Each entry: {"obs_text": str, "completion": str, "is_runbook": bool}
turn_history: list[dict] = []
# Rollout accumulators
valid_action_count = 0
final_score = 0.0
step = 0
done = False
# Runbook-compliance reward tracking
read_runbook_done = False
valid_labels: set[str] = set() # org label_taxonomy values
valid_priorities: set[str] = set() # org priority_levels
valid_teams: set[str] = set() # org team_map values
oncall_channels: set[str] = set() # org oncall_channels values
ticket_label: str | None = None # label used in create_ticket
ticket_priority: str | None = None # priority used in create_ticket
assigned_team: str | None = None # team from assign_ticket
posted_channels: list[str] = [] # every channel posted to
while not done and step < max_steps:
# obs_text for THIS step β stored in history BEFORE stepping
obs_text = _current_obs_text(obs_dict, step, task_brief)
messages = build_messages(turn_history, obs_text)
prompt_text = tokenizer.apply_chat_template(
messages,
add_generation_prompt=True,
tokenize=False,
enable_thinking=False,
)
rollout_out = _generate_no_vllm(trainer, prompt_text, tokenizer)
prompt_ids.extend(rollout_out["prompt_ids"])
completion_ids.extend(rollout_out["completion_ids"])
logprobs.extend(rollout_out["logprobs"])
completion_text = rollout_out["text"]
# Parse action; fall back gracefully on parse failure
parsed = extract_json_action(completion_text)
is_valid_json = parsed is not None
if not is_valid_json:
# Log the raw output on step 0 to diagnose format failures
if step == 0 and valid_action_count == 0:
snippet = repr(completion_text[:300])
print(f"[rollout] step=0 NO JSON β raw output: {snippet}")
parsed = step_aware_fallback(step, max_steps)
else:
valid_action_count += 1
action_type: str = parsed.get("action_type", "meta.noop")
args: dict = parsed.get("args", {})
if action_type == "meta.read_runbook" and is_valid_json:
read_runbook_done = True
if action_type == "ticketing.create_ticket" and is_valid_json and ticket_label is None:
ticket_label = args.get("label")
ticket_priority = args.get("priority")
if action_type == "ticketing.assign_ticket" and is_valid_json and assigned_team is None:
assigned_team = args.get("team")
if action_type == "chat.post_message" and is_valid_json:
ch = args.get("channel", "")
if ch:
posted_channels.append(ch)
# Store the (obs_text, completion) pair BEFORE stepping the env
# is_runbook marks this turn for pinning in future context windows
turn_history.append({
"obs_text": obs_text,
"completion": completion_text,
"is_runbook": (action_type == "meta.read_runbook" and is_valid_json),
})
# Step the environment β obs_dict now holds the NEXT state
result = sync_env.step({"action_type": action_type, "args": args})
new_obs = result.observation if hasattr(result, "observation") else result
obs_dict = _obs_to_dict(new_obs)
# Extract full org_config from runbook response (one step after the call)
last_result = obs_dict.get("last_action_result") or {}
if action_type == "meta.read_runbook" and last_result.get("ok"):
data = last_result.get("data") or {}
if isinstance(data, dict):
org = data.get("org_config") or {}
valid_labels = set(org.get("label_taxonomy", {}).values())
valid_priorities = set(org.get("priority_levels", []))
valid_teams = set(org.get("team_map", {}).values())
oncall_channels = set(org.get("oncall_channels", {}).values())
done = bool(getattr(result, "done", obs_dict.get("done", False)))
final_score = float(getattr(result, "reward", obs_dict.get("reward", 0.0)))
step += 1
from training.rewards import compute_rollout_reward
combined = compute_rollout_reward(
read_runbook_done = read_runbook_done,
valid_labels = valid_labels,
valid_priorities = valid_priorities,
valid_teams = valid_teams,
oncall_channels = oncall_channels,
ticket_label = ticket_label,
ticket_priority = ticket_priority,
assigned_team = assigned_team,
posted_channels = posted_channels,
env_score = final_score,
valid_json_count = valid_action_count,
)
print(
f"[rollout] steps={step} env={final_score:.3f} "
f"label={'β' if ticket_label and ticket_label in valid_labels else 'β' if ticket_label else '-'} "
f"priority={'β' if ticket_priority and ticket_priority in valid_priorities else 'β' if ticket_priority else '-'} "
f"team={'β' if assigned_team and assigned_team in valid_teams else 'β' if assigned_team else '-'} "
f"channel={'β' if any(ch in oncall_channels for ch in posted_channels) else 'β' if posted_channels else '-'} "
f"β reward={combined:.3f}"
)
return {
"prompt_ids": prompt_ids,
"completion_ids": completion_ids,
"logprobs": logprobs,
"reward": combined,
}
# ---------------------------------------------------------------------------
# GRPOTrainer-compatible rollout function (factory)
# ---------------------------------------------------------------------------
def make_rollout_func(sync_env, tokenizer, max_steps: int = 15):
"""Bind env + tokenizer; return the function GRPOTrainer calls each batch.
max_steps per task:
triage β 15 (solvable in 5, cap gives room for exploration)
incident_routing β 20
release_notes β 30
dep_update β 30
"""
def rollout_func(prompts: list[str], trainer=None) -> dict:
out: dict[str, list] = {
"prompt_ids": [],
"completion_ids": [],
"logprobs": [],
"reward": [],
}
# Track how many times each unique prompt has appeared so we can pass
# a gen_offset β ensures repeated prompts (num_generations > 1) hit
# different env seeds and produce different rollouts.
prompt_seen: dict[str, int] = {}
for prompt_text in prompts:
gen_offset = prompt_seen.get(prompt_text, 0)
prompt_seen[prompt_text] = gen_offset + 1
episode = rollout_once(
trainer=trainer,
sync_env=sync_env,
tokenizer=tokenizer,
dataset_prompt=prompt_text,
max_steps=max_steps,
gen_offset=gen_offset,
)
for k in out:
out[k].append(episode[k])
return out
return rollout_func
|