Update app.py

app.py

@@ -7,7 +7,7 @@ from transformers import AutoModelForCausalLM, AutoTokenizer
 # --- Constants ---
 DEFAULT_API_URL = "https://agents-course-unit4-scoring.hf.space"
 
-# --- Basic Agent Logic ---
+# --- BasicAgent Class ---
 class BasicAgent:
     def __init__(self):
         print("BasicAgent initialized.")
@@ -19,38 +19,33 @@ class BasicAgent:
         )
 
     def __call__(self, question: str) -> str:
-        input_text = f"{self.agent_prompt}\n\nQuestion: {question}"
-        inputs = self.tokenizer(input_text, return_tensors="pt")
-        outputs = self.llm.generate(**inputs)
-        decoded = self.tokenizer.decode(outputs[0], skip_special_tokens=True)
-        final = decoded.split("FINAL ANSWER:")[-1].strip()
+        prompt = f"{self.agent_prompt}\n\nQuestion: {question}"
+        inputs = self.tokenizer(prompt, return_tensors="pt")
+        outputs = self.llm.generate(**inputs, max_new_tokens=50)
+        result = self.tokenizer.decode(outputs[0], skip_special_tokens=True)
+        final = result.split("FINAL ANSWER:")[-1].strip()
         return f"FINAL ANSWER: {final}" if final else "FINAL ANSWER: UNKNOWN"
 
-# --- Submission Function ---
-def run_and_submit_all(username):
+# --- Run and Submit Function ---
+def run_and_submit_all(profile):
     space_id = os.getenv("SPACE_ID", "your-username/your-space")  # fallback
-    if not username.strip():
-        return "Username is required for submission.", None
+    if not profile or not getattr(profile, "username", None):
+        return "❌ Please log in to Hugging Face first.", None
 
+    username = profile.username
     agent = BasicAgent()
 
-    questions_url = f"{DEFAULT_API_URL}/questions"
-    submit_url = f"{DEFAULT_API_URL}/submit"
-    agent_code = f"https://huggingface.co/spaces/{space_id}/tree/main"
-
     try:
-        response = requests.get(questions_url, timeout=15)
-        response.raise_for_status()
-        questions_data = response.json()
+        questions = requests.get(f"{DEFAULT_API_URL}/questions", timeout=15).json()
     except Exception as e:
-        return f"Failed to fetch questions: {e}", None
+        return f"❌ Error fetching questions: {e}", None
 
     answers = []
     log = []
 
-    for item in questions_data:
-        task_id = item.get("task_id")
-        question = item.get("question")
+    for q in questions:
+        task_id = q.get("task_id")
+        question = q.get("question")
         if not task_id or not question:
             continue
         try:
@@ -61,40 +56,39 @@ def run_and_submit_all(username):
             log.append({"Task ID": task_id, "Question": question, "Submitted Answer": f"ERROR: {e}"})
 
     if not answers:
-        return "No answers submitted.", pd.DataFrame(log)
+        return "⚠️ No answers were generated.", pd.DataFrame(log)
 
-    payload = {
+    submission = {
         "username": username.strip(),
-        "agent_code": agent_code,
+        "agent_code": f"https://huggingface.co/spaces/{space_id}/tree/main",
         "answers": answers
     }
 
     try:
-        response = requests.post(submit_url, json=payload, timeout=30)
-        response.raise_for_status()
-        result = response.json()
-        status = (
-            f"Submission Successful!\n"
-            f"User: {result.get('username')}\n"
-            f"Score: {result.get('score', 'N/A')}% "
-            f"({result.get('correct_count', '?')}/{result.get('total_attempted', '?')} correct)\n"
-            f"Message: {result.get('message', '')}"
-        )
-        return status, pd.DataFrame(log)
+        r = requests.post(f"{DEFAULT_API_URL}/submit", json=submission, timeout=30)
+        r.raise_for_status()
+        res = r.json()
+        return (
+            f"✅ Submission Successful!\n"
+            f"User: {res.get('username')}\n"
+            f"Score: {res.get('score', 'N/A')}% "
+            f"({res.get('correct_count', '?')}/{res.get('total_attempted', '?')})\n"
+            f"Message: {res.get('message', '')}"
+        ), pd.DataFrame(log)
     except Exception as e:
-        return f"Submission failed: {e}", pd.DataFrame(log)
+        return f"❌ Submission failed: {e}", pd.DataFrame(log)
 
 # --- Gradio UI ---
 with gr.Blocks() as demo:
-    gr.Markdown("## 🚀 Basic Agent Evaluation & Submission")
-    gr.Markdown("Enter your Hugging Face username and press **Run and Submit** to evaluate your agent and submit your results.")
-    
-    username_input = gr.Textbox(label="Hugging Face Username", placeholder="e.g. your-hf-username")
+    gr.Markdown("# Basic Agent Evaluation")
+    gr.Markdown("Login with Hugging Face and click the button to run evaluation and submit your answers.")
+
+    profile = gr.LoginButton()
     run_button = gr.Button("Run and Submit")
-    status_output = gr.Textbox(label="Submission Status", lines=4, interactive=False)
-    results_table = gr.DataFrame(label="Submitted Answers")
+    status_output = gr.Textbox(label="Submission Status", lines=4)
+    results_table = gr.DataFrame(label="Answers Submitted")
 
-    run_button.click(fn=run_and_submit_all, inputs=[username_input], outputs=[status_output, results_table])
+    run_button.click(fn=run_and_submit_all, inputs=[profile], outputs=[status_output, results_table])
 
 if __name__ == "__main__":
-    demo.launch(debug=True)
+    demo.launch()