Update app.py

app.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 """
 Turbo Air Viewer - Equipment Specification Database Viewer
-Deployment-ready version with automatic database download
+Deployment-ready version with automatic database download and inline PDF display
 """
 
 import streamlit as st
@@ -16,6 +16,7 @@ import base64
 import io
 import os
 import requests
+from urllib.parse import quote
 
 # Streamlit page config MUST be first
 st.set_page_config(
@@ -492,165 +493,88 @@ def export_bookmarked_models():
     return df.to_csv(index=False)
 
 def display_pdf_preview(file_path, model_name):
-    """Optimized PDF display for Hugging Face Spaces with multiple fallbacks"""
-    import os
-    import requests
-    from urllib.parse import quote
+    """Display PDF inline in Streamlit app - optimized for HuggingFace Spaces"""
     
     # Extract filename from path
-    normalized_path = file_path.replace('\\', '/')
-    pdf_filename = normalized_path.split('/')[-1]
+    pdf_filename = file_path.replace('\\', '/').split('/')[-1]
     
-    # Create the Hugging Face URL
-    base_url = "https://huggingface.co/spaces/TurboAir/TurboAirViewer/resolve/main/pdfs/"
-    pdf_url = base_url + quote(pdf_filename)
-    
-    # Check if running locally or on Hugging Face
-    is_local = not os.environ.get('SPACE_ID')
+    # Create the HuggingFace Space URL for the PDF
+    pdf_url = f"https://huggingface.co/spaces/TurboAir/TurboAirViewer/resolve/main/pdfs/{pdf_filename}"
     
     # Control buttons row
     col1, col2, col3 = st.columns([2, 1, 1])
     
     with col1:
-        # Try to get file size for better UX
+        # Download button with actual file download
         try:
-            if is_local and os.path.exists(os.path.join('pdfs', pdf_filename)):
-                file_size = os.path.getsize(os.path.join('pdfs', pdf_filename)) / (1024 * 1024)
-                button_text = f"📥 Download PDF ({file_size:.1f} MB)"
+            response = requests.get(pdf_url, timeout=10)
+            if response.status_code == 200:
+                st.download_button(
+                    label="📥 Download PDF",
+                    data=response.content,
+                    file_name=pdf_filename,
+                    mime="application/pdf",
+                    use_container_width=True,
+                    type="primary"
+                )
             else:
-                # Quick HEAD request to get file size from URL
-                response = requests.head(pdf_url, timeout=5)
-                if 'content-length' in response.headers:
-                    file_size = int(response.headers['content-length']) / (1024 * 1024)
-                    button_text = f"📥 Download PDF ({file_size:.1f} MB)"
-                else:
-                    button_text = "📥 Download PDF"
+                # Fallback to link if download fails
+                st.markdown(f"[📥 Download PDF]({pdf_url})")
         except:
-            button_text = "📥 Download PDF"
-        
-        # Styled download button
-        st.markdown(f'''
-        <a href="{pdf_url}" download="{pdf_filename}" style="text-decoration: none;">
-            <div style="
-                background-color: #FF4B4B;
-                color: white;
-                padding: 0.5rem 1rem;
-                border-radius: 0.25rem;
-                text-align: center;
-                cursor: pointer;
-                font-weight: 500;
-                transition: background-color 0.2s;
-                display: block;
-            " onmouseover="this.style.backgroundColor='#E04040'" 
-               onmouseout="this.style.backgroundColor='#FF4B4B'">
-                {button_text}
-            </div>
-        </a>
-        ''', unsafe_allow_html=True)
+            # Fallback to simple link
+            st.markdown(f"[📥 Download PDF]({pdf_url})")
     
     with col2:
-        st.markdown('''
-        <div style="
-            background-color: #0E1117;
-            border: 1px solid #0F9D58;
-            color: #0F9D58;
-            padding: 0.5rem;
-            border-radius: 0.25rem;
-            text-align: center;
-            font-size: 0.9rem;
-        ">
-            ✅ PDF ready
-        </div>
-        ''', unsafe_allow_html=True)
+        st.success("✅ PDF ready")
     
     with col3:
-        if st.button("❌ Close Preview", use_container_width=True, type="secondary"):
+        if st.button("❌ Close Preview", use_container_width=True):
             st.session_state[f'show_pdf_{model_name}'] = False
             st.rerun()
     
     st.markdown("---")
     
-    # Method 1: Direct iframe (fastest, works if CORS allows)
-    pdf_display_html = f'''
-    <div style="width: 100%; height: 900px; position: relative;">
-        <iframe 
-            id="pdf-frame"
-            src="{pdf_url}" 
+    # Display PDF inline using embed tag (most reliable for HuggingFace Spaces)
+    st.markdown(f'''
+    <div style="width: 100%; height: 900px; margin-top: 10px;">
+        <embed 
+            src="{pdf_url}#toolbar=1&navpanes=0&scrollbar=1&view=FitH" 
             width="100%" 
-            height="100%" 
-            style="border: 1px solid #333; border-radius: 4px;"
-            loading="lazy">
-        </iframe>
+            height="900px" 
+            type="application/pdf"
+            style="border: 1px solid #444; border-radius: 8px;">
     </div>
+    ''', unsafe_allow_html=True)
     
-    <script>
-        // Fallback to PDF.js if direct viewing fails
-        setTimeout(function() {{
-            var iframe = document.getElementById('pdf-frame');
-            if (!iframe.contentWindow || !iframe.contentDocument) {{
-                iframe.src = 'https://mozilla.github.io/pdf.js/web/viewer.html?file=' + encodeURIComponent('{pdf_url}');
-            }}
-        }}, 3000);
-    </script>
-    '''
-    
-    # Try direct display first
-    st.markdown(pdf_display_html, unsafe_allow_html=True)
-    
-    # Provide alternative viewing options
+    # Fallback viewer options
     st.markdown("---")
+    st.markdown("📄 **Alternative viewing options:**")
     
     col1, col2, col3 = st.columns(3)
     
     with col1:
-        st.markdown(f"📄 [Open in new tab ↗]({pdf_url})")
+        st.markdown(f"[Open in new tab ↗]({pdf_url})")
     
     with col2:
         # PDF.js viewer as backup
         pdf_js_url = f"https://mozilla.github.io/pdf.js/web/viewer.html?file={quote(pdf_url, safe='')}"
-        st.markdown(f"🔍 [Open with PDF.js viewer ↗]({pdf_js_url})")
-    
-    with col3:
-        # Google Docs viewer as another backup
-        google_viewer_url = f"https://docs.google.com/viewer?url={quote(pdf_url, safe='')}&embedded=true"
-        st.markdown(f"📑 [Open with Google viewer ↗]({google_viewer_url})")
-    
-    # Source info (matching your UI)
-    if file_path:
-        st.caption(f"Source: {file_path}")
-
-
-# Alternative lightweight version if the above has issues
-def display_pdf_preview_simple(file_path, model_name):
-    """Simplified version with guaranteed compatibility"""
-    import urllib.parse
-    
-    # Extract filename
-    pdf_filename = os.path.basename(file_path.replace('\\', '/'))
-    
-    # Create URLs
-    pdf_url = f"https://huggingface.co/spaces/TurboAir/TurboAirViewer/resolve/main/pdfs/{urllib.parse.quote(pdf_filename)}"
-    viewer_url = f"https://mozilla.github.io/pdf.js/web/viewer.html?file={urllib.parse.quote(pdf_url, safe='')}"
-    
-    # Controls
-    col1, col2, col3 = st.columns([2, 1, 1])
-    
-    with col1:
-        st.markdown(f'<a href="{pdf_url}" target="_blank"><button style="width:100%;background:#FF4B4B;color:white;border:none;padding:8px;border-radius:4px;cursor:pointer">📥 Download PDF</button></a>', unsafe_allow_html=True)
-    
-    with col2:
-        st.success("✅ PDF ready")
+        st.markdown(f"[Open with PDF viewer ↗]({pdf_js_url})")
     
     with col3:
-        if st.button("❌ Close Preview", use_container_width=True):
-            st.session_state[f'show_pdf_{model_name}'] = False
-            st.rerun()
+        # Direct link
+        st.markdown(f"[Direct link]({pdf_url})")
     
-    # Display
-    st.markdown(f'<iframe src="{viewer_url}" width="100%" height="900" style="border:1px solid #333;border-radius:4px;"></iframe>', unsafe_allow_html=True)
-    
-    # Fallback
-    st.caption(f"Can't see the PDF? [Click here to open]({pdf_url})")
+    # If embed doesn't work, show PDF.js viewer as backup
+    st.markdown("---")
+    st.markdown("🔍 **Backup viewer** (if PDF doesn't display above):")
+    
+    # Use streamlit components for iframe
+    import streamlit.components.v1 as components
+    components.iframe(
+        src=f"https://mozilla.github.io/pdf.js/web/viewer.html?file={quote(pdf_url, safe='')}",
+        height=900,
+        scrolling=True
+    )
 
 def get_high_accuracy_models(limit=8):
     """Get models with highest extraction quality"""