Update Down/run_all.py

Down/run_all.py

@@ -12,13 +12,12 @@ from pathlib import Path
 
 ROOT = Path(__file__).resolve().parent
 
-# IMPORTANT:
-# In your repo structure (as shown by HF logs), these exist:
-# /app/Down/down
-# /app/Down/AntiDown
 DOWN_DIR = ROOT / "down"
 ANTIDOWN_DIR = ROOT / "AntiDown"
-OUT_GRAPHICS = ROOT / "graphics"
+
+# Shared outputs (so plot_dual can find both CSVs)
+RESULTS_DIR = ROOT / "results"
+GRAPHICS_DIR = ROOT / "graphics"
 
 
 def _run(cmd: list[str], cwd: Path, env: dict[str, str]) -> None:
@@ -28,8 +27,9 @@ def _run(cmd: list[str], cwd: Path, env: dict[str, str]) -> None:
 
 def _build_parser() -> argparse.ArgumentParser:
     p = argparse.ArgumentParser(description="Run DOWN + AntiDown pipelines and generate plots.")
-    p.add_argument("--episodes", type=int, default=400, help="Episodes per phase for DOWN tabular experiment.")
+    p.add_argument("--episodes", type=int, default=200, help="Episodes per phase (for both DOWN and AntiDown).")
     p.add_argument("--seed", type=int, default=2025, help="Seed for DOWN tabular experiment.")
+    p.add_argument("--skip_individual_plots", action="store_true", help="Only generate the dual overlay plot.")
     return p
 
 
@@ -37,29 +37,25 @@ def main() -> None:
     args = _build_parser().parse_args()
     py = sys.executable
 
-    # Sanity checks (fail fast with good errors)
     if not DOWN_DIR.exists():
-        raise RuntimeError(f"DOWN_DIR not found: {DOWN_DIR} (check repo folder names)")
+        raise RuntimeError(f"DOWN_DIR not found: {DOWN_DIR} (check folder names)")
     if not ANTIDOWN_DIR.exists():
-        raise RuntimeError(f"ANTIDOWN_DIR not found: {ANTIDOWN_DIR} (check repo folder names)")
+        raise RuntimeError(f"ANTIDOWN_DIR not found: {ANTIDOWN_DIR} (check folder names)")
+
+    RESULTS_DIR.mkdir(parents=True, exist_ok=True)
+    GRAPHICS_DIR.mkdir(parents=True, exist_ok=True)
 
-    OUT_GRAPHICS.mkdir(parents=True, exist_ok=True)
+    env = os.environ.copy()
+    env["TWOQUARKS_RESULTS_DIR"] = str(RESULTS_DIR)
+    env["TWOQUARKS_GRAPHICS_DIR"] = str(GRAPHICS_DIR)
 
-    # Base env for subprocesses
-    base_env = os.environ.copy()
+    # Canonical CSV names expected by plot_dual_down_antidown.py
+    down_csv = RESULTS_DIR / "down_paradox_tabular_results.csv"
+    antidown_csv = RESULTS_DIR / "antidown_corrupted_valley_tabular.csv"
 
     # ----------------------------
-    # DOWN
+    # DOWN (tabular)
     # ----------------------------
-    down_results_dir = DOWN_DIR / "results"
-    down_results_dir.mkdir(parents=True, exist_ok=True)
-
-    # Keep the filename your plot script already expects
-    down_csv = down_results_dir / "paradox_tabular_results.csv"
-
-    down_env = base_env.copy()
-    down_env["TWOQUARKS_RESULTS_DIR"] = str(down_results_dir)
-
     _run(
         [
             py,
@@ -72,69 +68,73 @@ def main() -> None:
             str(down_csv),
         ],
         cwd=DOWN_DIR,
-        env=down_env,
-    )
-
-    _run(
-        [
-            py,
-            str(DOWN_DIR / "exp" / "plot_paradox_results.py"),
-            "--csv",
-            str(down_csv),
-            "--out",
-            str(OUT_GRAPHICS),
-            "--prefix",
-            "down",
-        ],
-        cwd=DOWN_DIR,
-        env=down_env,
+        env=env,
     )
 
     # ----------------------------
-    # AntiDown
+    # AntiDown (tabular)
     # ----------------------------
-    antidown_results_dir = ANTIDOWN_DIR / "results"
-    antidown_results_dir.mkdir(parents=True, exist_ok=True)
-
-    # Your current plot script expects this exact filename
-    antidown_csv = antidown_results_dir / "paradox_tabular_results.csv"
-
-    antidown_env = base_env.copy()
-    antidown_env["TWOQUARKS_RESULTS_DIR"] = str(antidown_results_dir)
-
-    # NOTE:
-    # I’m not passing --episodes here because I don’t know if your AntiDown runner parses it.
-    # If it DOES, you can safely add: "--episodes", str(int(args.episodes))
+    # Requires the updated AntiDown runner below (adds --episodes support)
     _run(
         [
             py,
             str(ANTIDOWN_DIR / "exp" / "run_corrupted_valley_tabular.py"),
+            "--episodes",
+            str(int(args.episodes)),
         ],
         cwd=ANTIDOWN_DIR,
-        env=antidown_env,
+        env=env,
     )
 
-    _run(
-        [
-            py,
-            str(ANTIDOWN_DIR / "exp" / "plot_corrupted_valley_results.py"),
-            "--csv",
-            str(antidown_csv),
-            "--out",
-            str(OUT_GRAPHICS),
-            "--prefix",
-            "AntiDown",
-        ],
-        cwd=ANTIDOWN_DIR,
-        env=antidown_env,
-    )
+    # ----------------------------
+    # Individual plots (optional)
+    # ----------------------------
+    if not args.skip_individual_plots:
+        # If these plot scripts exist in your repo, keep them.
+        # They can read from the shared RESULTS_DIR, via explicit --csv.
+        plot_down = DOWN_DIR / "exp" / "plot_paradox_results.py"
+        if plot_down.exists():
+            _run(
+                [
+                    py,
+                    str(plot_down),
+                    "--csv",
+                    str(down_csv),
+                    "--out",
+                    str(GRAPHICS_DIR),
+                    "--prefix",
+                    "Down",
+                ],
+                cwd=DOWN_DIR,
+                env=env,
+            )
+
+        plot_antidown = ANTIDOWN_DIR / "exp" / "plot_corrupted_valley_results.py"
+        if plot_antidown.exists():
+            _run(
+                [
+                    py,
+                    str(plot_antidown),
+                    "--csv",
+                    str(antidown_csv),
+                    "--out",
+                    str(GRAPHICS_DIR),
+                    "--prefix",
+                    "AntiDown",
+                ],
+                cwd=ANTIDOWN_DIR,
+                env=env,
+            )
 
     # ----------------------------
-    # Dual plot
+    # Dual overlay plot (canonical)
     # ----------------------------
-    _run([py, str(ROOT / "plot_dual_down_antidown.py")], cwd=ROOT, env=base_env)
+    _run([py, str(ROOT / "plot_dual_down_antidown.py")], cwd=ROOT, env=env)
 
-    print(f"[ok] Finished. All plots saved: {OUT_GRAPHICS}")
+    print(f"[ok] Finished.")
+    print(f"     CSV: {down_csv}")
+    print(f"     CSV: {antidown_csv}")
+    print(f"     Plots: {GRAPHICS_DIR}")
 
 
 if __name__ == "__main__":