Update Down/run_all.py

Down/run_all.py

@@ -1,4 +1,5 @@
 from __future__ import annotations
+
 import matplotlib
 matplotlib.use("Agg")
 
@@ -8,38 +9,132 @@ import subprocess
 import sys
 from pathlib import Path
 
+
 ROOT = Path(__file__).resolve().parent
+
+# IMPORTANT:
+# In your repo structure (as shown by HF logs), these exist:
+# /app/Down/down
+# /app/Down/AntiDown
 DOWN_DIR = ROOT / "down"
 ANTIDOWN_DIR = ROOT / "AntiDown"
 OUT_GRAPHICS = ROOT / "graphics"
 
-def _run(cmd, cwd: Path):
+
+def _run(cmd: list[str], cwd: Path, env: dict[str, str]) -> None:
     print(f"[run] ({cwd}) $ {' '.join(cmd)}")
-    subprocess.run(cmd, cwd=str(cwd), check=True)
+    subprocess.run(cmd, cwd=str(cwd), env=env, check=True)
+
 
+def _build_parser() -> argparse.ArgumentParser:
+    p = argparse.ArgumentParser(description="Run DOWN + AntiDown pipelines and generate plots.")
+    p.add_argument("--episodes", type=int, default=400, help="Episodes per phase for DOWN tabular experiment.")
+    p.add_argument("--seed", type=int, default=2025, help="Seed for DOWN tabular experiment.")
+    return p
 
-def main():
+
+def main() -> None:
+    args = _build_parser().parse_args()
     py = sys.executable
+
+    # Sanity checks (fail fast with good errors)
+    if not DOWN_DIR.exists():
+        raise RuntimeError(f"DOWN_DIR not found: {DOWN_DIR} (check repo folder names)")
+    if not ANTIDOWN_DIR.exists():
+        raise RuntimeError(f"ANTIDOWN_DIR not found: {ANTIDOWN_DIR} (check repo folder names)")
+
     OUT_GRAPHICS.mkdir(parents=True, exist_ok=True)
 
+    # Base env for subprocesses
+    base_env = os.environ.copy()
+
+    # ----------------------------
     # DOWN
-    _run([py, str(DOWN_DIR / "exp" / "run_paradox_tabular.py")], cwd=DOWN_DIR)
-    _run([py, str(DOWN_DIR / "exp" / "plot_paradox_results.py"),
-          "--csv", str(DOWN_DIR / "results" / "paradox_tabular_results.csv"),
-          "--out", str(OUT_GRAPHICS),
-          "--prefix", "down"], cwd=DOWN_DIR)
+    # ----------------------------
+    down_results_dir = DOWN_DIR / "results"
+    down_results_dir.mkdir(parents=True, exist_ok=True)
 
+    # Keep the filename your plot script already expects
+    down_csv = down_results_dir / "paradox_tabular_results.csv"
+
+    down_env = base_env.copy()
+    down_env["TWOQUARKS_RESULTS_DIR"] = str(down_results_dir)
+
+    _run(
+        [
+            py,
+            str(DOWN_DIR / "exp" / "run_paradox_tabular.py"),
+            "--episodes",
+            str(int(args.episodes)),
+            "--seed",
+            str(int(args.seed)),
+            "--out",
+            str(down_csv),
+        ],
+        cwd=DOWN_DIR,
+        env=down_env,
+    )
+
+    _run(
+        [
+            py,
+            str(DOWN_DIR / "exp" / "plot_paradox_results.py"),
+            "--csv",
+            str(down_csv),
+            "--out",
+            str(OUT_GRAPHICS),
+            "--prefix",
+            "down",
+        ],
+        cwd=DOWN_DIR,
+        env=down_env,
+    )
+
+    # ----------------------------
     # AntiDown
-    _run([py, str(ANTIDOWN_DIR / "exp" / "run_corrupted_valley_tabular.py")],  cwd=ANTIDOWN_DIR)
-    _run([py, str(ANTIDOWN_DIR / "exp" / "plot_corrupted_valley_results.py"),
-          "--csv", str(ANTIDOWN_DIR / "results" / "paradox_tabular_results.csv"),
-          "--out", str(OUT_GRAPHICS),
-          "--prefix", "AntiDown"], cwd=ANTIDOWN_DIR)    
+    # ----------------------------
+    antidown_results_dir = ANTIDOWN_DIR / "results"
+    antidown_results_dir.mkdir(parents=True, exist_ok=True)
 
-    _run([py, str(ROOT / "plot_dual_down_antidown.py")], cwd=ROOT)
+    # Your current plot script expects this exact filename
+    antidown_csv = antidown_results_dir / "paradox_tabular_results.csv"
 
-    print(f"[ok] Finished. All plots saved: {OUT_GRAPHICS}")
+    antidown_env = base_env.copy()
+    antidown_env["TWOQUARKS_RESULTS_DIR"] = str(antidown_results_dir)
 
+    # NOTE:
+    # I’m not passing --episodes here because I don’t know if your AntiDown runner parses it.
+    # If it DOES, you can safely add: "--episodes", str(int(args.episodes))
+    _run(
+        [
+            py,
+            str(ANTIDOWN_DIR / "exp" / "run_corrupted_valley_tabular.py"),
+        ],
+        cwd=ANTIDOWN_DIR,
+        env=antidown_env,
+    )
+
+    _run(
+        [
+            py,
+            str(ANTIDOWN_DIR / "exp" / "plot_corrupted_valley_results.py"),
+            "--csv",
+            str(antidown_csv),
+            "--out",
+            str(OUT_GRAPHICS),
+            "--prefix",
+            "AntiDown",
+        ],
+        cwd=ANTIDOWN_DIR,
+        env=antidown_env,
+    )
+
+    # ----------------------------
+    # Dual plot
+    # ----------------------------
+    _run([py, str(ROOT / "plot_dual_down_antidown.py")], cwd=ROOT, env=base_env)
+
+    print(f"[ok] Finished. All plots saved: {OUT_GRAPHICS}")
 
 
 if __name__ == "__main__":