fix: file_size_is_valid, add link to remove limits

app/helpers.py

@@ -166,14 +166,16 @@ def st_local_audio(pathname, key):
     )
 
 
-def file_size_is_valid(response):
-    file_size = response.headers.get("Content-Length")
-    file_size = int(file_size)
-    max_size_mb = int(os.environ["STREAMLIT_SERVER_MAX_UPLOAD_SIZE"])
-    if max_size_mb and file_size > max_size_mb * 1024 * 1024:
-        st.error(
-            f"The file is too large to download. Maximum size allowed: {max_size_mb}MB. Duplicate this space to remove any limit."
-        )
+def file_size_is_valid(file_size):
+    if file_size is not None:
+        file_size = int(file_size)
+        max_size_mb = int(os.environ["STREAMLIT_SERVER_MAX_UPLOAD_SIZE"])
+        if max_size_mb and file_size > max_size_mb * 1024 * 1024:
+            st.error(
+                f"The file is too large to download. Maximum size allowed: {max_size_mb}MB.\nDuplicate this space to [remove any limit](https://github.com/fabiogra/moseca#are-there-any-limitations)."
+            )
+            return False
+    return True
 
 
 def _get_files_to_not_delete():

app/pages/Karaoke.py

@@ -147,31 +147,27 @@ def body():
                     sess.executed = False
                 if sess.random_song is None:
                     if not sess.executed:
-                        cols_spinners = st.columns([1, 2, 1])
-                        with cols_spinners[1]:
-                            with st.spinner(
-                                "Separating vocals from music, it could take a few minutes... Don't close this page!"
-                            ):
-                                sess.filename = download_audio_from_youtube(sess.url, in_path)
-                                if sess.filename is None:
-                                    st.stop()
-                                sess.url = None
-                                filename = sess.filename
-                                song = load_audio_segment(
-                                    in_path / filename, filename.split(".")[-1]
-                                )
-                                song.export(in_path / filename, format=filename.split(".")[-1])
-                                model, device = load_model(pretrained_model="baseline.pth")
-                                separate(
-                                    input=in_path / filename,
-                                    model=model,
-                                    device=device,
-                                    output_dir=out_path,
-                                    only_no_vocals=True,
-                                )
-                                selected_value = None
-                                sess.last_dir = ".".join(sess.filename.split(".")[:-1])
-                                sess.executed = True
+                        with st.spinner(
+                            "Separating vocals from music, it could take a few minutes... Don't close this page!"
+                        ):
+                            sess.filename = download_audio_from_youtube(sess.url, in_path)
+                            if sess.filename is None:
+                                st.stop()
+                            sess.url = None
+                            filename = sess.filename
+                            song = load_audio_segment(in_path / filename, filename.split(".")[-1])
+                            song.export(in_path / filename, format=filename.split(".")[-1])
+                            model, device = load_model(pretrained_model="baseline.pth")
+                            separate(
+                                input=in_path / filename,
+                                model=model,
+                                device=device,
+                                output_dir=out_path,
+                                only_no_vocals=True,
+                            )
+                            selected_value = None
+                            sess.last_dir = ".".join(sess.filename.split(".")[:-1])
+                            sess.executed = True
                 else:
                     sess.executed = True
 

app/pages/Separate.py

@@ -161,14 +161,25 @@ def body():
                 with st.spinner("Downloading audio..."):
                     filename = url.split("/")[-1]
                     response = requests.get(url, stream=True)
-                    if response.status_code == 200 and file_size_is_valid(response):
+                    if response.status_code == 200 and file_size_is_valid(
+                        response.headers.get("Content-Length")
+                    ):
+                        file_size = 0
                         with open(in_path / filename, "wb") as audio_file:
                             for chunk in response.iter_content(chunk_size=1024):
                                 if chunk:
                                     audio_file.write(chunk)
+                                    file_size += len(chunk)
+                                    if not file_size_is_valid(file_size):
+                                        audio_file.close()
+                                        os.remove(in_path / filename)
+                                        filename = None
+                                        return
                         st_local_audio(in_path / filename, key="input_from_url")
                     else:
-                        st.error("Failed to download audio file.")
+                        st.error(
+                            "Failed to download audio file. Try to download it manually and upload it."
+                        )
                         filename = None
 
         elif option == "Examples":
@@ -215,14 +226,14 @@ def body():
                     max_value=n_secs,
                     step=1,
                     value=0,
-                    help=f"Maximum duration is {max_duration} seconds for this separation mode. Duplicate this space to remove any limit.",
+                    help=f"Maximum duration is {max_duration} seconds for this separation mode.\nDuplicate this space to [remove any limit](https://github.com/fabiogra/moseca#are-there-any-limitations).",
                     format="%d",
                 )
                 st.session_state.start_time = start_time
                 end_time = min(start_time + max_duration, n_secs)
                 song = song[start_time * 1000 : end_time * 1000]
                 st.info(
-                    f"Audio source will be processed from {start_time} to {end_time} seconds. Duplicate this space to remove any limit.",
+                    f"Audio source will be processed from {start_time} to {end_time} seconds.\nDuplicate this space to [remove any limit](https://github.com/fabiogra/moseca#are-there-any-limitations).",
                     icon="⏱",
                 )
         else: