Update app.py

app.py

@@ -1,8 +1,11 @@
-# app_phi_sleek.py
+# app.py
 #
-# Sleek UI + Voice-to-Text for the HIPAA-aware app.
-# IMPORTANT: All analysis/assessment logic is preserved exactly.
-# Changes are limited to the UI layout, CSS, and a client-side STT helper.
+# Universal AI Data Analyst with:
+# - Unchanged analysis & assessment logic
+# - Fixed Gradio event wiring (uses gr.State for history)
+# - Triple-quoted progress strings (no unterminated literals)
+# - Sleek full-width UI and Voice-to-Text (browser Web Speech API)
+# - Optional HIPAA flags (fallback defaults if not present in settings.py)
 
 from __future__ import annotations
 
@@ -24,22 +27,25 @@ from langchain_cohere import ChatCohere  # noqa: F401
 from settings import (
     GENERAL_CONVERSATION_PROMPT,
     COHERE_MODEL_PRIMARY,
-    COHERE_TIMEOUT_S,  # noqa: F401
-    USE_OPEN_FALLBACKS,  # noqa: F401
-    # HIPAA flags
-    PHI_MODE,
-    PERSIST_HISTORY,
-    HISTORY_TTL_DAYS,
-    REDACT_BEFORE_LLM,
-    ALLOW_EXTERNAL_PHI,
+    COHERE_TIMEOUT_S,   # noqa: F401
+    USE_OPEN_FALLBACKS  # noqa: F401
 )
+# Try to import optional HIPAA flags; fall back to safe defaults if not defined.
+try:
+    from settings import PHI_MODE, PERSIST_HISTORY, HISTORY_TTL_DAYS, REDACT_BEFORE_LLM, ALLOW_EXTERNAL_PHI
+except Exception:
+    PHI_MODE = False
+    PERSIST_HISTORY = True
+    HISTORY_TTL_DAYS = 365
+    REDACT_BEFORE_LLM = False
+    ALLOW_EXTERNAL_PHI = True
 
 from audit_log import log_event
 from privacy import safety_filter, refusal_reply
 from llm_router import cohere_chat, _co_client, cohere_embed
 
 
-# ---------------------- helpers (unchanged logic) ----------------------
+# ---------------------- Helpers (analysis logic unchanged) ----------------------
 
 def load_markdown_text(filepath: str) -> str:
     try:
@@ -52,10 +58,11 @@ def load_markdown_text(filepath: str) -> str:
 def _sanitize_text(s: str) -> str:
     if not isinstance(s, str):
         return s
+    # Remove control characters (except newline and tab)
     return re2.sub(r"[\p{C}--[\n\t]]+", "", s)
 
 
-# Very conservative PHI redaction (unchanged idea)
+# Conservative PHI redaction patterns (only applied if PHI_MODE & REDACT_BEFORE_LLM are enabled)
 PHI_PATTERNS = [
     (re.compile(r"\b\d{3}-\d{2}-\d{4}\b"), "[REDACTED_SSN]"),
     (re.compile(r"\b\d{9}\b"), "[REDACTED_MRN]"),
@@ -75,11 +82,13 @@ def redact_phi(text: str) -> str:
     return t
 
 def safe_log(event_name: str, meta: dict | None = None):
+    # Avoid logging raw PHI or payloads
     try:
         meta = (meta or {}).copy()
         meta.pop("raw", None)
         log_event(event_name, None, meta)
     except Exception:
+        # Never raise from logging
         pass
 
 
@@ -183,11 +192,12 @@ def ping_cohere() -> str:
 
 def handle(user_msg: str, files: list, yield_update) -> str:
     try:
+        # Safety filter on incoming message
         safe_in, blocked_in, reason_in = safety_filter(user_msg, mode="input")
         if blocked_in:
             return refusal_reply(reason_in)
 
-        # Redact prompt if PHI_MODE and external PHI not allowed
+        # Optional PHI redaction for prompts sent to an external LLM
         redacted_in = safe_in
         if PHI_MODE and REDACT_BEFORE_LLM:
             redacted_in = redact_phi(safe_in)
@@ -195,6 +205,7 @@ def handle(user_msg: str, files: list, yield_update) -> str:
         file_paths: List[str] = [getattr(f, "name", None) or f for f in (files or [])]
 
         if file_paths:
+            # CSV analysis path (unchanged)
             dataframes, schema_parts = [], []
             for i, p in enumerate(file_paths):
                 if p.endswith(".csv"):
@@ -211,6 +222,8 @@ def handle(user_msg: str, files: list, yield_update) -> str:
                 return "Please upload at least one CSV file."
 
             schema_context = "\n".join(schema_parts)
+
+            # If external PHI is not allowed, use redacted prompt; otherwise use original
             prompt_for_code = redacted_in if (PHI_MODE and not ALLOW_EXTERNAL_PHI) else safe_in
 
             yield_update("""```
@@ -241,6 +254,7 @@ def handle(user_msg: str, files: list, yield_update) -> str:
             final_report = _generate_final_report(writer_input, raw_data_output)
             return _sanitize_text(final_report)
         else:
+            # Pure chat path
             chat_input = redacted_in if (PHI_MODE and not ALLOW_EXTERNAL_PHI) else safe_in
             prompt = f"{GENERAL_CONVERSATION_PROMPT}\n\nUser: {chat_input}\nAssistant:"
             return _sanitize_text(cohere_chat(prompt) or "How can I help further?")
@@ -254,7 +268,8 @@ def handle(user_msg: str, files: list, yield_update) -> str:
 PRIVACY_POLICY_TEXT = load_markdown_text("privacy_policy.md")
 TERMS_OF_SERVICE_TEXT = load_markdown_text("terms_of_service.md")
 
-# ---------------------- Sleek UI Layer only ----------------------
+
+# ---------------------- Sleek UI assets (CSS/JS only) ----------------------
 
 SLEEK_CSS = """
 /* Full-bleed, modern look */
@@ -347,7 +362,13 @@ function rs_toggle_stt(elemId){
 </script>
 """
 
+
+# ---------------------- Sleek UI (with fixed State wiring) ----------------------
+
 with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
+    # Persistent in-memory history component (fixes list/_id error)
+    assessment_history = gr.State([])
+
     # Header
     with gr.Row(elem_classes=["header"]):
         gr.Markdown("<h1>Universal AI Data Analyst</h1>")
@@ -355,7 +376,7 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
                "PHI Mode ON" if PHI_MODE else "PHI Mode OFF"
         gr.Markdown(f"<span class='badge'>{pill}</span>")
 
-    # Main
+    # Main layout
     with gr.Row(elem_classes=["main"]):
         # Left panel
         with gr.Column(elem_classes=["left"]):
@@ -387,12 +408,10 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
             gr.Markdown("<div class='hr'></div>")
             if PHI_MODE:
                 gr.Markdown(
-                    "⚠️ **PHI Mode:** History persistence is disabled by default. Avoid unnecessary identifiers.",
+                    "⚠️ **PHI Mode:** History persistence is disabled by default. Avoid unnecessary identifiers."
                 )
 
             with gr.Accordion("Privacy & Terms", open=False):
-                PRIVACY_POLICY_TEXT = load_markdown_text("privacy_policy.md")
-                TERMS_OF_SERVICE_TEXT = load_markdown_text("terms_of_service.md")
                 gr.Markdown(PRIVACY_POLICY_TEXT)
                 gr.Markdown("<div class='hr'></div>")
                 gr.Markdown(TERMS_OF_SERVICE_TEXT)
@@ -402,20 +421,16 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
             with gr.Tabs(elem_classes=["tabs"]):
                 with gr.TabItem("Current Assessment", id=0, elem_classes=["tabitem"]):
                     with gr.Column(elem_id="chatbot_container"):
-                        chat_history_output = gr.Chatbot(
-                            label="Analysis Output", type="messages"
-                        )
+                        chat_history_output = gr.Chatbot(label="Analysis Output", type="messages")
                 with gr.TabItem("Assessment History", id=1, elem_classes=["tabitem"]):
                     gr.Markdown("### Review Past Assessments")
-                    history_dropdown = gr.Dropdown(
-                        label="Select an assessment to review", choices=[]
-                    )
+                    history_dropdown = gr.Dropdown(label="Select an assessment to review", choices=[])
                     history_display = gr.Markdown(label="Selected Assessment Details")
 
-    # Inject STT helper
+    # Inject voice-to-text helper
     gr.HTML(VOICE_STT_HTML)
 
-    # --------- Logic (unchanged analysis flow) ----------
+    # --------- Event logic (unchanged analysis flow) ----------
 
     def run_analysis_wrapper(prompt, files, chat_history_list, history_state_list):
         if not prompt:
@@ -423,11 +438,14 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
             yield chat_history_list, history_state_list, gr.update()
             return
 
+        # Append user's message
         chat_with_user_msg = _append_msg(chat_history_list, "user", prompt)
 
+        # Optional progress callback (not streaming in this UI)
         def dummy_update(message: str):
             pass
 
+        # Thinking bubble
         thinking_message = _append_msg(
             chat_with_user_msg,
             "assistant",
@@ -437,17 +455,21 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
         )
         yield thinking_message, history_state_list, gr.update()
 
+        # Run analysis/chat
         ai_response_text = handle(prompt, files, dummy_update)
 
+        # Append final assistant response
         final_chat = _append_msg(chat_with_user_msg, "assistant", ai_response_text)
         timestamp = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
 
+        # Capture filenames (if any)
         file_names: List[str] = []
         if files:
             file_names = [
                 os.path.basename(f.name if hasattr(f, "name") else f) for f in files
             ]
 
+        # Build history record
         new_entry = {
             "id": timestamp,
             "prompt": prompt,
@@ -456,15 +478,13 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
             "chat_history": final_chat,
         }
 
-        # Respect PHI history rules exactly as before
+        # Respect PHI/history flags
         if PERSIST_HISTORY and (not PHI_MODE or (PHI_MODE and HISTORY_TTL_DAYS > 0)):
             updated_history: List[Dict[str, Any]] = (history_state_list or []) + [new_entry]
         else:
             updated_history = history_state_list or []
 
-        history_labels = [
-            f"{item['id']} - {item['prompt'][:40]}..." for item in updated_history
-        ]
+        history_labels = [f"{item['id']} - {item['prompt'][:40]}..." for item in updated_history]
 
         yield final_chat, updated_history, gr.update(choices=history_labels)
 
@@ -477,8 +497,7 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
             selected_id = selection
 
         selected_assessment = next(
-            (item for item in history_state_list if item.get("id") == selected_id),
-            None,
+            (item for item in history_state_list if item.get("id") == selected_id), None
         )
         if not selected_assessment:
             return "Could not find the selected assessment."
@@ -508,30 +527,24 @@ with gr.Blocks(theme=gr.themes.Soft(), css=SLEEK_CSS, fill_width=True) as demo:
 {chat_md}
 """
 
-    # Wire events
+    # Wire events (using proper gr.State component for history)
     send_btn.click(
         run_analysis_wrapper,
-        inputs=[prompt_input, files_input, chat_history_output, []],  # local state
-        outputs=[chat_history_output, [], history_dropdown],
+        inputs=[prompt_input, files_input, chat_history_output, assessment_history],
+        outputs=[chat_history_output, assessment_history, history_dropdown],
     )
-    # Use a hidden State for history to avoid changing logic; or substitute your existing State variable.
-    # If you want to persist in-memory between runs, replace [] with a gr.State([]) you manage outside.
-
     history_dropdown.change(
-        view_history, inputs=[history_dropdown, []], outputs=[history_display]
+        view_history,
+        inputs=[history_dropdown, assessment_history],
+        outputs=[history_display],
     )
-
     clear_btn.click(
         lambda: (None, None, []),
         outputs=[prompt_input, files_input, chat_history_output],
     )
-
     ping_btn.click(ping_cohere, outputs=[ping_out])
+    voice_btn.click(None, [], [], js="rs_toggle_stt('prompt_box')")
 
-    # Voice button (client-side only)
-    voice_btn.click(
-        None, [], [], js="rs_toggle_stt('prompt_box')"
-    )
 
 if __name__ == "__main__":
     if not os.getenv("COHERE_API_KEY"):