fix: Address CodeRabbit review feedback

Changes based on CodeRabbit PR review:

1. docs/bugs/P0_HUGGINGFACE_TOOL_CALLING_BROKEN.md:
- Add 'text' language to fenced code block (MD040)
- Wrap bare GitHub URL in markdown link (MD034)
- Update workaround section to reflect implementation status

2. src/orchestrators/advanced.py:
- Add plain string handling to _extract_text() for WorkflowOutputEvent.data
- Filter repr-style noise from string payloads

3. src/clients/huggingface.py:
- JSON-encode structured tool results instead of str()
- Track call_id -> name mapping for tool result messages
- Add 'name' field to tool messages (required by some APIs)

docs/bugs/P0_HUGGINGFACE_TOOL_CALLING_BROKEN.md

@@ -52,7 +52,7 @@ Updated `_convert_messages()` in `src/clients/huggingface.py:71-121` to:
 
 ### Symptom
 `MagenticAgentMessageEvent.message.text` contains:
-```
+```text
 '<agent_framework._types.ChatMessage object at 0x10c394210>'
 ```
 
@@ -89,19 +89,19 @@ async def _invoke_agent(self, ctx, ...) -> ChatMessage:
 3. Unrelated orchestration issue
 
 ### Upstream Issue Filed
-**GitHub Issue**: https://github.com/microsoft/agent-framework/issues/2562
+**GitHub Issue**: [microsoft/agent-framework#2562](https://github.com/microsoft/agent-framework/issues/2562)
 
 **Suggested fixes in issue**:
 1. **Minimal**: `text = last.text or ""`
 2. **Better UX**: Format tool calls for display
 3. **Best**: Add `__str__` to `ChatMessage` class
 
-### Workaround (Not Implemented)
-We COULD modify `_extract_text()` in `advanced.py` to extract tool call names from `.contents` when text is empty/repr:
+### Workaround (Implemented in `advanced.py`)
+We modified `_extract_text()` in `advanced.py` to extract tool call names from `.contents` when text is empty or looks like a repr:
 
 ```python
 def _extract_text(self, message: Any) -> str:
-    # ... existing logic ...
+    # ... existing logic with repr filtering ...
 
     # Workaround: Extract tool call info when text is repr/empty
     if hasattr(message, "contents") and message.contents:
@@ -116,7 +116,7 @@ def _extract_text(self, message: Any) -> str:
     return ""
 ```
 
-**Decision**: Not implementing until we confirm whether Bug #2 affects research completion or just display.
+**Decision**: Implemented locally to fix display and logging while we wait for upstream fix.
 
 ---
 
@@ -141,8 +141,8 @@ def _extract_text(self, message: Any) -> str:
   - Added `@use_function_invocation`, `@use_observability`, `@use_chat_middleware` decorators
   - Added `__function_invoking_chat_client__ = True` marker
 
-### No Changes Needed
-- `src/orchestrators/advanced.py` - `_extract_text()` already filters repr strings
+### Also Fixed
+- `src/orchestrators/advanced.py` - `_extract_text()` now filters repr strings AND extracts tool call names
 
 ---
 

src/clients/huggingface.py

@@ -71,6 +71,11 @@ class HuggingFaceChatClient(BaseChatClient):  # type: ignore[misc]
     def _convert_messages(self, messages: MutableSequence[ChatMessage]) -> list[dict[str, Any]]:
         """Convert framework messages to HuggingFace format."""
         hf_messages: list[dict[str, Any]] = []
+
+        # Track call_id -> tool_name mapping for tool result messages
+        # Assistant messages with tool_calls come before tool result messages
+        call_id_to_name: dict[str, str] = {}
+
         for msg in messages:
             # msg.role can be string or enum - extract .value for enums
             if hasattr(msg.role, "value"):
@@ -81,12 +86,15 @@ class HuggingFaceChatClient(BaseChatClient):  # type: ignore[misc]
             content_str = msg.text or ""
             tool_calls = []
             tool_call_id = None
+            tool_name = None
 
             # Process contents for tool calls and results
             if msg.contents:
                 for item in msg.contents:
                     if isinstance(item, FunctionCallContent):
                         # This is an assistant message invoking a tool
+                        # Track call_id -> name for later tool result messages
+                        call_id_to_name[item.call_id] = item.name
                         tool_calls.append(
                             {
                                 "id": item.call_id,
@@ -105,8 +113,16 @@ class HuggingFaceChatClient(BaseChatClient):  # type: ignore[misc]
                         # This is a tool result message
                         role_str = "tool"
                         tool_call_id = item.call_id
-                        # For tool results, the content is the result string
-                        content_str = str(item.result) if item.result is not None else ""
+                        # Look up tool name from prior FunctionCallContent
+                        tool_name = call_id_to_name.get(item.call_id)
+                        # For tool results, JSON-encode structured data
+                        # HuggingFace/OpenAI expects string content
+                        if item.result is None:
+                            content_str = ""
+                        elif isinstance(item.result, str):
+                            content_str = item.result
+                        else:
+                            content_str = json.dumps(item.result)
 
             message_dict: dict[str, Any] = {"role": role_str, "content": content_str}
 
@@ -115,6 +131,9 @@ class HuggingFaceChatClient(BaseChatClient):  # type: ignore[misc]
 
             if tool_call_id:
                 message_dict["tool_call_id"] = tool_call_id
+                # Add name field if we tracked it (required by some APIs)
+                if tool_name:
+                    message_dict["name"] = tool_name
 
             hf_messages.append(message_dict)
 

src/orchestrators/advanced.py

@@ -339,10 +339,18 @@ The final output should be a structured research report."""
 
         Handles ChatMessage objects from both OpenAI and HuggingFace clients.
         ChatMessage has: .text (str), .contents (list of content objects)
+        Also handles plain string messages (e.g., WorkflowOutputEvent.data).
         """
         if not message:
             return ""
 
+        # Priority 0: Handle plain string messages (e.g., WorkflowOutputEvent.data)
+        if isinstance(message, str):
+            # Filter out obvious repr-style noise
+            if not (message.startswith("<") and "object at" in message):
+                return message
+            return ""
+
         # Priority 1: .text (standard ChatMessage text content)
         if hasattr(message, "text") and message.text:
             text = message.text