VibecoderMcSwaggins commited on
Commit
a1b9bd7
·
1 Parent(s): 982c1e5

style: Address CodeRabbit nitpicks

Browse files

- Add language specifier to markdown code blocks (MD040)
- Remove duplicate horizontal rule separator
- Use structured logging in fallback synthesis error handler
- Use _smart_truncate for completion messages (avoids unnecessary ellipsis)

docs/bugs/P2_ROUND_COUNTER_SEMANTIC_MISMATCH.md CHANGED
@@ -13,7 +13,7 @@
13
 
14
  Progress display shows impossible values like "Round 11/5":
15
 
16
- ```
17
  ⏱️ **PROGRESS**: Round 11/5 (~0s remaining)
18
  ```
19
 
@@ -57,7 +57,7 @@ In a multi-agent workflow with 4 agents (searcher, hypothesizer, judge, reporter
57
  ## Evidence From Logs
58
 
59
  The session showed this progression:
60
- ```
61
  Round 1/5 - First agent completed
62
  Round 2/5 - Second agent completed
63
  Round 3/5 - Third agent completed
@@ -170,8 +170,6 @@ def test_progress_display_never_exceeds_max_rounds():
170
 
171
  ---
172
 
173
- ---
174
-
175
  ## Additional Issues Found During Analysis
176
 
177
  ### Issue 2: Dead Code - Unused `_get_progress_message` Method
 
13
 
14
  Progress display shows impossible values like "Round 11/5":
15
 
16
+ ```text
17
  ⏱️ **PROGRESS**: Round 11/5 (~0s remaining)
18
  ```
19
 
 
57
  ## Evidence From Logs
58
 
59
  The session showed this progression:
60
+ ```text
61
  Round 1/5 - First agent completed
62
  Round 2/5 - Second agent completed
63
  Round 3/5 - Third agent completed
 
170
 
171
  ---
172
 
 
 
173
  ## Additional Issues Found During Analysis
174
 
175
  ### Issue 2: Dead Code - Unused `_get_progress_message` Method
src/orchestrators/advanced.py CHANGED
@@ -264,7 +264,7 @@ The final output should be a structured research report."""
264
  iteration=iteration,
265
  )
266
  except Exception as synth_error:
267
- logger.error(f"{reason} synthesis failed", error=str(synth_error))
268
  yield AgentEvent(
269
  type="complete",
270
  message=f"Research completed. Synthesis failed: {synth_error}",
@@ -456,7 +456,7 @@ The final output should be a structured research report."""
456
 
457
  completion_event = AgentEvent(
458
  type=event_type,
459
- message=f"{semantic_name}: {text_content[:200]}...",
460
  iteration=iteration,
461
  )
462
 
 
264
  iteration=iteration,
265
  )
266
  except Exception as synth_error:
267
+ logger.error("Fallback synthesis failed", reason=reason, error=str(synth_error))
268
  yield AgentEvent(
269
  type="complete",
270
  message=f"Research completed. Synthesis failed: {synth_error}",
 
456
 
457
  completion_event = AgentEvent(
458
  type=event_type,
459
+ message=f"{semantic_name}: {self._smart_truncate(text_content)}",
460
  iteration=iteration,
461
  )
462