Commit
·
a380725
1
Parent(s):
ec0a5c3
docs: clarify project relationships and add reciprocity note
Browse files- DeepCritical-1 is independent hackathon entry, not fork of DeepCritical/DeepCritical
- Josephrp provided starter template; team built implementation
- Added note about professional reciprocity in contribution standards
docs/decisions/2025-11-27-pr55-evaluation.md
CHANGED
|
@@ -74,6 +74,8 @@ These contributions:
|
|
| 74 |
- Did not dump 17k lines of untested code
|
| 75 |
- Did not minimize quality issues when identified
|
| 76 |
|
|
|
|
|
|
|
| 77 |
## Decision
|
| 78 |
|
| 79 |
The PR was not merged for the following reasons:
|
|
@@ -86,12 +88,14 @@ The PR was not merged for the following reasons:
|
|
| 86 |
|
| 87 |
## Context
|
| 88 |
|
| 89 |
-
This project (DeepCritical-1) is
|
|
|
|
|
|
|
| 90 |
|
| 91 |
-
All contributors have direct push access to
|
| 92 |
|
| 93 |
## Links
|
| 94 |
|
| 95 |
- [PR #55](https://github.com/The-Obstacle-Is-The-Way/DeepCritical-HFSpace/pull/55)
|
| 96 |
- [CodeRabbit Review](https://github.com/The-Obstacle-Is-The-Way/DeepCritical-HFSpace/pull/55#issuecomment-3587631560)
|
| 97 |
-
- [
|
|
|
|
| 74 |
- Did not dump 17k lines of untested code
|
| 75 |
- Did not minimize quality issues when identified
|
| 76 |
|
| 77 |
+
**The contrast**: These PRs to @Josephrp's project were meticulously tested out of professional respect. The same standard was not reciprocated when contributing to this hackathon project.
|
| 78 |
+
|
| 79 |
## Decision
|
| 80 |
|
| 81 |
The PR was not merged for the following reasons:
|
|
|
|
| 88 |
|
| 89 |
## Context
|
| 90 |
|
| 91 |
+
This project (DeepCritical-1) is an independent HuggingFace Spaces hackathon entry. @Josephrp provided a starter template; the actual implementation was built by the team.
|
| 92 |
+
|
| 93 |
+
[DeepCritical/DeepCritical](https://github.com/DeepCritical/DeepCritical) is @Josephrp's separate main project (not related to this hackathon entry despite the similar name). The PRs listed above were contributions to that separate project.
|
| 94 |
|
| 95 |
+
All contributors have direct push access to this HuggingFace Space. Contributors are encouraged to push directly to production when confident in their code, rather than submitting PRs with untested code for others to review and take responsibility for.
|
| 96 |
|
| 97 |
## Links
|
| 98 |
|
| 99 |
- [PR #55](https://github.com/The-Obstacle-Is-The-Way/DeepCritical-HFSpace/pull/55)
|
| 100 |
- [CodeRabbit Review](https://github.com/The-Obstacle-Is-The-Way/DeepCritical-HFSpace/pull/55#issuecomment-3587631560)
|
| 101 |
+
- [@Josephrp's Separate Project](https://github.com/DeepCritical/DeepCritical)
|