fix(tests): Address CodeRabbit review feedback

- Add

@pytest
.mark.unit markers to all test functions
- Implement test_reporter_ran_tracking_still_works test
- Replace `if False: yield` with cleaner _empty_async_generator helper
- Add _create_task_prompt mock to test_internal_messages_are_filtered
- Use ORCH_MSG_KIND_* constants instead of string literals in _process_event

src/orchestrators/advanced.py

@@ -539,7 +539,7 @@ The final output should be a structured research report."""
             message = getattr(event, "message", "")
 
             # FILTERING: Skip internal framework bookkeeping
-            if kind in ("task_ledger", "instruction"):
+            if kind in (ORCH_MSG_KIND_TASK_LEDGER, ORCH_MSG_KIND_INSTRUCTION):
                 return None
 
             # TRANSFORMATION: Handle user_task BEFORE text extraction

tests/unit/test_orchestrator_noise.py

@@ -12,6 +12,13 @@ from agent_framework import (
 from src.orchestrators.advanced import REPORTER_AGENT_ID, AdvancedOrchestrator
 
 
+async def _empty_async_generator(query):
+    """Empty async generator for mocking _init_workflow_events."""
+    return
+    yield  # Makes this an async generator that yields nothing
+
+
+@pytest.mark.unit
 @pytest.mark.asyncio
 async def test_executor_completed_event_is_silenced():
     """Verify ExecutorCompletedEvent produces NO UI events."""
@@ -31,11 +38,7 @@ async def test_executor_completed_event_is_silenced():
     orchestrator._build_workflow = MagicMock(return_value=mock_workflow)
 
     # Mock init services to avoid side effects
-    async def mock_init_events(query):
-        if False:
-            yield
-
-    orchestrator._init_workflow_events = mock_init_events
+    orchestrator._init_workflow_events = _empty_async_generator
     orchestrator._init_embedding_service = MagicMock(return_value=None)
     orchestrator._create_task_prompt = MagicMock(return_value="task")
 
@@ -53,6 +56,7 @@ async def test_executor_completed_event_is_silenced():
             assert "ManagerAgent" not in event.message
 
 
+@pytest.mark.unit
 @pytest.mark.asyncio
 async def test_internal_messages_are_filtered():
     """Verify internal task_ledger/instruction messages are filtered."""
@@ -89,12 +93,9 @@ async def test_internal_messages_are_filtered():
     mock_workflow.run_stream = event_stream
     orchestrator._build_workflow = MagicMock(return_value=mock_workflow)
 
-    async def mock_init_events(query):
-        if False:
-            yield
-
-    orchestrator._init_workflow_events = mock_init_events
+    orchestrator._init_workflow_events = _empty_async_generator
     orchestrator._init_embedding_service = MagicMock(return_value=None)
+    orchestrator._create_task_prompt = MagicMock(return_value="task")
 
     events = []
     async for event in orchestrator.run("query"):
@@ -111,3 +112,36 @@ async def test_internal_messages_are_filtered():
     assert not any('{"some": "json"}' in msg for msg in all_messages)
     # The instruction text should be filtered
     assert not any("Internal instruction to agent" in msg for msg in all_messages)
+
+
+@pytest.mark.unit
+@pytest.mark.asyncio
+async def test_reporter_ran_tracking_still_works():
+    """Verify internal state.reporter_ran is set correctly even though UI events are silenced."""
+    orchestrator = AdvancedOrchestrator()
+    mock_workflow = MagicMock()
+
+    async def event_stream(task):
+        # Reporter completion event - should set internal flag
+        yield ExecutorCompletedEvent(executor_id=REPORTER_AGENT_ID, data=None)
+
+    mock_workflow.run_stream = event_stream
+    orchestrator._build_workflow = MagicMock(return_value=mock_workflow)
+
+    orchestrator._init_workflow_events = _empty_async_generator
+    orchestrator._init_embedding_service = MagicMock(return_value=None)
+    orchestrator._create_task_prompt = MagicMock(return_value="task")
+
+    # Run the workflow
+    events = []
+    async for event in orchestrator.run("query"):
+        events.append(event)
+
+    # The key assertion: No "synthesis" fallback should have been triggered
+    # If reporter_ran was NOT set, we'd see a fallback synthesis event
+    fallback_events = [
+        e for e in events if e.type == "synthesis" or "fallback" in e.message.lower()
+    ]
+    assert len(fallback_events) == 0, (
+        f"Fallback synthesis triggered - reporter_ran tracking broken: {fallback_events}"
+    )