Commit
·
cea8a14
1
Parent(s):
98d21b9
fix(tests): Address CodeRabbit feedback
Browse files- Update SPEC status from PLANNED to IMPLEMENTED (PR #125)
- Move `import os` to module level per best practices
- SPEC_ARCHITECTURAL_DEBT.md +3 -3
- tests/e2e/test_smoke.py +2 -2
SPEC_ARCHITECTURAL_DEBT.md
CHANGED
|
@@ -230,9 +230,9 @@ class WorkflowState:
|
|
| 230 |
|
| 231 |
**CRITICAL**: Each phase MUST pass smoke tests before merge. Unit tests alone are insufficient.
|
| 232 |
|
| 233 |
-
> **Implementation Status**:
|
| 234 |
-
>
|
| 235 |
-
>
|
| 236 |
|
| 237 |
### Smoke Test Infrastructure
|
| 238 |
|
|
|
|
| 230 |
|
| 231 |
**CRITICAL**: Each phase MUST pass smoke tests before merge. Unit tests alone are insufficient.
|
| 232 |
|
| 233 |
+
> **Implementation Status**: IMPLEMENTED (PR #125)
|
| 234 |
+
> Smoke tests are now live in `tests/e2e/test_smoke.py` with Makefile targets.
|
| 235 |
+
> Run `make smoke-free` or `make smoke-paid` before any refactoring PR.
|
| 236 |
|
| 237 |
### Smoke Test Infrastructure
|
| 238 |
|
tests/e2e/test_smoke.py
CHANGED
|
@@ -9,6 +9,8 @@ Usage:
|
|
| 9 |
make smoke-paid # Test Paid Tier (OpenAI BYOK)
|
| 10 |
"""
|
| 11 |
|
|
|
|
|
|
|
| 12 |
import pytest
|
| 13 |
|
| 14 |
from src.orchestrators.advanced import AdvancedOrchestrator
|
|
@@ -47,8 +49,6 @@ async def test_free_tier_synthesis():
|
|
| 47 |
@pytest.mark.timeout(300) # 5 minute timeout for Paid Tier
|
| 48 |
async def test_paid_tier_synthesis():
|
| 49 |
"""Verify Paid Tier (BYOK) produces synthesis."""
|
| 50 |
-
import os
|
| 51 |
-
|
| 52 |
api_key = os.environ.get("OPENAI_API_KEY")
|
| 53 |
if not api_key:
|
| 54 |
pytest.skip("OPENAI_API_KEY not set")
|
|
|
|
| 9 |
make smoke-paid # Test Paid Tier (OpenAI BYOK)
|
| 10 |
"""
|
| 11 |
|
| 12 |
+
import os
|
| 13 |
+
|
| 14 |
import pytest
|
| 15 |
|
| 16 |
from src.orchestrators.advanced import AdvancedOrchestrator
|
|
|
|
| 49 |
@pytest.mark.timeout(300) # 5 minute timeout for Paid Tier
|
| 50 |
async def test_paid_tier_synthesis():
|
| 51 |
"""Verify Paid Tier (BYOK) produces synthesis."""
|
|
|
|
|
|
|
| 52 |
api_key = os.environ.get("OPENAI_API_KEY")
|
| 53 |
if not api_key:
|
| 54 |
pytest.skip("OPENAI_API_KEY not set")
|