fix: preserve None for masked fields in financials chart series instead of coercing to 0

Chart builders (_chart_margins, _chart_cash, _chart_balance,
_chart_capital_allocation) used (_safe(...) or 0) for fields masked
by the CHECK_REQUIRED field-level disclosure, rendering a fabricated
0% margin / $0B FCF instead of a gap in the series. Also reword
_masked_quality_message from the now-inaccurate "not VERIFIED" to
"no citable SEC lineage", since CHECK_REQUIRED rows are displayed
(partially) rather than hidden entirely.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

dashboard/financials.py

@@ -156,7 +156,7 @@ def _masked_quality_message(rows: list[dict]) -> str:
         details.append(f"{period}: {status}{warning_text}")
     suffix = f"; +{len(rows) - 5} more" if len(rows) > 5 else ""
     return (
-        f"{len(rows)} period(s) masked because period lineage is not VERIFIED: "
+        f"{len(rows)} period(s) masked because no citable SEC lineage is available: "
         + "; ".join(details)
         + suffix
     )
@@ -392,8 +392,10 @@ def _chart_revenue(labels: list, data: list) -> None:
 def _chart_margins(labels: list, data: list) -> None:
     import plotly.graph_objects as go
 
-    gross = [(_safe(r.get("gross_margin")) or 0) * 100 for r in data]
-    op = [(_safe(r.get("operating_margin")) or 0) * 100 for r in data]
+    gross_values = [_safe(r.get("gross_margin")) for r in data]
+    op_values = [_safe(r.get("operating_margin")) for r in data]
+    gross = [v * 100 if v is not None else None for v in gross_values]
+    op = [v * 100 if v is not None else None for v in op_values]
     eps = [_safe(r.get("eps")) for r in data]
 
     fig = go.Figure()
@@ -427,10 +429,14 @@ def _chart_margins(labels: list, data: list) -> None:
 def _chart_cash(labels: list, data: list) -> None:
     import plotly.graph_objects as go
 
-    fcf = [(_safe(r.get("free_cash_flow")) or 0) / 1e9 for r in data]
-    capex = [(_safe(r.get("capex")) or 0) / 1e9 for r in data]
-    buybacks = [(_safe(r.get("buybacks")) or 0) / 1e9 for r in data]
-    dividends = [(_safe(r.get("dividends_paid")) or 0) / 1e9 for r in data]
+    fcf_values = [_safe(r.get("free_cash_flow")) for r in data]
+    capex_values = [_safe(r.get("capex")) for r in data]
+    buyback_values = [_safe(r.get("buybacks")) for r in data]
+    dividend_values = [_safe(r.get("dividends_paid")) for r in data]
+    fcf = [v / 1e9 if v is not None else None for v in fcf_values]
+    capex = [v / 1e9 if v is not None else None for v in capex_values]
+    buybacks = [v / 1e9 if v is not None else None for v in buyback_values]
+    dividends = [v / 1e9 if v is not None else None for v in dividend_values]
 
     fig = go.Figure()
     fig.add_trace(go.Bar(name="Free Cash Flow", x=labels, y=fcf,
@@ -462,8 +468,10 @@ def _chart_cash(labels: list, data: list) -> None:
 def _chart_balance(labels: list, data: list) -> None:
     import plotly.graph_objects as go
 
-    debt = [(_safe(r.get("total_debt")) or 0) / 1e9 for r in data]
-    equity = [(_safe(r.get("stockholders_equity")) or 0) / 1e9 for r in data]
+    debt_values = [_safe(r.get("total_debt")) for r in data]
+    equity_values = [_safe(r.get("stockholders_equity")) for r in data]
+    debt = [v / 1e9 if v is not None else None for v in debt_values]
+    equity = [v / 1e9 if v is not None else None for v in equity_values]
     de = []
     for r in data:
         d = _safe(r.get("total_debt"))
@@ -507,9 +515,12 @@ def _chart_capital_allocation(labels: list, data: list) -> None:
     import plotly.graph_objects as go
     from plotly.subplots import make_subplots
 
-    capex = [(_safe(r.get("capex")) or 0) / 1e9 for r in data]
-    dividends = [(_safe(r.get("dividends_paid")) or 0) / 1e9 for r in data]
-    buybacks = [(_safe(r.get("buybacks")) or 0) / 1e9 for r in data]
+    capex_values = [_safe(r.get("capex")) for r in data]
+    dividend_values = [_safe(r.get("dividends_paid")) for r in data]
+    buyback_values = [_safe(r.get("buybacks")) for r in data]
+    capex = [v / 1e9 if v is not None else None for v in capex_values]
+    dividends = [v / 1e9 if v is not None else None for v in dividend_values]
+    buybacks = [v / 1e9 if v is not None else None for v in buyback_values]
     fcf = [_safe(r.get("free_cash_flow")) for r in data]
     fcf_b = [v / 1e9 if v is not None else None for v in fcf]
 

tests/test_financials.py

@@ -7,6 +7,8 @@ Each company has a different fiscal year end month:
   NVDA  — January   (fy_end_month=1)
 """
 from __future__ import annotations
+from unittest.mock import patch
+
 import pytest
 
 
@@ -225,3 +227,49 @@ class TestFinancialDataQuality:
         assert "FY2024: LEGACY_UNVERIFIED" in message
         assert "Q22025" not in message
         assert "revenue:duration_mismatch" not in message
+        assert "no citable SEC lineage" in message
+        assert "not VERIFIED" not in message
+
+    @patch("dashboard.financials.st.plotly_chart")
+    def test_chart_margins_preserves_masked_gross_margin_as_none(
+        self, mock_plotly_chart
+    ):
+        from dashboard.financials import _chart_margins, _display_row
+
+        row = self._row(
+            "Q22025", "2025-08-01", "10-Q", "CHECK_REQUIRED",
+            ["gross_margin:fallback_non_sec"],
+        )
+        displayed = _display_row(row)
+
+        assert displayed is not None
+        assert displayed["gross_margin"] is None
+        assert displayed["revenue"] == 10_000_000_000.0
+        assert displayed["eps"] == 2.5
+
+        _chart_margins(["Q2 FY25"], [displayed])
+
+        margins_figure = mock_plotly_chart.call_args_list[0].args[0]
+        assert list(margins_figure.data[0].y) == [None]
+
+    @patch("dashboard.financials.st.plotly_chart")
+    def test_chart_cash_preserves_masked_free_cash_flow_as_none(
+        self, mock_plotly_chart
+    ):
+        from dashboard.financials import _chart_cash, _display_row
+
+        row = self._row(
+            "Q22025", "2025-08-01", "10-Q", "CHECK_REQUIRED",
+            ["free_cash_flow:fallback_non_sec"],
+        )
+        displayed = _display_row(row)
+
+        assert displayed is not None
+        assert displayed["free_cash_flow"] is None
+        assert displayed["revenue"] == 10_000_000_000.0
+        assert displayed["eps"] == 2.5
+
+        _chart_cash(["Q2 FY25"], [displayed])
+
+        cash_figure = mock_plotly_chart.call_args_list[0].args[0]
+        assert list(cash_figure.data[0].y) == [None]