Upload bayesian_core.py

bayesian_core.py

@@ -350,137 +350,54 @@ class BayesianHierarchicalAnalyzer:
         }
     
     def get_model_graph(self):
-        """
-        生成模型 DAG 圖（返回 graphviz 物件）
-        使用正確的 WinBUGS/BUGS 標準風格
-        
-        Returns:
-            graphviz.Digraph 物件
-        """
+        """生成模型 DAG 圖（返回 graphviz 物件）"""
         if self.model is None:
             raise ValueError("請先執行分析")
         
         try:
-            import graphviz
+            import re
+            
+            # 使用 PyMC 原本的圖
+            gv = pm.model_to_graphviz(self.model)
             
-            # 獲取欄位名稱
+            # 獲取欄位資訊 (動態)
             control_prefix = getattr(self, 'col_control_win', 'control').replace('_win', '').replace('_battles', '').replace('_total', '')
             treatment_prefix = getattr(self, 'col_treatment_win', 'treatment').replace('_win', '').replace('_battles', '').replace('_total', '')
             control_win = getattr(self, 'col_control_win', 'control_win')
             treatment_win = getattr(self, 'col_treatment_win', 'treatment_win')
-            control_total = getattr(self, 'col_control_total', 'control_total')
-            treatment_total = getattr(self, 'col_treatment_total', 'treatment_total')
-            
-            # 標籤定義 (純英文,使用上標)
-            labels = {
-                # 隨機變數 (圓形)
-                'd': 'd',
-                'tau': 'tau',
-                'sigma': 'sigma',
-                'mu': 'mu_i',
-                'delta': 'delta_i',
-                'delta_new': 'delta_new',
-                f'p_{control_prefix}': f'p_{control_prefix}_i',
-                f'p_{treatment_prefix}': f'p_{treatment_prefix}_i',
-                'or_speed': 'OR',
-                
-                # 觀測資料 (矩形)
-                f'{control_win}_obs': f'r_{control_prefix}_i',
-                f'{treatment_win}_obs': f'r_{treatment_prefix}_i',
-            }
-            
-            # 使用 PyMC 生成基本圖
-            gv_original = pm.model_to_graphviz(self.model)
-            
-            # 創建新圖 - WinBUGS 標準風格
-            dot = graphviz.Digraph(comment='Bayesian Hierarchical Model')
-            dot.attr(rankdir='TB')
-            dot.attr('node', fontname='Times-Italic', fontsize='16')
-            dot.attr('edge', color='black', penwidth='1.2', arrowsize='0.7')
-            
-            # WinBUGS 標準: 所有變數都是圓形 (除了觀測資料)
-            circular_nodes = [
-                'd', 'tau', 'sigma', 'mu', 'delta', 'delta_new',
-                f'p_{control_prefix}', f'p_{treatment_prefix}', 'or_speed'
-            ]
             
-            # 矩形: 只有觀測資料
-            observed_nodes = [f'{control_win}_obs', f'{treatment_win}_obs']
+            # 替換標籤 (只改文字,不改圖結構)
+            source = gv.source
             
-            # 解析並重建
-            lines = gv_original.source.split('\n')
-            
-            for line in lines:
-                line = line.strip()
-                if not line or line.startswith('digraph') or line == '}':
-                    continue
-                
-                # 節點定義
-                if '[label=' in line:
-                    node = line.split('[')[0].strip()
-                    label = labels.get(node, node)
-                    
-                    if node in circular_nodes:
-                        # WinBUGS: 所有變數 = 圓形,白底,黑框
-                        dot.node(node, label, 
-                                shape='circle',
-                                style='filled',
-                                fillcolor='white',
-                                color='black',
-                                penwidth='2.0',
-                                width='1.0',
-                                height='1.0',
-                                fixedsize='true')
-                    
-                    elif node in observed_nodes:
-                        # WinBUGS: 觀測資料 = 矩形,白底,黑框
-                        dot.node(node, label,
-                                shape='box',
-                                style='filled',
-                                fillcolor='white',
-                                color='black',
-                                penwidth='2.0',
-                                width='1.2',
-                                height='0.8')
-                
-                # 邊定義
-                elif '->' in line:
-                    parts = line.replace(';', '').split('->')
-                    if len(parts) == 2:
-                        src = parts[0].strip()
-                        dst = parts[1].strip().split('[')[0].strip()
-                        dot.edge(src, dst)
-            
-            # 手動添加固定常數節點 (雙層矩形)
-            dot.node(f'{control_total}_const', f'n_{control_prefix}_i',
-                    shape='box',
-                    style='filled',
-                    fillcolor='white',
-                    color='black',
-                    penwidth='4.0',
-                    width='1.2',
-                    height='0.8',
-                    peripheries='2')  # 雙層框
+            # 替換模型變數的標籤
+            replacements = {
+                # PyMC 變數名 -> 顯示名稱
+                f'label="{f"p_{control_prefix}"}"': f'label="p_{control_prefix}[i]\\n({control_prefix.capitalize()} Win Rate)"',
+                f'label="{f"p_{treatment_prefix}"}"': f'label="p_{treatment_prefix}[i]\\n({treatment_prefix.capitalize()} Win Rate)"',
+                f'label="{control_win}_obs"': f'label="{control_win}_obs[i]\\n({control_prefix.capitalize()} Wins)"',
+                f'label="{treatment_win}_obs"': f'label="{treatment_win}_obs[i]\\n({treatment_prefix.capitalize()} Wins)"',
+                'label="d"': f'label="d\\n(Overall Effect\\n{treatment_prefix} vs {control_prefix})"',
+                'label="tau"': 'label="tau\\n(Precision)"',
+                'label="sigma"': 'label="sigma\\n(Between-Pair SD)"',
+                'label="mu"': 'label="mu[i]\\n(Baseline)"',
+                'label="delta"': f'label="delta[i]\\n({treatment_prefix.capitalize()} Advantage)"',
+                'label="delta_new"': 'label="delta_new\\n(New Pair)"',
+                'label="or_speed"': 'label="OR\\n(Odds Ratio)"',
+            }
             
-            dot.node(f'{treatment_total}_const', f'n_{treatment_prefix}_i',
-                    shape='box',
-                    style='filled',
-                    fillcolor='white',
-                    color='black',
-                    penwidth='4.0',
-                    width='1.2',
-                    height='0.8',
-                    peripheries='2')  # 雙層框
+            # 執行替換
+            for old, new in replacements.items():
+                source = source.replace(old, new)
             
-            # 添加常數到觀測值的連接
-            dot.edge(f'{control_total}_const', f'{control_win}_obs')
-            dot.edge(f'{treatment_total}_const', f'{treatment_win}_obs')
+            # 更新 graphviz 物件
+            gv.source = source
             
-            return dot
+            return gv
             
         except Exception as e:
             raise Exception(f"無法生成 DAG 圖: {str(e)}")
-
+    
+    @classmethod
     def get_session_results(cls, session_id):
         """獲取特定 session 的結果"""
         return cls._session_results.get(session_id)