Update app.py

app.py

@@ -1,23 +1,13 @@
-#!/usr/bin/env python
-"""HF Space for the *Marin‑8B‑Instruct* research preview
------------------------------------------------------
-A lightweight Gradio interface that
-  • streams chat completions from the `marin-community/marin-8b-instruct` model
-  • lets testers submit structured feedback (UX rating + free‑text)
-  • appends feedback to a local JSONL *and* merges it into a private Hub dataset
-The dataset is never overwritten: we always pull, merge, deduplicate, and push.
-"""
-
 from __future__ import annotations
 
-# ‑‑ standard lib
+# -- standard lib
 import json
 import os
 import time
 import uuid
 from threading import Thread
 
-# ‑‑ third‑party deps (declared in requirements.txt of the Space)
+# -- third-party deps (declared in requirements.txt of the Space)
 import gradio as gr
 from gradio_modal import Modal
 from transformers import (
@@ -29,7 +19,7 @@ from datasets import Dataset, load_dataset, concatenate_datasets, DownloadMode
 from huggingface_hub import HfApi, login
 import spaces
 
-# ──────────────────────────── model & constants ─────────────────────────────
+# ──────────────────────────── model & constants ─────────────────────────────
 checkpoint = "marin-community/marin-8b-instruct"
 device = "cuda"  # the Space runner gives us a GPU
 
@@ -37,8 +27,8 @@ device = "cuda"  # the Space runner gives us a GPU
 tokenizer = AutoTokenizer.from_pretrained(checkpoint)
 model = AutoModelForCausalLM.from_pretrained(checkpoint).to(device)
 
-# feedback dataset details
-DATASET_REPO = "WillHeld/model-feedback"  # <‑‑ change to your namespace if needed
+# feedback dataset details
+DATASET_REPO = "WillHeld/model-feedback"  # <-- change to your namespace if needed
 DATA_DIR = "./feedback_data"
 DATA_FILE = "feedback.jsonl"
 os.makedirs(DATA_DIR, exist_ok=True)
@@ -57,7 +47,7 @@ def save_feedback_locally(conversation: list[dict[str, str]],
         "feedback": feedback_text,
     }
     fp = os.path.join(DATA_DIR, DATA_FILE)
-    with open(fp, "a", encoding="utf‑8") as f:
+    with open(fp, "a", encoding="utf-8") as f:
         f.write(json.dumps(record, ensure_ascii=False) + "\n")
     return record["id"]
 
@@ -70,7 +60,7 @@ def push_feedback_to_hub(hf_token: str | None = None) -> bool:  # noqa: C901
     1.  Authenticate with `hf_token` (fall back to $HF_TOKEN env).
     2.  Load *local* feedback just written in `feedback.jsonl`.
     3.  Pull existing remote split (if any); concat & `unique("id")`.
-    4.  Push the merged dataset back. Never deletes remote shards ⇒ safe.
+    4.  Push the merged dataset back. Never deletes remote shards ⇒ safe.
     """
 
     hf_token = hf_token or os.getenv("HF_TOKEN")
@@ -85,7 +75,7 @@ def push_feedback_to_hub(hf_token: str | None = None) -> bool:  # noqa: C901
         return False
 
     # local rows → Dataset
-    with open(fp, encoding="utf‑8") as f:
+    with open(fp, encoding="utf-8") as f:
         local_ds = Dataset.from_list([json.loads(l) for l in f])
 
     # try to pull remote
@@ -153,7 +143,7 @@ def generate_response(message: str,
     partial = ""
     for token in streamer:
         partial += token
-        yield partial, history  # 1st out = msg, 2nd out = state
+        yield partial, history  # 1st out = msg, 2nd out = state
 
     # once finished, commit assistant reply to history
     history.append({"role": "assistant", "content": partial})
@@ -168,12 +158,12 @@ def submit_feedback(conversation_state: list[dict[str, str]],
     save_feedback_locally(conversation_state, satisfaction, feedback_text)
     pushed = push_feedback_to_hub()
     if pushed:
-        return "✅  Thanks! Your feedback is safely stored."
+        return "✅  Thanks! Your feedback is safely stored."
     return "⚠️  Saved locally; Hub push failed. Check server logs."
 
 # ──────────────────────────── UI layout ────────────────────────────────────
 
-with gr.Blocks(title="Marin‑8B Research Preview") as demo:
+with gr.Blocks(title="Marin-8B Research Preview") as demo:
     # state object to surface chat history to the feedback form
     conversation_state = gr.State([])
 
@@ -186,7 +176,7 @@ with gr.Blocks(title="Marin‑8B Research Preview") as demo:
                                    gr.Slider(0.1, 2.0, value=0.7, step=0.1,
                                              label="Temperature"),
                                    gr.Slider(0.1, 1.0, value=0.9, step=0.05,
-                                             label="Top‑P")],
+                                             label="Top-P")],
                 additional_outputs=[conversation_state],
                 type="messages",
             )
@@ -198,7 +188,7 @@ with gr.Blocks(title="Marin‑8B Research Preview") as demo:
     # feedback modal (hidden by default)
     with Modal(visible=False) as fb_modal:
         gr.Markdown("## Research Preview Feedback")
-        gr.Markdown("We appreciate your help improving Marin‑8B! ✨")
+        gr.Markdown("We appreciate your help improving Marin-8B! ✨")
 
         sat_radio = gr.Radio([
             "Very satisfied", "Satisfied", "Neutral",
@@ -211,8 +201,8 @@ with gr.Blocks(title="Marin‑8B Research Preview") as demo:
         status_box = gr.Textbox(label="Status", interactive=False)
 
     # interactions
-    report_btn.click(lambda: None, None, None, _js="() => window.modal_open()")
-    # the JS helper above relies on gradio‑modal’s injected helper.
+    # open the modal without custom JS – use Modal update
+    report_btn.click(lambda: Modal(visible=True), None, fb_modal)
 
     send_btn.click(
         submit_feedback,