Update app.py

app.py

@@ -25,13 +25,15 @@ MAIN_SYSTEM_PROMPT = {
     "role": "system",
     "content": """You are Sam, an intelligent and proactive English tutor. You drive the conversation and actively engage students. Your responses must be in JSON format with these keys:
         'response': Your main response (keep it conversational and engaging),
-        'corrections': Specific grammar or pronunciation corrections with examples,
-        'vocabulary': Alternative words/phrases with explanations,
+        'corrections': ALWAYS provide specific grammar or pronunciation corrections with examples (if none needed, say "Great grammar!"),
+        'vocabulary': ALWAYS suggest alternative words/phrases with explanations (if none needed, suggest related vocabulary),
         'level_assessment': Current assessment (beginner/intermediate/advanced),
         'encouragement': A motivating comment,
         'context_memory': Important details about the user,
         'next_question': A follow-up question to keep conversation flowing
         
+        IMPORTANT: You MUST always provide corrections and vocabulary suggestions in every response. Even if the student speaks perfectly, provide positive feedback and suggest advanced vocabulary or alternative expressions.
+        
         Your personality:
         - Be the conversation driver - ask follow-up questions
         - Show genuine interest in the student's life
@@ -42,10 +44,17 @@ MAIN_SYSTEM_PROMPT = {
         - Ask about their day, work, hobbies, culture, goals
         
         Correction guidelines:
-        - Always provide corrections if there are grammar mistakes
-        - Suggest better vocabulary choices
-        - Give pronunciation tips when needed
+        - ALWAYS provide corrections field - even if it's positive feedback
+        - ALWAYS provide vocabulary field - suggest alternatives or related words
         - Use format: "Instead of 'X', try saying 'Y'"
+        - Give pronunciation tips when needed
+        - If no mistakes, say "Excellent grammar!" or "Perfect sentence structure!"
+        
+        Vocabulary guidelines:
+        - ALWAYS suggest vocabulary - even if it's synonyms or advanced alternatives
+        - Provide explanations for suggested words
+        - Use format: "Instead of 'good', try 'excellent' or 'outstanding'"
+        - Suggest topic-related vocabulary
         
         Conversation flow:
         - Start with personal questions (name, country, job, hobbies)
@@ -253,14 +262,26 @@ def process_audio(audio, history, transcript, corrections):
         # Update transcript
         new_transcript = transcript + f"\n\n🎤 You: {user_message}\n🤖 Sam: {main_response}"
         
-        # Update corrections and vocabulary (THIS IS THE FIX!)
+        # Update corrections and vocabulary with debugging
         new_corrections = corrections
         correction_parts = []
         
-        if bot_response.get("corrections") and bot_response["corrections"].strip():
+        # Debug: Print the bot response to see what we're getting
+        print(f"DEBUG - Bot response keys: {bot_response.keys()}")
+        print(f"DEBUG - Corrections: '{bot_response.get('corrections', 'NOT FOUND')}'")
+        print(f"DEBUG - Vocabulary: '{bot_response.get('vocabulary', 'NOT FOUND')}'")
+        print(f"DEBUG - Level: '{bot_response.get('level_assessment', 'NOT FOUND')}'")
+        
+        # Always show current level
+        if bot_response.get("level_assessment"):
+            correction_parts.append(f"📊 **Current Level:** {bot_response['level_assessment'].title()}")
+        
+        # Show corrections if available
+        if bot_response.get("corrections") and str(bot_response["corrections"]).strip() and bot_response["corrections"] != "":
             correction_parts.append(f"✍️ **Grammar Corrections:**\n{bot_response['corrections']}")
         
-        if bot_response.get("vocabulary") and bot_response["vocabulary"].strip():
+        # Show vocabulary if available
+        if bot_response.get("vocabulary") and str(bot_response["vocabulary"]).strip() and bot_response["vocabulary"] != "":
             vocab = bot_response['vocabulary']
             if isinstance(vocab, dict):
                 vocab_text = "\n".join([f"• '{k}' → '{v}'" for k, v in vocab.items()])
@@ -268,12 +289,31 @@ def process_audio(audio, history, transcript, corrections):
                 vocab_text = str(vocab)
             correction_parts.append(f"📚 **Vocabulary Suggestions:**\n{vocab_text}")
         
-        if bot_response.get("level_assessment"):
-            correction_parts.append(f"📊 **Current Level:** {bot_response['level_assessment'].title()}")
+        # Show encouragement
+        if bot_response.get("encouragement"):
+            correction_parts.append(f"💡 **Encouragement:**\n{bot_response['encouragement']}")
+        
+        # Always show user info if available
+        if tutor.user_info.get("name"):
+            info_parts = []
+            if tutor.user_info.get("name"): info_parts.append(f"Name: {tutor.user_info['name']}")
+            if tutor.user_info.get("country"): info_parts.append(f"Country: {tutor.user_info['country']}")
+            if tutor.user_info.get("level"): info_parts.append(f"Level: {tutor.user_info['level']}")
+            if info_parts:
+                correction_parts.append(f"👤 **Your Profile:**\n{' | '.join(info_parts)}")
         
-        if correction_parts:
-            new_correction_text = "\n\n".join(correction_parts)
-            new_corrections = new_corrections + f"\n\n--- Latest Feedback ---\n{new_correction_text}" if new_corrections else new_correction_text
+        # If still no corrections, show a default message
+        if not correction_parts:
+            correction_parts.append("🎯 **Feedback:** Keep practicing! Sam is analyzing your English and will provide feedback soon.")
+        
+        # Create the new corrections text
+        new_correction_text = "\n\n".join(correction_parts)
+        timestamp = f"[{user_message[:30]}...]" if len(user_message) > 30 else f"[{user_message}]"
+        
+        if new_corrections:
+            new_corrections = new_corrections + f"\n\n--- Latest Response {timestamp} ---\n{new_correction_text}"
+        else:
+            new_corrections = f"--- Latest Response {timestamp} ---\n{new_correction_text}"
         
         return history, audio_response, new_transcript, new_corrections
     except Exception as e:
@@ -290,7 +330,7 @@ def clear_chat():
 
 with gr.Blocks(theme=gr.themes.Soft()) as demo:
     gr.Markdown("# 🎓 English Learning Assistant with Sam")
-    gr.Markdown("🎤 **Record your voice and click submit** - Sam will actively guide your conversation and help improve your English!")
+    gr.Markdown("🎤 **Record your voice** - Sam will automatically respond when you finish recording and help improve your English!")
     
     with gr.Row():
         with gr.Column(scale=3):
@@ -302,15 +342,13 @@ with gr.Blocks(theme=gr.themes.Soft()) as demo:
             )
             
             with gr.Row():
-                with gr.Column(scale=2):
+                with gr.Column(scale=1):
                     audio_input = gr.Audio(
-                        label="🎙️ Record your voice",
+                        label="🎙️ Record your voice (auto-submits when finished)",
                         type="filepath",
                         show_label=True
                     )
                 with gr.Column(scale=1):
-                    submit_btn = gr.Button("📤 Submit Recording", variant="primary", size="lg")
-                with gr.Column(scale=2):
                     audio_output = gr.Audio(
                         label="🔊 Sam's response",
                         type="filepath",
@@ -343,8 +381,9 @@ with gr.Blocks(theme=gr.themes.Soft()) as demo:
         clear_btn = gr.Button("🔄 Start New Conversation", variant="secondary", size="lg")
         gr.Markdown("💡 **Tip**: Sam will actively guide the conversation and provide personalized feedback!")
     
-    submit_btn.click(
-        submit_recording,
+    # Auto-submit when audio is recorded
+    audio_input.change(
+        process_audio,
         inputs=[audio_input, chatbot, transcript_display, corrections_display],
         outputs=[chatbot, audio_output, transcript_display, corrections_display]
     )