fix (missing await in endpoint)

app.py

@@ -752,10 +752,9 @@
 #     uvicorn.run(app, host="0.0.0.0", port=port)
 
 
-
 """
 Farmer.chat Alert Summary Generator - FastAPI Application
-Modular architecture with alert-focused intelligence
+FIXED: Proper async handling - endpoints await async pipeline methods
 """
 
 from fastapi import FastAPI, HTTPException
@@ -768,7 +767,7 @@ import os
 # Import pipeline components
 from src.pipeline import FarmerChatPipeline
 
-# Import MCP servers (assuming they exist in src/servers/)
+# Import MCP servers
 from src.servers.weather import WeatherServer
 from src.servers.soil import SoilPropertiesServer
 from src.servers.water import WaterServer
@@ -803,7 +802,7 @@ class QueryRequest(BaseModel):
 
 
 # ============================================================================
-# LOCATION DATA
+# BIHAR LOCATION DATA
 # ============================================================================
 
 BIHAR_DATA = {
@@ -1003,6 +1002,7 @@ LOCATIONS = {
 }
 
 
+
 # ============================================================================
 # FASTAPI APPLICATION
 # ============================================================================
@@ -1013,7 +1013,7 @@ app = FastAPI(
     version="2.0.0"
 )
 
-# CORS configuration
+# CORS configuration - allow all for development
 app.add_middleware(
     CORSMiddleware,
     allow_origins=["*"],
@@ -1032,24 +1032,24 @@ servers: Dict = {}
 
 
 # ============================================================================
-# STARTUP & SHUTDOWN
+# STARTUP & SHUTDOWN (using lifespan - modern FastAPI pattern)
 # ============================================================================
 
-@app.on_event("startup")
-async def startup_event():
-    """Initialize MCP servers and pipeline on startup"""
+from contextlib import asynccontextmanager
+
+@asynccontextmanager
+async def lifespan(app: FastAPI):
+    """Initialize on startup, cleanup on shutdown"""
     global pipeline, servers
     
+    # STARTUP
+    print("\n" + "="*60)
+    print("Initializing Farmer.chat Alert System")
+    print("="*60 + "\n")
+    
     try:
-        print("\n" + "="*60)
-        print("Initializing Farmer.chat Alert System")
-        print("="*60 + "\n")
-        
         # Initialize MCP servers
         print("Initializing MCP servers...")
-        
-        # Note: Your servers don't need arguments in their constructors
-        # WaterServer hardcodes cache_dir internally
         servers = {
             "weather": WeatherServer(),
             "soil": SoilPropertiesServer(),
@@ -1057,11 +1057,10 @@ async def startup_event():
             "elevation": ElevationServer(),
             "pests": PestsServer()
         }
-        
         print("✓ All MCP servers initialized successfully\n")
         
         # Initialize pipeline with default location (Patna)
-        default_location = LOCATIONS.get("patna", {"latitude": 25.6093, "longitude": 85.1235})
+        default_location = {"latitude": 25.6093, "longitude": 85.1235}
         
         pipeline = FarmerChatPipeline(
             servers=servers,
@@ -1075,12 +1074,29 @@ async def startup_event():
     except Exception as e:
         print(f"✗ Pipeline initialization failed: {str(e)}")
         raise
+    
+    yield  # Application runs here
+    
+    # SHUTDOWN
+    print("\nShutting down Farmer.chat Alert System...")
 
 
-@app.on_event("shutdown")
-async def shutdown_event():
-    """Cleanup on shutdown"""
-    print("\nShutting down Farmer.chat Alert System...")
+# Apply lifespan to app
+app = FastAPI(
+    title="Farmer.chat Alert Summary API",
+    description="Agricultural intelligence system with alert-focused MCP pipeline",
+    version="2.0.0",
+    lifespan=lifespan
+)
+
+# Re-add CORS after recreating app
+app.add_middleware(
+    CORSMiddleware,
+    allow_origins=["*"],
+    allow_credentials=True,
+    allow_methods=["*"],
+    allow_headers=["*"],
+)
 
 
 # ============================================================================
@@ -1094,13 +1110,11 @@ async def root():
         "service": "Farmer.chat Alert Summary Generator",
         "version": "2.0.0",
         "status": "operational",
-        "architecture": "Modular MCP Pipeline",
         "endpoints": {
-            "locations": "/locations - Get all available locations",
-            "generate_alert": "/generate-alert - Generate alert summary for location",
-            "query": "/query - Process specific farmer query",
-            "health": "/health - Health check",
-            "server_status": "/server-status - Check MCP server status"
+            "locations": "/locations",
+            "generate_alert": "/generate-alert",
+            "query": "/query",
+            "health": "/health"
         }
     }
 
@@ -1119,22 +1133,9 @@ async def health_check():
     }
 
 
-@app.get("/server-status")
-async def server_status():
-    """Get status of all MCP servers"""
-    if pipeline is None:
-        raise HTTPException(status_code=503, detail="Pipeline not initialized")
-    
-    status = pipeline.get_server_status()
-    return {
-        "servers": status,
-        "timestamp": datetime.utcnow().isoformat()
-    }
-
-
 @app.get("/locations")
 async def get_locations():
-    """Get all available districts and villages"""
+    """Get all available locations"""
     return {
         "districts": BIHAR_DATA,
         "total_locations": len(LOCATIONS),
@@ -1146,33 +1147,30 @@ async def get_locations():
 async def generate_alert(request: LocationRequest):
     """
     Generate comprehensive alert summary for a location.
-    
-    Queries all MCP servers and compiles an actionable alert summary
-    focusing on critical information and recommendations.
+    FIX: Now properly awaits the async pipeline method.
     """
-    
     if pipeline is None:
         raise HTTPException(status_code=503, detail="Pipeline not initialized")
     
-    # Lookup location coordinates
+    # Lookup location (case-insensitive)
     location_key = request.location_name.lower().strip()
     
     if location_key not in LOCATIONS:
-        # Try case-insensitive partial match
+        # Try partial match
         matches = [k for k in LOCATIONS.keys() if location_key in k.lower()]
         if matches:
             location_key = matches[0]
         else:
             raise HTTPException(
                 status_code=404, 
-                detail=f"Location '{request.location_name}' not found in database"
+                detail=f"Location '{request.location_name}' not found"
             )
     
     coordinates = LOCATIONS[location_key]
     
     try:
-        # Generate alert using pipeline
-        result = pipeline.generate_alert(
+        # FIX: AWAIT the async method!
+        result = await pipeline.generate_alert(
             location=coordinates,
             location_name=request.location_name
         )
@@ -1196,11 +1194,8 @@ async def generate_alert(request: LocationRequest):
 async def process_query(request: QueryRequest):
     """
     Process a specific farmer query.
-    
-    Queries all MCP servers and returns a response focusing on
-    information relevant to the question.
+    FIX: Now properly awaits the async pipeline method.
     """
-    
     if pipeline is None:
         raise HTTPException(status_code=503, detail="Pipeline not initialized")
     
@@ -1216,8 +1211,8 @@ async def process_query(request: QueryRequest):
                 location = LOCATIONS[matches[0]]
     
     try:
-        # Process query through pipeline
-        result = pipeline.process_query(
+        # FIX: AWAIT the async method!
+        result = await pipeline.process_query(
             query=request.query,
             location=location
         )
@@ -1238,10 +1233,11 @@ async def process_query(request: QueryRequest):
 
 
 # ============================================================================
-# MAIN (for local testing)
+# MAIN
 # ============================================================================
 
 if __name__ == "__main__":
     import uvicorn
-    uvicorn.run(app, host="0.0.0.0", port=7680)
+    port = int(os.getenv("PORT", 7860))
+    uvicorn.run(app, host="0.0.0.0", port=port)