Update backend/crud/bill_crud.py

backend/crud/bill_crud.py

@@ -213,27 +213,31 @@ def get_all_bills(db: Session):
     """Get all bills"""
     return db.query(Bill).order_by(Bill.created_date.desc()).all()
 def delete_bill(db: Session, bill_id: int):
-    # Fetch the bill
     bill = db.query(models.Bill).filter(models.Bill.id == bill_id).first()
     
     if not bill:
         return "bill_not_found"
 
-    # --- 1. NEW FIX: Delete the linked record in the `sales` table first ---
-    db.query(models.Sale).filter(models.Sale.bill_id == bill_id).delete()
-    
-    # --- 2. Restore stock and delete the line items ---
-    if hasattr(bill, 'items'):
+    if bill.status == "finalized" and hasattr(bill, 'items'):
         for item in bill.items:
-            # Restore the stock
             product = db.query(models.Product).filter(models.Product.id == item.product_id).first()
             if product:
                 product.quantity_left += item.quantity 
-            
-            # Delete the item
-            db.delete(item)
-            
-    # --- 3. Now that all children are gone, safely delete the parent bill ---
+        db.commit() 
+   
+    sales = db.query(models.Sale.id).filter(models.Sale.bill_id == bill_id).all()
+    sale_ids = [sale.id for sale in sales]
+
+    if sale_ids:
+        
+        db.query(models.Return).filter(models.Return.sale_id.in_(sale_ids)).delete(synchronize_session=False)
+   
+    db.query(models.Sale).filter(models.Sale.bill_id == bill_id).delete(synchronize_session=False)
+
+    
+    db.query(models.BillItem).filter(models.BillItem.bill_id == bill_id).delete(synchronize_session=False)
+
+    
     db.delete(bill)
     db.commit()