abinazebinoy commited on
Commit
6414ba4
·
1 Parent(s): 2d87a38

fix(BUG-H3): move failure notification to last workflow step -- load and commit failures now also trigger the alert

Browse files
Files changed (1) hide show
  1. .github/workflows/daily_scrape.yml +6 -7
.github/workflows/daily_scrape.yml CHANGED
@@ -87,13 +87,6 @@ jobs:
87
  d.close()
88
  "
89
 
90
- - name: notify on failure
91
- if: failure()
92
- run: |
93
- echo "::error::Daily scrape pipeline FAILED at $(date -u +%Y-%m-%dT%H:%MZ)"
94
- echo "Check pipeline status at /admin/pipeline/status"
95
- exit 0
96
-
97
  - name: load pipeline output into Neo4j
98
  env:
99
  NEO4J_URI: ${{ secrets.NEO4J_URI }}
@@ -119,3 +112,9 @@ jobs:
119
  git diff --staged --quiet || \
120
  git commit -m "chore(data): daily pipeline run $(date -u +%Y-%m-%d)"
121
  git push origin main || true
 
 
 
 
 
 
 
87
  d.close()
88
  "
89
 
 
 
 
 
 
 
 
90
  - name: load pipeline output into Neo4j
91
  env:
92
  NEO4J_URI: ${{ secrets.NEO4J_URI }}
 
112
  git diff --staged --quiet || \
113
  git commit -m "chore(data): daily pipeline run $(date -u +%Y-%m-%d)"
114
  git push origin main || true
115
+ # BUG-H3 FIX: moved to end so it covers ALL steps including load+commit
116
+ - name: notify on failure
117
+ if: failure()
118
+ run: |
119
+ echo "::error::Daily scrape pipeline FAILED at $(date -u +%Y-%m-%dT%H:%MZ)"
120
+ echo "Check /admin/pipeline/status and GitHub Actions logs for details"