Update Dockerfile

Dockerfile

@@ -2,49 +2,93 @@
 FROM node:18-alpine AS client
 WORKDIR /app/client
 
+# Install client dependencies and build
 COPY client/package.json ./
 RUN npm install
 COPY client/ ./
 RUN npm run build
 
-# ---------- 2) Build the Node server with ffmpeg & yt-dlp fallback ----------
+# ---------- 2) Build the Node server with yt-dlp & ffmpeg (fallbacks) ----------
 FROM node:18-alpine AS server
 WORKDIR /app/server
 
+# Core runtime tools: python, pip (for build-time fallback), ffmpeg, curl, ca-certificates
 RUN apk add --no-cache python3 py3-pip ffmpeg curl ca-certificates
 
+# Try a few build-time ways to provide yt-dlp (preferred order):
+# 1) apk (yt-dlp or yt-dlp-core), 2) download standalone binary to /usr/local/bin, 3) pip install at build time
 RUN set -eux; \
     if apk add --no-cache yt-dlp; then \
-        echo "installed yt-dlp from apk"; \
+      echo "installed yt-dlp from apk"; \
     elif apk add --no-cache yt-dlp-core; then \
-        echo "installed yt-dlp-core from apk"; \
+      echo "installed yt-dlp-core from apk"; \
     elif curl -fsSL -o /usr/local/bin/yt-dlp https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp; then \
-        chmod +x /usr/local/bin/yt-dlp; \
-        echo "downloaded yt-dlp binary to /usr/local/bin/yt-dlp"; \
+      chmod +x /usr/local/bin/yt-dlp; \
+      echo "downloaded standalone yt-dlp to /usr/local/bin/yt-dlp"; \
     else \
-        echo "falling back to pip install yt-dlp at build time"; \
-        python3 -m pip install --no-cache-dir -U yt-dlp; \
+      echo "falling back to pip install at build time"; \
+      python3 -m pip install --no-cache-dir -U yt-dlp; \
     fi; \
+    # sanity check (non-fatal)
     command -v yt-dlp >/dev/null 2>&1 && yt-dlp --version || true
 
+# Install server dependencies and copy server source
 COPY server/package.json ./
 RUN npm install
 COPY server/ ./
 
+# Bring in client build
 RUN mkdir -p ../client/dist
 COPY --from=client /app/client/dist ../client/dist
 
+# Environment
 ENV NODE_ENV=production
 ENV PORT=3000
 
-# Put start script directly into image so no external COPY is required
-RUN cat > /usr/local/bin/start.sh <<'SH'\n\
-#!/bin/sh\n\
-set -eu\n\
-TMP_BIN=\"/tmp/yt-dlp\"\n\
-SYS_BIN=\"$(command -v yt-dlp 2>/dev/null || true)\"\n\
-echo \"startup: checking yt-dlp...\"\n\
-if curl -fsSL -o \"$TMP_BIN\" \"https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp\"; then\n  chmod +x \"$TMP_BIN\" || true\n  YTDLP=\"$TMP_BIN\"\n  echo \"Using downloaded yt-dlp from $TMP_BIN\"\nelse\n  if [ -n \"$SYS_BIN\" ]; then\n    YTDLP=\"$SYS_BIN\"\n    echo \"Using system yt-dlp at $SYS_BIN\"\n  else\n    echo \"Warning: yt-dlp not found (neither system install nor /tmp download).\"\n    YTDLP=\"\"\n  fi\nfi\nif [ -n \"$YTDLP\" ]; then\n  echo \"yt-dlp version:\"\n  \"$YTDLP\" --version || true\nfi\nexport YTDLP_BIN=\"$YTDLP\"\nif [ -x \"$TMP_BIN\" ]; then\n  export PATH=\"/tmp:$PATH\"\nfi\nexec npm start\nSH
+# Runtime start script:
+# - Attempts to download latest standalone yt-dlp to /tmp (writable on HF/Spaces)
+# - If download succeeds, it will be used; otherwise falls back to system yt-dlp (from apk/pip/binary)
+# - Exposes the resolved path in $YTDLP_BIN and puts /tmp in PATH if a downloaded binary exists
+RUN cat > /usr/local/bin/start.sh <<'SH'
+#!/bin/sh
+set -eu
+
+TMP_BIN="/tmp/yt-dlp"
+SYS_BIN="$(command -v yt-dlp 2>/dev/null || true)"
+
+echo "startup: checking yt-dlp..."
+
+# Try to download the standalone binary into /tmp (writable on many restricted platforms)
+if curl -fsSL -o "$TMP_BIN" "https://github.com/yt-dlp/yt-dlp/releases/latest/download/yt-dlp"; then
+  chmod +x "$TMP_BIN" || true
+  YTDLP="$TMP_BIN"
+  echo "Using downloaded yt-dlp from $TMP_BIN"
+else
+  if [ -n "$SYS_BIN" ]; then
+    YTDLP="$SYS_BIN"
+    echo "Using system yt-dlp at $SYS_BIN"
+  else
+    echo "Warning: yt-dlp not found (neither system install nor /tmp download)."
+    YTDLP=""
+  fi
+fi
+
+if [ -n "$YTDLP" ]; then
+  echo "yt-dlp version:"
+  "$YTDLP" --version || true
+fi
+
+export YTDLP_BIN="$YTDLP"
+
+# If we downloaded to /tmp, put /tmp first on PATH so `yt-dlp` resolves to the downloaded binary
+if [ -x "$TMP_BIN" ]; then
+  export PATH="/tmp:$PATH"
+fi
+
+# Finally start the app
+exec npm start
+SH
+
 RUN chmod +x /usr/local/bin/start.sh
 
 EXPOSE 3000