fix: Keep the selected models if they're valid. Add more logging

app.py

@@ -197,7 +197,7 @@ def main() -> None:
 
         language_names_dropdown.change(
             fn=partial(update_model_ids_dropdown, results_dfs=results_dfs),
-            inputs=language_names_dropdown,
+            inputs=[language_names_dropdown, model_ids_dropdown],
             outputs=model_ids_dropdown,
         )
 
@@ -228,24 +228,36 @@ def main() -> None:
 
 
 def update_model_ids_dropdown(
-    language_names: list[str], results_dfs: dict[Language, pd.DataFrame] | None
+    language_names: list[str],
+    model_ids: list[str],
+    results_dfs: dict[Language, pd.DataFrame] | None,
 ) -> dict:
     """When the language names are updated, update the model ids dropdown.
 
     Args:
         language_names:
             The names of the languages to include in the plot.
+        model_ids:
+            The ids of the models to include in the plot.
         results_dfs:
             The results dataframes for each language.
 
     Returns:
         The Gradio update to the model ids dropdown.
     """
+    global last_fetch
+    minutes_since_last_fetch = (dt.datetime.now() - last_fetch).total_seconds() / 60
+    if minutes_since_last_fetch > UPDATE_FREQUENCY_MINUTES:
+        results_dfs = fetch_results()
+        last_fetch = dt.datetime.now()
+
     if results_dfs is None or len(language_names) == 0:
+        if results_dfs is None:
+            logger.info("No results fetched yet. Resetting model ids dropdown.")
+        else:
+            logger.info("No languages selected. Resetting model ids dropdown.")
         return gr.update(choices=[], value=[])
 
-    # Download the newest records if it has been more than 5 minutes since the last
-
     filtered_results_dfs = {
         language: df
         for language, df in results_dfs.items()
@@ -265,9 +277,23 @@ def update_model_ids_dropdown(
     ]
 
     if len(filtered_models) == 0:
+        logger.info(
+            "No valid models for the selected languages. Resetting model ids dropdown."
+        )
         return gr.update(choices=[], value=[])
 
-    return gr.update(choices=filtered_models, value=random.sample(filtered_models, k=1))
+    valid_selected_models = [
+        model_id for model_id in model_ids if model_id in filtered_models
+    ]
+    if not valid_selected_models:
+        valid_selected_models = random.sample(filtered_models, k=1)
+
+    logger.info(
+        f"Updated model ids dropdown with {len(filtered_models)} valid models for "
+        f"the selected languages, with {len(valid_selected_models)} selected."
+    )
+
+    return gr.update(choices=filtered_models, value=valid_selected_models)
 
 
 def produce_radial_plot(
@@ -291,15 +317,21 @@ def produce_radial_plot(
     Returns:
         A plotly figure.
     """
-    if results_dfs is None or len(language_names) == 0 or len(model_ids) == 0:
-        return go.Figure()
-
     global last_fetch
     minutes_since_last_fetch = (dt.datetime.now() - last_fetch).total_seconds() / 60
     if minutes_since_last_fetch > UPDATE_FREQUENCY_MINUTES:
         results_dfs = fetch_results()
         last_fetch = dt.datetime.now()
 
+    if results_dfs is None or len(language_names) == 0 or len(model_ids) == 0:
+        if results_dfs is None:
+            logger.info("No results fetched yet. Resetting plot.")
+        elif len(language_names) == 0:
+            logger.info("No languages selected. Resetting plot.")
+        else:
+            logger.info("No models selected. Resetting plot.")
+        return go.Figure()
+
     logger.info(
         f"Producing radial plot for models {model_ids!r} on languages "
         f"{language_names!r}..."