File size: 12,037 Bytes
56838f4
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
import { convexTest } from "convex-test";
import { expect, test, describe } from "vitest";
import schema from "../schema";
import { api, internal } from "../_generated/api";
import { PRODUCT_CATALOG } from "../config/productCatalog";

const modules = import.meta.glob("../**/*.ts");

// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------

const BASE_TIMESTAMP = new Date("2026-03-21T10:00:00Z").getTime();
const TEST_USER_ID = "user_checkout_test_001";
const TEST_CUSTOMER_ID = "cust_checkout_e2e";

/**
 * Helper to call the seedProductPlans mutation and return plans list.
 */
async function seedAndListPlans(t: ReturnType<typeof convexTest>) {
  await t.mutation(internal.payments.seedProductPlans.seedProductPlans, {});
  return t.query(api.payments.seedProductPlans.listProductPlans, {});
}

/**
 * Helper to seed a customer record that maps dodoCustomerId to userId.
 * This mirrors the production flow where checkout metadata or a prior
 * subscription.active event populates the customers table.
 */
async function seedCustomer(t: ReturnType<typeof convexTest>) {
  await t.run(async (ctx) => {
    await ctx.db.insert("customers", {
      userId: TEST_USER_ID,
      dodoCustomerId: TEST_CUSTOMER_ID,
      email: "test@example.com",
      createdAt: BASE_TIMESTAMP,
      updatedAt: BASE_TIMESTAMP,
    });
  });
}

/**
 * Helper to simulate a subscription webhook event.
 * The seeded customer mapping mirrors production renewals where Dodo
 * customer ownership can be resolved even when metadata is absent.
 */
async function simulateSubscriptionWebhook(
  t: ReturnType<typeof convexTest>,
  opts: {
    webhookId: string;
    subscriptionId: string;
    productId: string;
    customerId?: string;
    previousBillingDate?: string;
    nextBillingDate?: string;
    timestamp?: number;
  },
) {
  await t.mutation(
    internal.payments.webhookMutations.processWebhookEvent,
    {
      webhookId: opts.webhookId,
      eventType: "subscription.active",
      rawPayload: {
        type: "subscription.active",
        data: {
          subscription_id: opts.subscriptionId,
          product_id: opts.productId,
          customer: {
            customer_id: opts.customerId ?? TEST_CUSTOMER_ID,
          },
          previous_billing_date:
            opts.previousBillingDate ?? new Date().toISOString(),
          next_billing_date:
            opts.nextBillingDate ??
            new Date(Date.now() + 30 * 24 * 60 * 60 * 1000).toISOString(),
          metadata: {},
        },
      },
      timestamp: opts.timestamp ?? BASE_TIMESTAMP,
    },
  );
}

// ---------------------------------------------------------------------------
// E2E Contract Tests: Checkout -> Webhook -> Entitlements
// ---------------------------------------------------------------------------

describe("E2E checkout-to-entitlement contract", () => {
  test("product plans can be seeded and queried", async () => {
    const t = convexTest(schema, modules);

    const plans = await seedAndListPlans(t);

    // Should have at least 5 plans: pro_monthly, pro_annual, api_starter, api_business, enterprise
    expect(plans.length).toBeGreaterThanOrEqual(5);

    // Verify key plans exist
    const proMonthly = plans.find((p) => p.planKey === "pro_monthly");
    expect(proMonthly).toBeDefined();
    expect(proMonthly!.displayName).toBe("Pro Monthly");

    const proAnnual = plans.find((p) => p.planKey === "pro_annual");
    expect(proAnnual).toBeDefined();
    expect(proAnnual!.displayName).toBe("Pro Annual");

    const apiStarter = plans.find((p) => p.planKey === "api_starter");
    expect(apiStarter).toBeDefined();

    const apiBusiness = plans.find((p) => p.planKey === "api_business");
    expect(apiBusiness).toBeDefined();

    const enterprise = plans.find((p) => p.planKey === "enterprise");
    expect(enterprise).toBeDefined();
  });

  test("checkout -> subscription.active webhook -> entitlements granted for pro_monthly", async () => {
    const t = convexTest(schema, modules);

    // Step 1: Seed product plans + customer mapping
    const plans = await seedAndListPlans(t);
    await seedCustomer(t);
    const proMonthly = plans.find((p) => p.planKey === "pro_monthly");
    expect(proMonthly).toBeDefined();

    // Step 2: Simulate subscription.active webhook (with wm_user_id metadata)
    const futureDate = new Date(Date.now() + 30 * 24 * 60 * 60 * 1000);
    await simulateSubscriptionWebhook(t, {
      webhookId: "wh_checkout_e2e_001",
      subscriptionId: "sub_checkout_e2e_001",
      productId: proMonthly!.dodoProductId,
      nextBillingDate: futureDate.toISOString(),
    });

    // Step 3: Query entitlements for the real user (not fallback)
    const entitlements = await t.query(
      internal.entitlements.getEntitlementsByUserId,
      { userId: TEST_USER_ID },
    );

    // Step 4: Assert pro_monthly entitlements
    expect(entitlements.planKey).toBe("pro_monthly");
    expect(entitlements.features.tier).toBe(1);
    expect(entitlements.features.apiAccess).toBe(false);
    expect(entitlements.features.maxDashboards).toBe(10);
  });

  test("checkout -> subscription.active webhook -> entitlements granted for api_starter", async () => {
    const t = convexTest(schema, modules);

    // Step 1: Seed product plans + customer mapping
    const plans = await seedAndListPlans(t);
    await seedCustomer(t);
    const apiStarter = plans.find((p) => p.planKey === "api_starter");
    expect(apiStarter).toBeDefined();

    // Step 2: Simulate subscription.active webhook
    const futureDate = new Date(Date.now() + 30 * 24 * 60 * 60 * 1000);
    await simulateSubscriptionWebhook(t, {
      webhookId: "wh_checkout_e2e_002",
      subscriptionId: "sub_checkout_e2e_002",
      productId: apiStarter!.dodoProductId,
      nextBillingDate: futureDate.toISOString(),
    });

    // Step 3: Query entitlements
    const entitlements = await t.query(
      internal.entitlements.getEntitlementsByUserId,
      { userId: TEST_USER_ID },
    );

    // Step 4: Assert api_starter entitlements
    expect(entitlements.planKey).toBe("api_starter");
    expect(entitlements.features.tier).toBe(2);
    expect(entitlements.features.apiAccess).toBe(true);
    expect(entitlements.features.apiRateLimit).toBeGreaterThan(0);
    expect(entitlements.features.apiRateLimit).toBe(60);
    expect(entitlements.features.maxDashboards).toBe(25);
  });

  test("expired entitlements fall back to free tier", async () => {
    const t = convexTest(schema, modules);

    // Step 1: Seed product plans + customer mapping
    const plans = await seedAndListPlans(t);
    await seedCustomer(t);
    const proMonthly = plans.find((p) => p.planKey === "pro_monthly");
    expect(proMonthly).toBeDefined();

    // Step 2: Simulate webhook with billing dates both in the past (expired)
    const pastStart = new Date(Date.now() - 60 * 24 * 60 * 60 * 1000); // 60 days ago
    const pastEnd = new Date(Date.now() - 1 * 24 * 60 * 60 * 1000); // 1 day ago

    await simulateSubscriptionWebhook(t, {
      webhookId: "wh_checkout_e2e_003",
      subscriptionId: "sub_checkout_e2e_003",
      productId: proMonthly!.dodoProductId,
      previousBillingDate: pastStart.toISOString(),
      nextBillingDate: pastEnd.toISOString(),
    });

    // Step 3: Query entitlements -- should return free tier (expired)
    const entitlements = await t.query(
      internal.entitlements.getEntitlementsByUserId,
      { userId: TEST_USER_ID },
    );

    // Step 4: Assert free tier defaults
    expect(entitlements.planKey).toBe("free");
    expect(entitlements.features.tier).toBe(0);
    expect(entitlements.features.apiAccess).toBe(false);
    expect(entitlements.validUntil).toBe(0);
  });
});

// ---------------------------------------------------------------------------
// #4438 — pending-payment guard enforcement in the checkout action. The blocked
// path returns BEFORE any Dodo/signing call, so it is testable without a Dodo
// key. DODO_API_KEY / DODO_IDENTITY_SIGNING_SECRET are intentionally unset in
// the test env, so any path that reaches _createCheckoutSession rejects — which
// is exactly how we prove the bypass and different-tier paths got PAST the guard.
// ---------------------------------------------------------------------------

const NOW = Date.now();
const MIN_MS = 60 * 1000;

async function seedPendingPayment(
  t: ReturnType<typeof convexTest>,
  opts: { planKey: string; suffix: string; occurredAt?: number },
) {
  await t.run(async (ctx) => {
    await ctx.db.insert("paymentEvents", {
      userId: TEST_USER_ID,
      dodoPaymentId: `pay_pending_${opts.suffix}`,
      type: "charge",
      amount: 3999,
      currency: "USD",
      status: "requires_customer_action",
      planKey: opts.planKey,
      rawPayload: {},
      occurredAt: opts.occurredAt ?? NOW - 2 * MIN_MS,
    });
  });
}

describe("checkout action pending-payment enforcement (#4438)", () => {
  test("internalCreateCheckout returns a PAYMENT_IN_PROGRESS block for a recent pending same-tier payment", async () => {
    const t = convexTest(schema, modules);
    await seedPendingPayment(t, { planKey: "pro_monthly", suffix: "block" });

    const result = await t.action(
      internal.payments.checkout.internalCreateCheckout,
      {
        userId: TEST_USER_ID,
        productId: PRODUCT_CATALOG.pro_annual.dodoProductId!,
      },
    );

    expect(result).toMatchObject({
      blocked: true,
      code: "PAYMENT_IN_PROGRESS",
    });
  });

  test("subscription guard wins: an active same-tier subscription is returned before the pending guard fires", async () => {
    const t = convexTest(schema, modules);
    // Both a pending payment AND an active subscription in the Pro tier group.
    await seedPendingPayment(t, { planKey: "pro_monthly", suffix: "precedence" });
    await t.run(async (ctx) => {
      await ctx.db.insert("subscriptions", {
        userId: TEST_USER_ID,
        dodoSubscriptionId: "sub_precedence_001",
        dodoProductId: PRODUCT_CATALOG.pro_monthly.dodoProductId!,
        planKey: "pro_monthly",
        status: "active",
        currentPeriodStart: NOW - 5 * MIN_MS,
        currentPeriodEnd: NOW + 30 * 24 * 60 * MIN_MS,
        rawPayload: {},
        updatedAt: NOW,
      });
    });

    const result = await t.action(
      internal.payments.checkout.internalCreateCheckout,
      {
        userId: TEST_USER_ID,
        productId: PRODUCT_CATALOG.pro_annual.dodoProductId!,
      },
    );

    expect(result).toMatchObject({
      blocked: true,
      code: "ACTIVE_SUBSCRIPTION_EXISTS",
    });
  });

  test("bypassPendingGuard skips the pending block (reaches session creation)", async () => {
    const t = convexTest(schema, modules);
    await seedPendingPayment(t, { planKey: "pro_monthly", suffix: "bypass" });

    // With bypass, the guard is skipped; the action proceeds to session
    // creation, which rejects because Dodo/signing secrets are unset in tests.
    // The point is that it did NOT short-circuit with a PAYMENT_IN_PROGRESS block.
    await expect(
      t.action(internal.payments.checkout.internalCreateCheckout, {
        userId: TEST_USER_ID,
        productId: PRODUCT_CATALOG.pro_annual.dodoProductId!,
        bypassPendingGuard: true,
      }),
    ).rejects.toThrow();
  });

  test("a pending Pro payment does not block an API checkout (different tier group)", async () => {
    const t = convexTest(schema, modules);
    await seedPendingPayment(t, { planKey: "pro_monthly", suffix: "cross_tier" });

    // Different tier group → pending guard does not fire → proceeds to session
    // creation → rejects on the missing Dodo/signing secrets (never returns a block).
    await expect(
      t.action(internal.payments.checkout.internalCreateCheckout, {
        userId: TEST_USER_ID,
        productId: PRODUCT_CATALOG.api_starter.dodoProductId!,
      }),
    ).rejects.toThrow();
  });
});