File size: 10,703 Bytes
97ee7cb
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
import { convexTest } from "convex-test";
import { describe, expect, test } from "vitest";
import schema from "../schema";
import { api } from "../_generated/api";

const modules = import.meta.glob("../**/*.ts");

const USER_A = {
  subject: "user-test-a",
  tokenIdentifier: "clerk|user-test-a",
  email: "alice@example.com",
};
const USER_B = {
  subject: "user-test-b",
  tokenIdentifier: "clerk|user-test-b",
  email: "bob@example.com",
};

describe("users:ensureRecord β€” auth gate", () => {
  test("unauthenticated β†’ returns {ok:false, reason:'unauthenticated'}", async () => {
    const t = convexTest(schema, modules);
    const result = await t.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });
    expect(result).toEqual({ ok: false, reason: "unauthenticated" });
  });
});

describe("users:ensureRecord β€” happy paths", () => {
  test("first call inserts row with all fields + firstSeenAt === lastSeenAt", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
      timezone: "America/New_York",
      country: "US",
    });
    expect(result.ok).toBe(true);
    expect(result.action).toBe("inserted");

    const row = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(row).not.toBeNull();
    expect(row?.userId).toBe(USER_A.subject);
    expect(row?.email).toBe(USER_A.email);
    expect(row?.normalizedEmail).toBe(USER_A.email.toLowerCase());
    expect(row?.localeTag).toBe("en-US");
    expect(row?.localePrimary).toBe("en");
    expect(row?.timezone).toBe("America/New_York");
    expect(row?.country).toBe("US");
    expect(row?.firstSeenAt).toBe(row?.lastSeenAt);
  });

  test("second call patches locale + lastSeenAt; preserves firstSeenAt", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    await asA.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
      timezone: "America/New_York",
    });
    const before = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );

    // Brief pause to ensure now() advances.
    await new Promise((r) => setTimeout(r, 5));

    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "zh-CN",
      localePrimary: "zh",
    });
    expect(result.ok).toBe(true);
    expect(result.action).toBe("patched");

    const after = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(after?.localeTag).toBe("zh-CN");
    expect(after?.localePrimary).toBe("zh");
    // timezone NOT in second call β†’ preserved
    expect(after?.timezone).toBe("America/New_York");
    expect(after?.firstSeenAt).toBe(before?.firstSeenAt);
    expect(after?.lastSeenAt).toBeGreaterThan(before?.lastSeenAt ?? 0);
  });

  test("partial args (only locale) inserts without timezone/country", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    await asA.mutation(api.users.ensureRecord, {
      localeTag: "fr-FR",
      localePrimary: "fr",
    });
    const row = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(row?.localeTag).toBe("fr-FR");
    expect(row?.timezone).toBeUndefined();
    expect(row?.country).toBeUndefined();
  });
});

describe("users:ensureRecord β€” validation rejects malformed input", () => {
  test("invalid localeTag β†’ invalid-input, no row created", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "../etc/passwd",
      localePrimary: "en",
    });
    expect(result).toEqual({ ok: false, reason: "invalid-input", field: "localeTag" });
    const row = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(row).toBeNull();
  });

  test("invalid localePrimary β†’ invalid-input", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "EN", // uppercase rejected
    });
    expect(result).toEqual({ ok: false, reason: "invalid-input", field: "localePrimary" });
  });

  test("invalid timezone β†’ invalid-input", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
      timezone: "Mars/Olympus",
    });
    expect(result).toEqual({ ok: false, reason: "invalid-input", field: "timezone" });
  });

  test("invalid country (3 chars) β†’ invalid-input", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
      country: "USA",
    });
    expect(result).toEqual({ ok: false, reason: "invalid-input", field: "country" });
  });

  test("oversized localeTag (>64 chars) β†’ invalid-input (length-bound BEFORE regex)", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    const giant = "en" + "-" + "x".repeat(80);
    const result = await asA.mutation(api.users.ensureRecord, {
      localeTag: giant,
      localePrimary: "en",
    });
    expect(result).toEqual({ ok: false, reason: "invalid-input", field: "localeTag" });
  });
});

describe("users:ensureRecord β€” email policy", () => {
  test("email refresh on identity change (refresh on non-empty)", async () => {
    const t = convexTest(schema, modules);
    const asOldEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      email: "old@a.com",
    });
    await asOldEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    const asNewEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      email: "new@b.com",
    });
    await asNewEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    const row = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(row?.email).toBe("new@b.com");
    expect(row?.normalizedEmail).toBe("new@b.com");
  });

  test("email empty in identity β†’ does NOT blank existing email", async () => {
    const t = convexTest(schema, modules);
    const asWithEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      email: "alice@example.com",
    });
    await asWithEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    // Second call with empty email (transient gap during email-change flow).
    const asEmptyEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      email: "",
    });
    await asEmptyEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    const row = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(row?.email).toBe("alice@example.com");
    expect(row?.normalizedEmail).toBe("alice@example.com");
  });

  test("identity with no email at insert β†’ row created without email; later call fills it", async () => {
    const t = convexTest(schema, modules);
    const asNoEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      // no email
    });
    await asNoEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    const rowBefore = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(rowBefore?.email).toBeUndefined();

    const asWithEmail = t.withIdentity({
      subject: USER_A.subject,
      tokenIdentifier: USER_A.tokenIdentifier,
      email: "alice@example.com",
    });
    await asWithEmail.mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });

    const rowAfter = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .unique(),
    );
    expect(rowAfter?.email).toBe("alice@example.com");
  });
});

describe("users:ensureRecord β€” idempotency invariants", () => {
  test("5 sequential calls for same userId β†’ exactly 1 row", async () => {
    const t = convexTest(schema, modules);
    const asA = t.withIdentity(USER_A);
    for (let i = 0; i < 5; i++) {
      await asA.mutation(api.users.ensureRecord, {
        localeTag: "en-US",
        localePrimary: "en",
      });
    }
    const rows = await t.run(async (ctx) =>
      await ctx.db
        .query("users")
        .withIndex("by_userId", (q) => q.eq("userId", USER_A.subject))
        .collect(),
    );
    expect(rows.length).toBe(1);
  });

  test("different users get separate rows", async () => {
    const t = convexTest(schema, modules);
    await t.withIdentity(USER_A).mutation(api.users.ensureRecord, {
      localeTag: "en-US",
      localePrimary: "en",
    });
    await t.withIdentity(USER_B).mutation(api.users.ensureRecord, {
      localeTag: "fr-FR",
      localePrimary: "fr",
    });
    const all = await t.run(async (ctx) =>
      await ctx.db.query("users").collect(),
    );
    expect(all.length).toBe(2);
    const localesByUserId = Object.fromEntries(
      all.map((r) => [r.userId, r.localePrimary]),
    );
    expect(localesByUserId[USER_A.subject]).toBe("en");
    expect(localesByUserId[USER_B.subject]).toBe("fr");
  });
});