done with oregon for now

docs/oregon_ground_truth.md

@@ -1,106 +1,130 @@
-# OSU vs Oregon Ground Truth - Missed Plays
+# OSU vs Oregon Ground Truth - Play Detection Progress
 
-This document captures the ground truth for plays that were **missed** by the v1 Oregon baseline, along with notes about why each was missed.
+This document tracks the ground truth for plays that were **missed** by the v1 Oregon baseline, and the current status after v2 improvements.
 
 ## Video Details
 - **Video**: OSU vs Oregon 01.01.25.mkv
-- **Baseline**: `output/benchmarks/oregon_v1_baseline.json`
-- **Total plays detected (v1)**: 144 plays
+- **v1 Baseline**: `output/benchmarks/oregon_v1_baseline.json` (144 plays)
+- **v2 Benchmark**: `output/benchmarks/oregon_v2_benchmark.json` (183 plays)
 
 ---
 
-## Missed Plays
-
-### Opening Kickoff
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| ~5:00-6:00 | ~300-360 | kickoff | Opening kickoff not detected |
-
-### Normal Plays (Clock Reset Issues)
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **7:37** | 457 | normal | Clock reset to 25 when ball snapped (unusual clock behavior) |
-| **1:08:56** | 4136 | normal | Unknown reason for miss |
-| **1:11:42** | 4302 | normal | Last play of the half - clock operator error |
-| **1:51:24** | 6684 | normal | Clock operator error, should still be caught |
-| **2:14:07** | 8047 | final play | Clock resets to 40, then disappears for game end |
-
-### Punts
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **16:36** | 996 | punt | Regular punt, unknown reason for miss |
-| **48:14** | 2894 | punt | Unknown reason for miss |
-| **53:54** | 3234 | punt | Unknown reason for miss |
-| **1:32:11** | 5531 | punt | Clock freezes at 7 for a few seconds, then resets to 25 - should be caught |
-| **1:41:47** | 6107 | punt | Clock freezes at 2 for VERY long time, then resets to 25 - should be caught |
-| **2:01:11** | 7271 | punt | Clock ticks down to 2 then immediately resets to 25 - should be caught |
-| **2:06:52** | 7612 | punt | Clock goes 13→12→11→10 then resets to 25 - should be caught |
-
-### Field Goals
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **35:26** | 2126 | field goal | Regular FG, unknown reason for miss |
-| **1:00:50** | 3650 | field goal | Unknown reason for miss |
-
-### Extra Points
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **22:25** | 1345 | XP | Regular XP, unknown reason for miss |
-| **44:07** | 2647 | XP | Clock stays at 0 for a few seconds, resets to 25 briefly, then commercial |
-| **50:13** | 3013 | XP | Clock stays at 5 for a few seconds, resets to 25 for awhile |
-| **1:37:36** | 5856 | XP | Clock freezes at 14 seconds, then graphic cutaway before 25 reset shown |
-
-### Kickoffs (After Scores)
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **51:27** | 3087 | kickoff | Unknown reason for miss |
-
-### 2-Point Conversions
-| Video Time | Seconds | Type | Notes |
-|------------|---------|------|-------|
-| **1:12:49** | 4369 | 2pt | Clock was weird - ticking during play, went to 5, stayed there, then reset to 25. Short time at 25. |
-| **1:54:30** | 6870 | 2pt | Unknown reason for miss |
+## Progress Summary
+
+| Metric | v1 | v2 | Change |
+|--------|----|----|--------|
+| **Total Plays Detected** | 144 | 183 | +39 |
+| **Ground Truth Found** | 0/22 | 19/22 | +19 |
+| **Still Missing** | 22 | 3 | -19 |
 
 ---
 
-## Summary Statistics
+## v2 Status: Found Plays (19/22) ✅
+
+### Opening Kickoff ✅
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| ~5:00-6:00 | ~300-360 | kickoff | ✅ Found at 332.5s (special) |
+
+### Normal Plays ✅ (3/5 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **7:37** | 457 | normal | ✅ Found at 458.0s (special) |
+| **1:08:56** | 4136 | normal | ✅ Found at 4148.5s (timeout) - captured as special/timeout due to clock operator error |
+| **2:14:07** | 8047 | final play | ✅ Found at 8053.4s (normal) |
+
+### Punts ✅ (7/7 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **16:36** | 996 | punt | ✅ Found at 998.0s (special) |
+| **48:14** | 2894 | punt | ✅ Found at 2893.5s (special) |
+| **53:54** | 3234 | punt | ✅ Found at 3237.0s (special) |
+| **1:32:11** | 5531 | punt | ✅ Found at 5530.9s (special) |
+| **1:41:47** | 6107 | punt | ✅ Found at 6117.9s (special) |
+| **2:01:11** | 7271 | punt | ✅ Found at 7273.4s (special) |
+| **2:06:52** | 7612 | punt | ✅ Found at 7611.4s (special) |
+
+### Field Goals ✅ (2/2 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **35:26** | 2126 | field goal | ✅ Found at 2131.5s (special) |
+| **1:00:50** | 3650 | field goal | ✅ Found at 3655.5s (special) |
+
+### Extra Points (3/4 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **22:25** | 1345 | XP | ✅ Found at 1343.0s (special) |
+| **44:07** | 2647 | XP | ✅ Found at 2652.5s (special) |
+| **50:13** | 3013 | XP | ✅ Found at 3017.0s (special) |
+
+### Kickoffs (After Scores) ✅ (1/1 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **51:27** | 3087 | kickoff | ✅ Found at 3084.5s (normal) |
+
+### 2-Point Conversions ✅ (2/2 found)
+| Video Time | Seconds | Type | v2 Status |
+|------------|---------|------|-----------|
+| **1:12:49** | 4369 | 2pt | ✅ Found at 4374.9s (special) |
+| **1:54:30** | 6870 | 2pt | ✅ Found at 6869.9s (special) |
+
+---
+
+## v2 Status: Still Missing (3/22) ❌
+
+| Video Time | Seconds | Type | Issue | Nearest Plays |
+|------------|---------|------|-------|---------------|
+| **1:11:42** | 4302 | normal | Last play of half - end-of-half edge case | 4237.9s, 4374.9s (72s gap) |
+| **1:51:24** | 6684 | normal | Clock operator error - low clock detection rate in this area | 6654.4s, 6719.4s (65s gap) |
+| **1:37:36** | 5856 | XP | Clock freezes at 14, graphic cutaway before 25 reset shown | 5826.9s, 5904.9s (78s gap) |
+
+### Root Cause Analysis
+
+1. **4302s (Last play of half)**: End-of-half edge case where clock behavior doesn't follow normal patterns. The half ends without typical clock reset signals.
+
+2. **6684s (Clock operator error)**: Only 66% clock detection rate in the video overall. This area likely has poor clock readings, preventing the state machine from detecting the play start/end.
+
+3. **5856s (XP with graphic cutaway)**: Per manual notes: "Clock freezes at 14 seconds, then graphic cutaway before 25 reset shown". The 25 reset that triggers special play detection never appears on screen.
+
+---
+
+## Additional Issues (from v1) - Status
+
+### Special Play End Logic Issue ✅ FIXED
+Special plays now end at the **first** of: 10 seconds OR scorebug disappears.
+
+### FLAG Merge Duplication Issue ✅ FIXED
+FLAG events no longer duplicate the end of normal plays.
+
+### Special Play Clip Buffer Issue ✅ FIXED
+Different buffer timing now applied per play type:
+- Normal: 2.0s pre / 2.0s post
+- Special: 3.5s pre / 0s post
+- Flag: 1.0s pre / 0s post
+- Timeout: 0s / 0s
+
+---
+
+## v2 Improvements Summary
+
+Key fixes that improved detection from 144 → 183 plays:
 
-| Category | Count |
-|----------|-------|
-| **Total Missed Plays** | 22 |
-| **Missed Normal Plays** | 5 |
-| **Missed Punts** | 7 |
-| **Missed Field Goals** | 2 |
-| **Missed Extra Points** | 4 |
-| **Missed Kickoffs** | 2 |
-| **Missed 2PT Conversions** | 2 |
+1. **Clock freeze → 25 detection**: Detects plays where clock freezes then resets to 25 (punts, FGs, XPs)
+2. **Scorebug template_matched separation**: Fixed Oregon-specific scorebug detection issues
+3. **Special play tracking improvements**: Better handling of 40→25 transitions
+4. **Opening kickoff detection**: Now captures the first play of the game
 
 ---
 
-## Additional Issues Noted
-
-### Special Play End Logic Issue
-Special plays seem to always end after 10 seconds (`MAX_SPECIAL_PLAY_DURATION`), when they should end at the **first** of:
-- 10 seconds, OR
-- Scorebug disappears
-
-**Examples of special plays running too long** (timestamp = video time):
-- 42:00 (2520s)
-- 1:02:05 (3725s)
-- 1:16:28 (4588s)
-- 1:25:47 (5147s)
-- 1:56:06 (6966s)
-
-### FLAG Merge Duplication Issue
-When a FLAG event occurs at the end of a normal play:
-1. Normal play is captured
-2. FLAG event is also captured
-3. This causes duplication of the last few seconds of the play
-
-**Examples** (timestamp = video time):
-- 1:35:51 (5751s)
-- 1:43:01 (6181s)
-- 2:10:35 (7835s)
-
-### Special Play Clip Buffer Issue
-Special plays need a few-second buffer at the **start** (like normal plays), but should NOT have the same buffer at the **end**. Currently, clips apply symmetric padding.
+## Baseline Comparison
+
+| Category | v1 Missed | v2 Found | v2 Still Missing |
+|----------|-----------|----------|------------------|
+| Opening Kickoff | 1 | 1 | 0 |
+| Normal Plays | 5 | 3 | 2 |
+| Punts | 7 | 7 | 0 |
+| Field Goals | 2 | 2 | 0 |
+| Extra Points | 4 | 3 | 1 |
+| Kickoffs | 1 | 1 | 0 |
+| 2PT Conversions | 2 | 2 | 0 |
+| **TOTAL** | **22** | **19** | **3** |

docs/oregon_plan.md

@@ -4,9 +4,15 @@ This document outlines the issues identified from the OSU vs Oregon v1 baseline
 
 ## Baseline Reference
 - **Video**: OSU vs Oregon 01.01.25.mkv
-- **Baseline file**: `output/benchmarks/oregon_v1_baseline.json`
+- **V1 Baseline**: `output/benchmarks/oregon_v1_baseline.json` (144 plays, 22 missed)
+- **V2 Benchmark**: `output/benchmarks/oregon_v2_benchmark.json` (183 plays, 3 still missing)
 - **Ground truth**: `docs/oregon_ground_truth.md`
-- **V1 Detection**: 144 plays detected, ~22 plays missed
+
+### Progress Summary
+| Version | Plays Detected | Ground Truth Found | Improvement |
+|---------|----------------|-------------------|-------------|
+| V1 | 144 | 0/22 | - |
+| V2 | 183 | 19/22 | +39 plays, 86% GT coverage |
 
 ---
 
@@ -210,19 +216,38 @@ Updated functions:
 ### Problem
 Several normal plays were missed, often due to clock operator errors or unusual clock behavior:
 - 7:37: Clock reset to 25 at snap time
-- 1:08:56: Unknown
+- 1:08:56: Normal play classified as "special" (see investigation below)
 - 1:11:42: Last play of half, clock operator error
-- 1:51:24: Clock operator error
+- 1:51:24: Clock reading failure - low detection rate in this area
 - 2:14:07: Final play, clock resets to 40 then disappears
 
-### Proposed Fixes
+### Investigation: 1:08:56 (4138.5s) "Clock Operator Error" Cases
+
+**Finding**: The play at 4138.5s IS being captured, but as a "special" play (4138.5s - 4149.0s)
+instead of a "normal" play followed by a separate "timeout" event.
+
+**Behavior**:
+- Play starts at 4138.5s (clock reset to 40)
+- Clock stays at 40 for 9.5 seconds (clock operator didn't start countdown)
+- 40→25 transition at 4148.5s (timeout called)
+- SpecialPlayTracker creates: "special" play 4138.5s - 4149.0s (10.5s)
 
-#### Fix 5.1: Detect Reset-at-Snap Pattern
-When clock is counting down and suddenly jumps to 25 (not 40), this likely indicates:
-- Ball was snapped
-- Clock operator reset to next play's clock
+**Attempted Fix**: Record normal play before handing off to SpecialPlayTracker when
+time_at_40 >= threshold (tried 5s, 8s thresholds).
 
-Current logic may be ignoring this because it expects 40 first.
+**Issue with Fix**: Tennessee has similar cases (9.0s, 9.5s, 10.5s, 11.5s, 12.5s, 13.5s at 40)
+where the clock operator also didn't count down. Any threshold that catches Oregon's 9.5s case
+also catches Tennessee's cases, creating unwanted extra plays in Tennessee.
+
+**Decision**: Reverted fix to maintain Tennessee stability. The play IS captured (just as
+"special" type with slightly different buffer timing). This is acceptable given:
+- The footage is still included in the final output
+- Only buffer timing differs (special: 3.5s pre / 0s post vs normal: 2.0s / 2.0s)
+- Tennessee regression is more impactful than Oregon classification improvement
+
+**Status**: ACCEPTED AS-IS (play is captured, just classified as "special")
+
+### Proposed Fixes (Pending)
 
 #### Fix 5.2: Handle End-of-Half/Game Scenarios
 Add special handling for when:
@@ -230,6 +255,12 @@ Add special handling for when:
 - Then disappears (game/half ends)
 - This should still count as a play
 
+#### Fix 5.3: Handle Clock Reading Failures
+The play at 1:51:24 (6684s) was missed due to low clock detection rate in that area.
+Possible solutions:
+- Improve template matching robustness
+- Handle brief clock resets (1-2 seconds at 40) that may be missed between samples
+
 ### Investigation Steps
 1. Analyze clock readings around 7:37 (457s) to understand the reset-at-snap pattern
 2. Check if there's a common pattern in clock operator error scenarios
@@ -242,7 +273,7 @@ Add special handling for when:
 | Priority | Issue | Complexity | Impact | Status |
 |----------|-------|------------|--------|--------|
 | 1 | Issue 1: Missed Special Plays (Fix 1.1) | High | High - 17 plays missed | ✅ Done (+16 recovered) |
-| 2 | Issue 5: Missed Normal Plays | Medium | Medium - 5 plays missed | Pending (~4-6 still missed) |
+| 2 | Issue 5: Missed Normal Plays | Medium | Low - classification only | ⚠️ Accepted (plays captured as "special") |
 | 3 | Issue 3: FLAG Duplication | Low | Medium - visual quality | ✅ Done |
 | 4 | Issue 4: Clip Buffer | Low | Low - visual preference | ✅ Done |
 | 5 | Issue 2: Special End Logic | Medium | Low - tighter clips | ✅ Done |
@@ -260,8 +291,8 @@ Add special handling for when:
 5. Run regression test on Tennessee to ensure no regression
 
 ### Success Criteria
-- **Oregon**: ≥160 plays detected (vs 144 in v1)
-- **Tennessee**: 187-188 plays (no regression from v6 baseline)
+- **Oregon**: ≥160 plays detected (vs 144 in v1) → Current: ~180-184 plays ✓
+- **Tennessee**: 187-188 plays (no regression from v6 baseline) → Current: 188 plays ✓
 
 ---