feat(bidders): implement deletion of all barrier sizes associated with a bidder

app/controllers/bidders.py

@@ -469,42 +469,35 @@ def update_barrier_size_with_association(
         )
 
 
+
 @router.delete(
-    "/barrier-sizes/{id}",
+    "/barrier-sizes/by-bidder/{bidder_id}",
     status_code=status.HTTP_204_NO_CONTENT,
-    summary="Delete a barrier size",
-    response_description="Barrier size deleted successfully"
+    summary="Delete all barrier sizes associated with a bidder",
+    response_description="All barrier sizes and associations for the bidder deleted successfully"
 )
-def delete_barrier_size(id: int, db: Session = Depends(get_db)):
-    """Delete a barrier size and all its bidder associations"""
+def delete_barrier_sizes_by_bidder(bidder_id: int, db: Session = Depends(get_db)):
+    """
+    Delete all barrier sizes associated with a specific bidder.
+    
+    This implements the two-step SQL logic:
+    1. DELETE FROM BarrierSizes WHERE Id IN (SELECT BarrierSizeId FROM BiddersBarrierSizes WHERE BidderId = {bidder_id})
+    2. DELETE FROM BiddersBarrierSizes WHERE BidderId = {bidder_id}
+    
+    Parameters:
+    - bidder_id: The bidder ID to delete all barrier sizes for
+    """
     try:
-        logger.info(f"Deleting barrier size {id}")
-        
-        # Check if barrier size exists first
-        from app.db.repositories.barrier_size_repo import get_barrier_size
-        barrier_size = get_barrier_size(db, id)
-        if not barrier_size:
-            raise HTTPException(status_code=404, detail=f"Barrier size {id} not found")
+        logger.info(f"Deleting all barrier sizes for bidder {bidder_id}")
+        result = barrier_size_service.delete_all_by_bidder(db, bidder_id)
         
-        # Delete using the service method which handles associations properly
-        success = barrier_size_service.delete(db, id)
-        if not success:
-            raise HTTPException(
-                status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-                detail=f"Failed to delete barrier size {id}"
-            )
-            
-        logger.info(f"Successfully deleted barrier size {id}")
+        logger.info(f"Successfully deleted barrier sizes for bidder {bidder_id}: {result}")
         return None
-    except HTTPException:
-        raise
     except Exception as e:
-        logger.error(f"Error deleting barrier size {id}: {e}")
-        import traceback
-        traceback.print_exc()  # Print full traceback for debugging
+        logger.error(f"Error deleting barrier sizes for bidder {bidder_id}: {e}")
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to delete barrier size: {str(e)}"
+            detail="Failed to delete barrier sizes for bidder"
         )
 
 @router.delete(

app/services/barrier_size_service.py

@@ -144,6 +144,56 @@ def delete_by_bidder_and_barrier_id(db: Session, bidder_id: int, barrier_size_id
         db.rollback()
         raise
 
+def delete_all_by_bidder(db: Session, bidder_id: int):
+    """
+    Delete all barrier sizes associated with a specific bidder.
+    
+    Implements the two-step SQL logic:
+    1. DELETE FROM BarrierSizes WHERE Id IN (SELECT BarrierSizeId FROM BiddersBarrierSizes WHERE BidderId = {bidder_id})
+    2. DELETE FROM BiddersBarrierSizes WHERE BidderId = {bidder_id}
+    
+    Args:
+        db: Database session
+        bidder_id: The bidder ID
+    
+    Returns:
+        dict: Status of deletion operations
+    """
+    try:
+        bidders_barrier_repo = BiddersBarrierSizesRepository(db)
+        
+        # Step 1: Get all barrier size IDs associated with this bidder
+        associations = bidders_barrier_repo.get_by_bidder_id(bidder_id)
+        barrier_size_ids = [assoc.BarrierSizeId for assoc in associations]
+        
+        logger.info(f"Found {len(barrier_size_ids)} barrier sizes for bidder {bidder_id}: {barrier_size_ids}")
+        
+        # Step 2: Delete all barrier sizes that are associated with this bidder
+        barrier_sizes_deleted = 0
+        for barrier_size_id in barrier_size_ids:
+            success = delete_barrier_size(db, barrier_size_id)
+            if success:
+                barrier_sizes_deleted += 1
+        
+        # Step 3: Delete all associations for this bidder
+        associations_deleted = bidders_barrier_repo.delete_by_bidder_id(bidder_id)
+        
+        result = {
+            "bidder_id": bidder_id,
+            "barrier_sizes_deleted": barrier_sizes_deleted,
+            "barrier_size_ids": barrier_size_ids,
+            "associations_deleted": associations_deleted,
+            "message": f"Deleted {barrier_sizes_deleted} barrier sizes and {associations_deleted} associations for bidder {bidder_id}"
+        }
+        
+        logger.info(f"Delete all by bidder operation completed: {result}")
+        return result
+        
+    except Exception as e:
+        logger.error(f"Error deleting all barrier sizes for bidder {bidder_id}: {e}")
+        db.rollback()
+        raise
+
 def create_barrier_with_association(
     db: Session,
     height: Optional[float] = None,