Update app.py

app.py

@@ -516,123 +516,125 @@ def main():
 
     # Edit Tasks
     elif menu == "✏️ Edit Tasks":
-        tasks = get_tasks()
-        if tasks:
-            task_options = [f"{t['task']} ({t['project']})" for t in tasks]
-            selected = st.selectbox("Select Task", task_options)
-            task = next(t for t in tasks if f"{t['task']} ({t['project']})" == selected)
+    tasks = get_tasks()
+    if tasks:
+        task_options = [f"{t['task']} ({t['project']})" for t in tasks]
+        selected = st.selectbox("Select Task", task_options)
+        task = next(t for t in tasks if f"{t['task']} ({t['project']})" == selected)
+        
+        with st.form(key="edit_form"):
+            col1, col2 = st.columns(2)
             
-            with st.form(key="edit_form"):
-                col1, col2 = st.columns(2)
-                
-                # Left Column
-                with col1:
-                    new_task = st.text_area("Description", value=task['task'], height=100)
-                    new_type = st.selectbox(
-                        "Type", 
-                        ["Design", "Procurement", "Construction", "Testing", "Other"],
-                        index=["Design", "Procurement", "Construction", "Testing", "Other"].index(task['type'])
-                    )
-                
-                # Right Column
-                with col2:
-                    projects = [p.id for p in db.collection("projects").stream()] + ["Add New Project"]
-                    new_project = st.selectbox(
-                        "Project", 
-                        projects, 
-                        index=projects.index(task['project']) if task['project'] in projects else 0
-                    )
-                    if new_project == "Add New Project":
-                        new_project = st.text_input("New Project Name")
-                    
-                    new_status = st.selectbox(
-                        "Status", 
-                        ["Pending", "In Progress", "Completed"], 
-                        index=["Pending", "In Progress", "Completed"].index(task['status'])
-                    )
-                    new_date = st.date_input(
-                        "Due Date", 
-                        value=datetime.strptime(task['date'], "%Y-%m-%d").date()
-                    )
-                
-                # Attachment Management
-                st.subheader("📎 Attachments")
-                if task['attachments']:
-                    for att in task['attachments']:
-                        col1, col2 = st.columns([4,1])
-                        with col1:
-                            st.markdown(f"""
-                            <div style="margin:0.5rem 0; padding:0.5rem; border-radius:5px; background:#f0f2f6;">
-                                <div style="display:flex; align-items:center; gap:1rem;">
-                                    <span style="flex:1;">📄 {att['name']}</span>
-                                    <a href="{att['url']}" target="_blank" style="text-decoration:none;">
-                                        🔗 View
-                                    </a>
-                                </div>
-                                <small style="color:#666;">{att['type']} | {att['size'] // 1024} KB</small>
-                            </div>
-                            """, unsafe_allow_html=True)
-                        with col2:
-                            if st.button("🗑️", key=f"del_att_{att['name']}"):
-                                # Remove attachment from task
-                                updated_attachments = [a for a in task['attachments'] if a['name'] != att['name']]
-                                db.collection("tasks").document(task['id']).update({
-                                    "attachments": updated_attachments
-                                })
-                                st.rerun()
-                
-                # New Attachments
-                new_attachments = st.file_uploader(
-                    "Add New Attachments",
-                    type=["pdf", "docx", "xlsx", "png", "jpg", "jpeg"],
-                    accept_multiple_files=True,
-                    help="Upload new files (max 10MB each)"
+            # Left Column
+            with col1:
+                new_task = st.text_area("Description", value=task['task'], height=100)
+                new_type = st.selectbox(
+                    "Type", 
+                    ["Design", "Procurement", "Construction", "Testing", "Other"],
+                    index=["Design", "Procurement", "Construction", "Testing", "Other"].index(task['type'])
+                )
+            
+            # Right Column
+            with col2:
+                projects = [p.id for p in db.collection("projects").stream()] + ["Add New Project"]
+                new_project = st.selectbox(
+                    "Project", 
+                    projects, 
+                    index=projects.index(task['project']) if task['project'] in projects else 0
                 )
+                if new_project == "Add New Project":
+                    new_project = st.text_input("New Project Name")
                 
-                # Submit Button
-                if st.form_submit_button("💾 Save Changes"):
-                    try:
-                        # Process new attachments
-                        attachments = task.get('attachments', [])
-                        if new_attachments:
-                            for file in new_attachments:
-                                if file.size > 10 * 1024 * 1024:  # 10MB limit
-                                    st.error(f"❌ File {file.name} exceeds 10MB limit")
-                                    st.stop()
-                                    
-                                result = cloudinary.uploader.upload(
-                                    file,
-                                    folder=f"attachments/{st.session_state.user_uid}/",
-                                    resource_type="auto"
-                                )
+                new_status = st.selectbox(
+                    "Status", 
+                    ["Pending", "In Progress", "Completed"], 
+                    index=["Pending", "In Progress", "Completed"].index(task['status'])
+                )
+                new_date = st.date_input(
+                    "Due Date", 
+                    value=datetime.strptime(task['date'], "%Y-%m-%d").date()
+                )
+            
+            # Attachment Management
+            st.subheader("📎 Attachments")
+            attachments = task.get('attachments', [])  # Safely get attachments
+            if attachments:
+                for att in attachments:
+                    col1, col2 = st.columns([4,1])
+                    with col1:
+                        st.markdown(f"""
+                        <div style="margin:0.5rem 0; padding:0.5rem; border-radius:5px; background:#f0f2f6;">
+                            <div style="display:flex; align-items:center; gap:1rem;">
+                                <span style="flex:1;">📄 {att['name']}</span>
+                                <a href="{att['url']}" target="_blank" style="text-decoration:none;">
+                                    🔗 View
+                                </a>
+                            </div>
+                            <small style="color:#666;">{att['type']} | {att['size'] // 1024} KB</small>
+                        </div>
+                        """, unsafe_allow_html=True)
+                    with col2:
+                        if st.button("🗑️", key=f"del_att_{att['name']}"):
+                            # Remove attachment from task
+                            updated_attachments = [a for a in attachments if a['name'] != att['name']]
+                            db.collection("tasks").document(task['id']).update({
+                                "attachments": updated_attachments
+                            })
+                            st.rerun()
+            
+            # New Attachments
+            new_attachments = st.file_uploader(
+                "Add New Attachments",
+                type=["pdf", "docx", "xlsx", "png", "jpg", "jpeg"],
+                accept_multiple_files=True,
+                help="Upload new files (max 10MB each)"
+            )
+            
+            # Submit Button
+            submitted = st.form_submit_button("💾 Save Changes")
+            
+            if submitted:
+                try:
+                    # Process new attachments
+                    if new_attachments:
+                        for file in new_attachments:
+                            if file.size > 10 * 1024 * 1024:  # 10MB limit
+                                st.error(f"❌ File {file.name} exceeds 10MB limit")
+                                st.stop()
                                 
-                                attachments.append({
-                                    "name": file.name,
-                                    "url": result['secure_url'],
-                                    "type": file.type,
-                                    "size": file.size
-                                })
-                        
-                        # Update task
-                        db.collection("tasks").document(task['id']).update({
-                            "task": new_task,
-                            "type": new_type,
-                            "project": new_project,
-                            "status": new_status,
-                            "date": str(new_date),
-                            "attachments": attachments,
-                            "updated_at": datetime.now().strftime("%Y-%m-%d %H:%M:%S")
-                        })
-                        
-                        st.success("✅ Task updated successfully!")
-                        st.rerun()
+                            result = cloudinary.uploader.upload(
+                                file,
+                                folder=f"attachments/{st.session_state.user_uid}/",
+                                resource_type="auto"
+                            )
+                            
+                            attachments.append({
+                                "name": file.name,
+                                "url": result['secure_url'],
+                                "type": file.type,
+                                "size": file.size
+                            })
                     
-                    except cloudinary.exceptions.Error as e:
-                        st.error(f"❌ Cloudinary upload failed: {str(e)}")
-                    except Exception as e:
-                        st.error(f"❌ Update failed: {str(e)}")
-        else:
-            st.info("📭 No tasks to edit")
+                    # Update task
+                    db.collection("tasks").document(task['id']).update({
+                        "task": new_task,
+                        "type": new_type,
+                        "project": new_project,
+                        "status": new_status,
+                        "date": str(new_date),
+                        "attachments": attachments,
+                        "updated_at": datetime.now().strftime("%Y-%m-%d %H:%M:%S")
+                    })
+                    
+                    st.success("✅ Task updated successfully!")
+                    st.rerun()
+                
+                except cloudinary.exceptions.Error as e:
+                    st.error(f"❌ Cloudinary upload failed: {str(e)}")
+                except Exception as e:
+                    st.error(f"❌ Update failed: {str(e)}")
+    else:
+        st.info("📭 No tasks to edit")
 
     # Project Management (Admin Only)
     elif menu == "🏗️ Project Management" and st.session_state.is_admin: