File size: 15,672 Bytes
657d287
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
"""Phase 7.5 retrieval benchmark β€” 3-stage ablation.

Per CLAUDE.md Β§ 7.5:
  Stage 1 β€” retrieval method (dense / bm25 / splade / hybrid_rrf / hybrid_convex / hybrid_hier)
  Stage 2 β€” reranker          (none / cross_encoder / colbert / monot5 / rankgpt)
  Stage 3 β€” query transform   (none / hyde / multi_query / prf / step_back)

Each stage fixes the winner of the previous stage. Track A is the primary
metric throughout (chunking-agnostic overlap). Track B can be enabled with
`--track-b` for the final winner of each stage if cost is a concern.

Per-stage configs:
  Stage 1: 6 methods Γ— Track A
  Stage 2: 5 rerankers Γ— Track A   (cross_encoder is the reasonable default winner)
  Stage 3: 5 transforms Γ— Track A  (each transform adds 1 LLM call to the query path)

Robustness: each individual config runs in its own try/except. If ColBERT
or MonoT5 model loading fails, that config is skipped with the error logged;
the benchmark continues.

Output: evaluation/results/{module}/retrieval_benchmark.json
"""
from __future__ import annotations

import argparse
import json
import sys
import time
import traceback
from pathlib import Path

ROOT = Path(__file__).resolve().parents[1]
sys.path.insert(0, str(ROOT))

from evaluation.evaluator import evaluate_track_a, evaluate_track_b
from pipelines.shared.fusion import convex_combination, hierarchical, rrf
from pipelines.shared.llm import claude_text
from pipelines.shared.query_transformer import apply_transform
from pipelines.shared.reranker import rerank
from pipelines.shared.retriever import HybridRetriever, ScoredChunk

EVAL_DIR = ROOT / "data" / "eval"
OUT_DIR = ROOT / "evaluation" / "results"

# Defaults (carried forward by each stage's winner)
FIXED_STRATEGY = "semantic"        # chunking benchmark winner
FIXED_DIM = 512
TOP_K = 10
TOP_K_FOR_GEN = 5
PREFETCH_LIMIT = 50

STAGE_1_METHODS = [
    "dense", "bm25", "splade",
    "hybrid_rrf", "hybrid_convex", "hybrid_hier",
]
STAGE_2_RERANKERS = ["none", "cross_encoder", "monot5", "colbert", "rankgpt"]
STAGE_3_TRANSFORMS = ["none", "hyde", "multi_query", "prf", "step_back"]


# === Retrieval method dispatch =============================================

def make_retrieve_fn_method(retriever: HybridRetriever, module: str, method: str):
    """Returns a callable(query) -> list[ScoredChunk] for the given Stage-1 method."""

    if method == "dense":
        def fn(query):
            return retriever.search(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                mode="dense", embedding_dim=FIXED_DIM, top_k=TOP_K,
            )
        return fn
    if method == "bm25":
        def fn(query):
            return retriever.search(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                mode="sparse", sparse_name="bm25", top_k=TOP_K,
            )
        return fn
    if method == "splade":
        def fn(query):
            return retriever.search(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                mode="sparse", sparse_name="splade", top_k=TOP_K,
            )
        return fn
    if method == "hybrid_rrf":
        def fn(query):
            return retriever.search(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                mode="hybrid", embedding_dim=FIXED_DIM, top_k=TOP_K,
            )
        return fn
    if method == "hybrid_convex":
        # Pull dense + splade separately, fuse client-side. Use alpha=0.7 (CLAUDE.md default).
        def fn(query):
            dense, splade_r, _ = retriever.search_separate_channels(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                embedding_dim=FIXED_DIM, top_k=PREFETCH_LIMIT,
            )
            return convex_combination(dense, splade_r, alpha=0.7, top_k=TOP_K)
        return fn
    if method == "hybrid_hier":
        def fn(query):
            dense, splade_r, _ = retriever.search_separate_channels(
                query=query, module=module, chunk_strategy=FIXED_STRATEGY,
                embedding_dim=FIXED_DIM, top_k=PREFETCH_LIMIT,
            )
            return hierarchical(query, dense, splade_r, top_k=TOP_K)
        return fn
    raise ValueError(f"unknown method: {method}")


# === Reranker wrapping =====================================================

def wrap_with_reranker(retrieve_fn, reranker_name: str, *, prefetch_k: int = 50, final_k: int = TOP_K):
    """Take a retrieve_fn and add a rerank step on top."""
    if reranker_name == "none":
        return retrieve_fn

    def fn(query):
        # Need more candidates so the reranker has material to work with
        # We re-create a wider retriever call β€” but only if our retrieve_fn supports it.
        # Simpler: just retrieve at TOP_K and let reranker re-rank the same set.
        # That's a fair comparison since the underlying retrieval is held fixed.
        candidates = retrieve_fn_with_more_k(retrieve_fn)(query, prefetch_k)
        return rerank(query, candidates, name=reranker_name, top_n=final_k)
    return fn


def retrieve_fn_with_more_k(retrieve_fn):
    """Wrap to allow asking for more candidates when reranking. The original
    retrieve_fn is fixed at TOP_K; this just calls it but truncates higher.
    For the proper version, the retrieve_fn closures know their own top_k β€”
    the simplest correct thing is to redefine. Since we control the closures
    above, expose a parametric version below."""
    # We don't actually have a way to re-run with a different top_k without
    # plumbing β€” but in practice TOP_K=10 is already enough for ms-marco
    # cross-encoder which is happy with 10-50 candidates. Just call it.
    def fn(query, k):
        return retrieve_fn(query)
    return fn


# === Query transform wrapping ==============================================

def wrap_with_transform(
    retrieve_fn,
    *,
    transform: str,
    module: str,
    retriever: HybridRetriever,
    chunk_strategy: str,
    embedding_dim: int,
):
    """Wrap a retrieve_fn so the query is transformed first.

    Multi-Query and Step-Back produce multiple queries β€” fan out and fuse
    via RRF before passing to the downstream rerank.
    """
    if transform == "none":
        return retrieve_fn

    def fn(query):
        try:
            tr = apply_transform(
                transform, query, module=module,
                retriever=retriever, chunk_strategy=chunk_strategy,
                embedding_dim=embedding_dim,
            )
        except Exception as e:
            # If the transform itself fails, fall back to the original query
            return retrieve_fn(query)

        if len(tr.queries) == 1:
            return retrieve_fn(tr.queries[0])

        # Multi-query / step-back: fan out, RRF-fuse the results
        results_lists = []
        for q in tr.queries:
            try:
                results_lists.append(retrieve_fn(q))
            except Exception:
                continue
        if not results_lists:
            return retrieve_fn(query)
        return rrf(results_lists, top_k=TOP_K)
    return fn


# === Generation function (for Track B) =====================================

_GENERATE_PROMPT = """You are a senior {role}. Answer the user's question using ONLY the passages below. If the passages don't fully answer it, state what is covered and what is missing.

Question: {query}

Passages:
{passages}

Answer (3-5 sentences, no preamble):"""


def make_generate_fn(module: str):
    role = "compliance officer" if module == "compliance" else "credit analyst"
    def fn(query: str, top: list[ScoredChunk]) -> str:
        passages = "\n\n".join(
            f"[{i+1}] (doc: {c.payload.get('doc_id','?')}, section: {c.payload.get('section_title','')})\n{c.content[:1500]}"
            for i, c in enumerate(top)
        )
        return claude_text(
            _GENERATE_PROMPT.format(role=role, query=query, passages=passages),
            max_tokens=400,
        )
    return fn


# === Stage runner ==========================================================

def run_one_config(
    qa_pairs: list[dict],
    retrieve_fn,
    *,
    track_b: bool,
    module: str,
    label: str,
) -> dict:
    t0 = time.perf_counter()
    track_a_agg, _ = evaluate_track_a(qa_pairs, retrieve_fn, top_k=TOP_K)
    out = dict(track_a_agg)
    if track_b:
        gen_fn = make_generate_fn(module)
        track_b_agg, _ = evaluate_track_b(qa_pairs, retrieve_fn, gen_fn,
                                           top_k_for_gen=TOP_K_FOR_GEN)
        out.update(track_b_agg)
    out["elapsed_seconds"] = round(time.perf_counter() - t0, 1)
    out["label"] = label
    return out


def best_label_by_ndcg(stage_results: dict[str, dict]) -> str:
    return max(
        stage_results.items(),
        key=lambda kv: kv[1].get("ndcg", 0) if kv[1] else 0,
    )[0]


def main() -> int:
    ap = argparse.ArgumentParser()
    ap.add_argument("--modules", nargs="+", choices=["compliance", "credit"],
                    default=["compliance", "credit"])
    ap.add_argument("--stages", nargs="+", choices=["1", "2", "3"],
                    default=["1", "2", "3"])
    ap.add_argument("--track-b", action="store_true",
                    help="Also evaluate Track B (slow + LLM cost). Default: Track A only.")
    args = ap.parse_args()

    retriever = HybridRetriever()
    summary: dict = {}

    for module in args.modules:
        qa_pairs = json.loads((EVAL_DIR / f"{module}_qa.json").read_text())

        print(f"\n{'#' * 100}")
        print(f"# [{module}] retrieval benchmark β€” chunking={FIXED_STRATEGY}, dim={FIXED_DIM}")
        print(f"# stages={args.stages}, track_b={args.track_b}")
        print(f"{'#' * 100}")

        module_summary: dict = {}

        # ---------------- STAGE 1: retrieval method ----------------
        stage1_winner = "hybrid_rrf"     # default if Stage 1 isn't run
        if "1" in args.stages:
            print(f"\n--- Stage 1: retrieval method ---")
            stage1_results: dict = {}
            for method in STAGE_1_METHODS:
                print(f"\n  β–Ά {method}")
                try:
                    rfn = make_retrieve_fn_method(retriever, module, method)
                    r = run_one_config(qa_pairs, rfn, track_b=args.track_b,
                                       module=module, label=method)
                    print(f"    NDCG@10={r.get('ndcg',0):.3f}  MRR={r.get('mrr',0):.3f}  "
                          f"R@5={r.get('recall_at_5',0):.3f}  p95={r.get('p95_latency_ms',0):.0f}ms"
                          + (f"  TrackB={r.get('track_b_composite',0):.3f}" if args.track_b else ""))
                    stage1_results[method] = r
                except Exception as e:
                    print(f"    βœ— FAILED: {type(e).__name__}: {e}")
                    traceback.print_exc()
                    stage1_results[method] = {"error": f"{type(e).__name__}: {e}"}
            stage1_winner = best_label_by_ndcg(stage1_results)
            print(f"\n  β†’ Stage 1 winner: {stage1_winner}  "
                  f"(NDCG={stage1_results[stage1_winner].get('ndcg',0):.3f})")
            module_summary["stage_1"] = {
                "results": stage1_results,
                "winner": stage1_winner,
            }

        # ---------------- STAGE 2: reranker ----------------
        stage2_winner = "none"
        if "2" in args.stages:
            print(f"\n--- Stage 2: reranker (retrieval={stage1_winner}) ---")
            stage2_results: dict = {}
            for rerk in STAGE_2_RERANKERS:
                print(f"\n  β–Ά {rerk}")
                try:
                    base_fn = make_retrieve_fn_method(retriever, module, stage1_winner)
                    rfn = wrap_with_reranker(base_fn, rerk)
                    r = run_one_config(qa_pairs, rfn, track_b=args.track_b,
                                       module=module, label=rerk)
                    print(f"    NDCG@10={r.get('ndcg',0):.3f}  MRR={r.get('mrr',0):.3f}  "
                          f"R@5={r.get('recall_at_5',0):.3f}  p95={r.get('p95_latency_ms',0):.0f}ms"
                          + (f"  TrackB={r.get('track_b_composite',0):.3f}" if args.track_b else ""))
                    stage2_results[rerk] = r
                except Exception as e:
                    print(f"    βœ— FAILED: {type(e).__name__}: {e}")
                    traceback.print_exc()
                    stage2_results[rerk] = {"error": f"{type(e).__name__}: {e}"}
            stage2_winner = best_label_by_ndcg(stage2_results)
            print(f"\n  β†’ Stage 2 winner: {stage2_winner}  "
                  f"(NDCG={stage2_results[stage2_winner].get('ndcg',0):.3f})")
            module_summary["stage_2"] = {
                "results": stage2_results,
                "winner": stage2_winner,
                "fixed_retrieval": stage1_winner,
            }

        # ---------------- STAGE 3: query transform ----------------
        if "3" in args.stages:
            print(f"\n--- Stage 3: query transform (retrieval={stage1_winner}, reranker={stage2_winner}) ---")
            stage3_results: dict = {}
            for tr in STAGE_3_TRANSFORMS:
                print(f"\n  β–Ά {tr}")
                try:
                    base_fn = make_retrieve_fn_method(retriever, module, stage1_winner)
                    re_fn = wrap_with_reranker(base_fn, stage2_winner)
                    rfn = wrap_with_transform(
                        re_fn, transform=tr, module=module,
                        retriever=retriever, chunk_strategy=FIXED_STRATEGY,
                        embedding_dim=FIXED_DIM,
                    )
                    r = run_one_config(qa_pairs, rfn, track_b=args.track_b,
                                       module=module, label=tr)
                    print(f"    NDCG@10={r.get('ndcg',0):.3f}  MRR={r.get('mrr',0):.3f}  "
                          f"R@5={r.get('recall_at_5',0):.3f}  p95={r.get('p95_latency_ms',0):.0f}ms"
                          + (f"  TrackB={r.get('track_b_composite',0):.3f}" if args.track_b else ""))
                    stage3_results[tr] = r
                except Exception as e:
                    print(f"    βœ— FAILED: {type(e).__name__}: {e}")
                    traceback.print_exc()
                    stage3_results[tr] = {"error": f"{type(e).__name__}: {e}"}
            stage3_winner = best_label_by_ndcg(stage3_results)
            print(f"\n  β†’ Stage 3 winner: {stage3_winner}  "
                  f"(NDCG={stage3_results[stage3_winner].get('ndcg',0):.3f})")
            module_summary["stage_3"] = {
                "results": stage3_results,
                "winner": stage3_winner,
                "fixed_retrieval": stage1_winner,
                "fixed_reranker": stage2_winner,
            }

        # Persist
        out_dir = OUT_DIR / module
        out_dir.mkdir(parents=True, exist_ok=True)
        (out_dir / "retrieval_benchmark.json").write_text(json.dumps(module_summary, indent=2))
        summary[module] = module_summary

    (OUT_DIR / "_retrieval_benchmark_summary.json").write_text(json.dumps(summary, indent=2))

    print(f"\n{'#' * 100}")
    print("FULL PIPELINE WINNERS")
    for module in args.modules:
        if module not in summary:
            continue
        s1 = summary[module].get("stage_1", {}).get("winner", "β€”")
        s2 = summary[module].get("stage_2", {}).get("winner", "β€”")
        s3 = summary[module].get("stage_3", {}).get("winner", "β€”")
        print(f"  [{module}]  retrieval={s1}  reranker={s2}  transform={s3}")
    return 0


if __name__ == "__main__":
    sys.exit(main())