Fix visibility after notebook creation and push

app.py

@@ -6,8 +6,6 @@ from huggingface_hub import HfApi
 
 """
 TODOs:
-- Show auth and push button only after notebook creation
-- Improve the link to the result notebook
 - Handle erros
 - Add more commands to the notebook
 - Parametrize the commands
@@ -28,23 +26,22 @@ def create_notebook_file(cell_commands, notebook_name="generated_notebook.ipynb"
 
 
 def push_notebook(file_path, dataset_id, token):
+    notebook_name = "dataset_analysis.ipynb"
     api = HfApi(token=token)
     api.upload_file(
         path_or_fileobj=file_path,
-        path_in_repo="dataset_analysis.ipynb",
+        path_in_repo=notebook_name,
         repo_id=dataset_id,
         repo_type="dataset",
     )
-    # TODO: Handle permission error
     print("Notebook uploaded to Huggingface Hub.")
-    link = (
-        f"https://huggingface.co/datasets/{dataset_id}/blob/main/dataset_analyst.ipynb"
-    )
-    return f'<a target="_blank" href="{link}"  style="color: var(--link-text-color); text-decoration: underline;text-decoration-style: dotted;">See notebook</a>'
+    link = f"https://huggingface.co/datasets/{dataset_id}/blob/main/{notebook_name}"
+    html = f'<a target="_blank" href="{link}" style="color: var(--link-text-color); text-decoration: underline; text-decoration-style: dotted;">See notebook</a>'
+
+    return gr.HTML(value=html, visible=True)
 
 
 def generate_notebook(dataset_id):
-    # TODO: Get first config and split? or generate a dataframe per each split maybe?
     commands = [
         "!pip install pandas",
         "import pandas as pd",
@@ -53,8 +50,7 @@ def generate_notebook(dataset_id):
     ]
     notebook_name = f"{dataset_id.replace('/', '-')}.ipynb"
     create_notebook_file(commands, notebook_name=notebook_name)
-    print("Notebook uploaded to Huggingface Hub.")
-    return notebook_name
+    return gr.File(value=notebook_name, visible=True), gr.Row.update(visible=True)
 
 
 with gr.Blocks() as demo:
@@ -75,49 +71,53 @@ with gr.Blocks() as demo:
           src="https://huggingface.co/datasets/{name}/embed/viewer/default/train"
           frameborder="0"
           width="100%"
-          height="600px"
+          height="350px"
         ></iframe>
-            """
+        """
         return gr.HTML(value=html_code)
 
-    generate_btn = gr.Button("Generate notebook", visible=True)
-
-    download_link = gr.File(label="Download notebook")
-    generate_btn.click(
-        generate_notebook, inputs=[dataset_name], outputs=[download_link]
-    )
-    with gr.Row() as auth_page:
+    generate_btn = gr.Button("Generate notebook")
+    download_link = gr.File(label="Download notebook", visible=False)
+    with gr.Row(visible=False) as auth_page:
         with gr.Column():
             auth_title = gr.Markdown(
-                "Enter your token ([settings](https://huggingface.co/settings/tokens)):"
+                "Want to push to hub? Enter your token ([settings](https://huggingface.co/settings/tokens)):"
             )
             token_box = gr.Textbox(
                 "", label="token", placeholder="hf_xxx", type="password"
             )
             auth_error = gr.Markdown("", visible=False)
 
+    push_btn = gr.Button("Push notebook to hub", visible=False)
+    output_lbl = gr.HTML(value="", visible=False)
+
+    generate_btn.click(
+        generate_notebook,
+        inputs=[dataset_name],
+        outputs=[download_link, auth_page],
+    )
+
     def auth(token):
         if not token:
             return {
                 auth_error: gr.Markdown(value="", visible=False),
-                push_btn: gr.Row(visible=False),
+                push_btn: gr.Button(visible=False),
             }
         return {
             auth_error: gr.Markdown(value="", visible=False),
-            push_btn: gr.Row(visible=True),
+            push_btn: gr.Button("Push notebook to hub", visible=True),
         }
 
-    push_btn = gr.Button("Push notebook to hub", visible=False)
     token_box.change(
         auth,
         inputs=token_box,
         outputs=[auth_error, push_btn],
     )
-    output_lbl = gr.HTML(value="")
 
     push_btn.click(
         push_notebook,
         inputs=[download_link, dataset_name, token_box],
-        outputs=[output_lbl],
+        outputs=output_lbl,
     )
+
 demo.launch()