atakan Claude Sonnet 5 commited on
Commit
96a6888
·
1 Parent(s): dfe7123

fix: Stop the PyTorch backend from using pure greedy decoding

Browse files

Live-tested against the deployed bf16 model: greedy decoding (do_sample=
False) reproducibly derived the wrong closed-loop coefficients for a plain
zeta=0.6/wn=1.4 step response -- 2.56/2.1952 instead of the correct
1.68/1.96, identically in 3/3 runs, plus mislabeled the result "critically
damped" (that's zeta=1, not 0.6). Switched to temperature=0.2 sampling,
matching what the GGUF and MLX backends already use.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Files changed (1) hide show
  1. controlai_agent/orchestrator.py +8 -2
controlai_agent/orchestrator.py CHANGED
@@ -735,8 +735,14 @@ class ControlAIAgent:
735
  outputs = self.model.generate(
736
  **inputs,
737
  max_new_tokens=max_tokens,
738
- do_sample=False,
739
- temperature=None,
 
 
 
 
 
 
740
  top_p=None,
741
  top_k=None,
742
  repetition_penalty=REPETITION_PENALTY,
 
735
  outputs = self.model.generate(
736
  **inputs,
737
  max_new_tokens=max_tokens,
738
+ # Pure greedy (do_sample=False) reproducibly derived the
739
+ # WRONG closed-loop coefficients for a plain zeta/wn step
740
+ # response on this exact model (2.56/2.1952 instead of the
741
+ # correct 1.68/1.96, in 3/3 identical runs on deployed
742
+ # bf16) -- low-temperature sampling, matching the GGUF/MLX
743
+ # backends, is the fix being tested for that failure.
744
+ do_sample=True,
745
+ temperature=0.2,
746
  top_p=None,
747
  top_k=None,
748
  repetition_penalty=REPETITION_PENALTY,