Update app.py

app.py

@@ -30,7 +30,7 @@ class QuizGenerator:
         prompt = self._create_prompt(text, num_questions)
         
         try:
-            # API call with simplified parameters for llama-3.2-3b-preview
+            # API call with simplified parameters
             response = self.client.chat.completions.create(
                 messages=[
                     {
@@ -43,14 +43,11 @@ class QuizGenerator:
                     }
                 ],
                 model="llama-3.2-3b-preview",
-                temperature=0.1,  # Very low temperature for consistent output
+                temperature=0.1,
                 max_tokens=1024
             )
             
             # Extract content safely
-            if not response or not hasattr(response.choices[0], 'message'):
-                raise ValueError("Invalid API response structure")
-            
             content = response.choices[0].message.content
             if not content:
                 raise ValueError("Empty response content")
@@ -67,12 +64,12 @@ class QuizGenerator:
         except Exception as e:
             print(f"Error in generate_questions: {str(e)}")
             if 'response' in locals():
-                print("Response content:", getattr(response.choices[0], 'message', {}).content if hasattr(response, 'choices') else None)
+                print("Response content:", content if 'content' in locals() else None)
             raise QuizGenerationError(f"Failed to generate questions: {str(e)}")
     
     def _create_prompt(self, text: str, num_questions: int) -> str:
         """Create a simple, clear prompt optimized for llama-3.2-3b-preview"""
-        return f"""Create {num_questions} multiple choice questions about this text. Use this exact JSON format and nothing else:
+        return f"""Create {num_questions} multiple choice questions about this text. Return only the JSON array in this exact format:
 [
   {{
     "question": "Write the question here?",
@@ -91,7 +88,6 @@ Rules:
 2. Each question must have exactly 4 options
 3. correct_answer must be 0, 1, 2, or 3
 4. No explanations or additional text
-5. Keep options short and clear
 
 Text to use:
 {text.strip()}"""
@@ -102,7 +98,7 @@ Text to use:
             # Clean up the response text
             cleaned = response_text.strip()
             
-            # Remove any markdown or additional text
+            # Remove any markdown formatting
             cleaned = cleaned.replace('```json', '').replace('```', '').strip()
             
             # Find the JSON array
@@ -114,27 +110,35 @@ Text to use:
             
             json_str = cleaned[start:end]
             
-            # Basic JSON structure validation before parsing
-            if not (json_str.startswith('[') and json_str.endswith(']')):
-                raise ValueError("Invalid JSON structure")
+            # Remove any trailing commas before closing brackets
+            json_str = re.sub(r',(\s*})', r'\1', json_str)
+            json_str = re.sub(r',(\s*])', r'\1', json_str)
             
+            # Try to parse the cleaned JSON
             try:
-                questions = json.loads(json_str)
-            except json.JSONDecodeError as e:
-                # Try to fix common JSON formatting issues
-                fixed_json = json_str.replace('}\n{', '},{')  # Fix line breaks between objects
-                fixed_json = fixed_json.replace(',]', ']')    # Fix trailing commas
-                questions = json.loads(fixed_json)
-            
-            if not isinstance(questions, list):
-                raise ValueError("Parsed JSON is not a list")
-            
-            return questions
-            
+                return json.loads(json_str)
+            except json.JSONDecodeError:
+                # If that fails, try using ast.literal_eval as a fallback
+                import ast
+                return ast.literal_eval(json_str)
+                
         except Exception as e:
             print(f"Parse error details: {str(e)}")
             print(f"Attempted to parse: {response_text}")
-            raise
+            
+            # Last resort: try to fix the JSON manually
+            try:
+                # Remove any trailing commas and fix newlines
+                fixed = re.sub(r',(\s*[}\]])', r'\1', response_text)
+                fixed = fixed.replace('}\n{', '},{')
+                fixed = fixed.strip()
+                if not fixed.startswith('['):
+                    fixed = '[' + fixed
+                if not fixed.endswith(']'):
+                    fixed = fixed + ']'
+                return json.loads(fixed)
+            except:
+                raise ValueError(f"Failed to parse response: {str(e)}")
     
     def _validate_questions(self, questions: List[Dict], num_questions: int) -> List[Question]:
         """Validate questions with strict checking"""
@@ -175,6 +179,13 @@ Text to use:
         
         return validated
 
+    def _is_valid_json(self, json_str: str) -> bool:
+        """Check if a string is valid JSON"""
+        try:
+            json.loads(json_str)
+            return True
+        except:
+            return False
 
 class FontManager:
     """Manages font installation and loading for the certificate generator"""