Update app.py

app.py

@@ -25,7 +25,7 @@ def generate_pkce_codes():
     code_challenge = base64.urlsafe_b64encode(hashlib.sha256(code_verifier.encode()).digest()).decode().rstrip('=')
     return code_verifier, code_challenge
 
-def get_msal_app(code_challenge=None):
+def get_msal_app():
     return msal.PublicClientApplication(
         client_id=APPLICATION_ID_KEY,
         authority=AUTHORITY_URL
@@ -43,34 +43,7 @@ else:
 # Create the MSAL instance for acquiring tokens
 client_instance = get_msal_app()
 
-# 🔐 Acquire access token using authorization code
-def get_access_token(code):
-    client_instance = get_msal_app()
-    
-    # Debug: Print MSAL app configuration (be careful not to expose secrets)
-    st.write("Debug: MSAL App Configuration:")
-    st.write(f"Client ID: {APPLICATION_ID_KEY[:5]}...") # Show first 5 chars
-    st.write(f"Authority: {AUTHORITY_URL}")
-    st.write(f"Redirect URI: {REDIRECT_URI}")
-    
-    try:
-        result = client_instance.acquire_token_by_authorization_code(
-            code=code,
-            scopes=SCOPES,
-            redirect_uri=REDIRECT_URI
-        )
-        
-        if 'access_token' in result:
-            return result['access_token']
-        else:
-            error_description = result.get('error_description', 'No error description provided')
-            raise Exception(f"Error acquiring token: {error_description}")
-    except Exception as e:
-        st.error(f"Exception in get_access_token: {str(e)}")
-        raise
-        #st.stop()
-
-
+# 🔐 Acquire access token using authorization code and PKCE
 def get_access_token(code, code_verifier):
     client_instance = get_msal_app()
     
@@ -80,11 +53,13 @@ def get_access_token(code, code_verifier):
     st.write(f"Redirect URI: {REDIRECT_URI}")
     
     try:
+        # Use PublicClientApplication to support PKCE
         result = client_instance.acquire_token_by_authorization_code(
             code=code,
             scopes=SCOPES,
             redirect_uri=REDIRECT_URI,
-            code_verifier=code_verifier  # Include the code verifier here
+            # If your MSAL library supports PKCE, this will work:
+            code_verifier=code_verifier
         )
         
         if 'access_token' in result:
@@ -95,6 +70,7 @@ def get_access_token(code, code_verifier):
     except Exception as e:
         st.error(f"Exception in get_access_token: {str(e)}")
         raise
+
         
 def process_query_params():
     # ⚙️q= Run ArXiv search from query parameters