Update app.py

app.py

@@ -1,32 +1,76 @@
-from smolagents import CodeAgent,DuckDuckGoSearchTool, HfApiModel,load_tool,tool
+import os
 import datetime
 import requests
 import pytz
 import yaml
-from tools.final_answer import FinalAnswerTool
 
+from smolagents import ToolCallingAgent, HfApiModel, tool
+from tools.final_answer import FinalAnswerTool
 from Gradio_UI import GradioUI
 
-# Below is an example of a tool that does nothing. Amaze us with your creativity !
+
+# -----------------------------
+# Utilities
+# -----------------------------
+DEFAULT_TIMEOUT = 20
+
+
+def safe_request_json(url: str, *, params=None, headers=None, timeout=DEFAULT_TIMEOUT):
+    """Send a GET request and return JSON data with clearer error messages."""
+    try:
+        response = requests.get(url, params=params, headers=headers, timeout=timeout)
+        response.raise_for_status()
+        return response.json()
+    except requests.exceptions.Timeout:
+        raise RuntimeError("The request timed out. Please try again later.")
+    except requests.exceptions.HTTPError as e:
+        status_code = getattr(e.response, "status_code", "unknown")
+        body = ""
+        try:
+            body = e.response.text[:300]
+        except Exception:
+            pass
+        raise RuntimeError(f"HTTP {status_code} error. {body}")
+    except requests.exceptions.RequestException as e:
+        raise RuntimeError(f"Network request failed: {str(e)}")
+    except ValueError:
+        raise RuntimeError("The server returned invalid JSON data.")
+
+
+# -----------------------------
+# Tools
+# -----------------------------
 @tool
 def get_weather(location: str) -> str:
-    """Get the current weather for a specified location.
+    """Get the current weather for a specified city or region.
+    Use this tool whenever the user asks about weather, temperature, humidity, wind, or forecast.
     Args:
-        location: A city, region, or country name, such as 'Beijing', 'Tokyo', or 'New York'.
+        location: A city, region, or country name, such as Beijing, Tokyo, Shanghai, or New York.
     """
     try:
-        url = f"https://wttr.in/{location}?format=j1"
-        response = requests.get(url, timeout=10)
-        response.raise_for_status()
-        data = response.json()
+        # wttr.in is convenient for demos, but can occasionally be slow in cloud environments.
+        # We keep a slightly longer timeout and return clear errors.
+        url = f"https://wttr.in/{location}"
+        params = {"format": "j1"}
+        data = safe_request_json(url, params=params, timeout=20)
 
-        current = data["current_condition"][0]
+        current_list = data.get("current_condition", [])
+        if not current_list:
+            return f"Could not find weather data for '{location}'."
 
+        current = current_list[0]
         temp_c = current.get("temp_C", "Unknown")
         feels_like_c = current.get("FeelsLikeC", "Unknown")
         humidity = current.get("humidity", "Unknown")
-        weather_desc = current.get("weatherDesc", [{}])[0].get("value", "Unknown")
         wind_kph = current.get("windspeedKmph", "Unknown")
+        weather_desc = current.get("weatherDesc", [{}])[0].get("value", "Unknown")
+
+        # Try to include today's high/low if available
+        weather_days = data.get("weather", [])
+        high_c = low_c = "Unknown"
+        if weather_days:
+            high_c = weather_days[0].get("maxtempC", "Unknown")
+            low_c = weather_days[0].get("mintempC", "Unknown")
 
         return (
             f"Current weather in {location}:\n"
@@ -34,7 +78,8 @@ def get_weather(location: str) -> str:
             f"- Temperature: {temp_c}°C\n"
             f"- Feels like: {feels_like_c}°C\n"
             f"- Humidity: {humidity}%\n"
-            f"- Wind speed: {wind_kph} km/h"
+            f"- Wind speed: {wind_kph} km/h\n"
+            f"- Today's high / low: {high_c}°C / {low_c}°C"
         )
     except Exception as e:
         return f"Error fetching weather for '{location}': {str(e)}"
@@ -43,38 +88,48 @@ def get_weather(location: str) -> str:
 @tool
 def get_nba_games(date: str) -> str:
     """Get NBA game results for a specific date.
+    Use this tool whenever the user asks for NBA games, scores, or results on a given date.
     Args:
         date: A date in YYYY-MM-DD format, for example '2026-03-08'.
     """
+    api_key = os.getenv("BALLDONTLIE_API_KEY")
+    if not api_key:
+        return (
+            "BALLDONTLIE_API_KEY is not set. Please add your BALLDONTLIE API key "
+            "as an environment variable or Hugging Face Secret."
+        )
+
     try:
-        url = "https://www.balldontlie.io/api/v1/games"
+        # Official authenticated endpoint style
+        url = "https://api.balldontlie.io/nba/v1/games"
+        headers = {"Authorization": api_key}
         params = {
             "dates[]": date,
-            "per_page": 100
+            "per_page": 100,
         }
 
-        response = requests.get(url, params=params, timeout=10)
-        response.raise_for_status()
-        data = response.json()
-
+        data = safe_request_json(url, params=params, headers=headers, timeout=20)
         games = data.get("data", [])
         if not games:
             return f"No NBA games found for {date}."
 
         results = [f"NBA games on {date}:"]
         for game in games:
-            home_team = game["home_team"]["full_name"]
-            visitor_team = game["visitor_team"]["full_name"]
+            home_team = game.get("home_team", {}).get("full_name", "Unknown Home Team")
+            visitor_team = game.get("visitor_team", {}).get("full_name", "Unknown Visitor Team")
             home_score = game.get("home_team_score", 0)
             visitor_score = game.get("visitor_team_score", 0)
             status = game.get("status", "Unknown")
 
-            if home_score > visitor_score:
-                winner = home_team
-            elif visitor_score > home_score:
-                winner = visitor_team
+            if isinstance(home_score, int) and isinstance(visitor_score, int):
+                if home_score > visitor_score:
+                    winner = home_team
+                elif visitor_score > home_score:
+                    winner = visitor_team
+                else:
+                    winner = "Tie / Not finished"
             else:
-                winner = "Tie / Not finished"
+                winner = "Unknown"
 
             results.append(
                 f"- {visitor_team} {visitor_score} : {home_score} {home_team} "
@@ -82,58 +137,83 @@ def get_nba_games(date: str) -> str:
             )
 
         return "\n".join(results)
-
     except Exception as e:
         return f"Error fetching NBA games for '{date}': {str(e)}"
 
+
 @tool
 def get_current_time_in_timezone(timezone: str) -> str:
-    """A tool that fetches the current local time in a specified timezone.
+    """Get the current local time in a specified timezone.
+    Use this tool whenever the user asks for the current time in a city or timezone.
     Args:
-        timezone: A string representing a valid timezone (e.g., 'America/New_York').
+        timezone: A valid timezone string, such as 'Asia/Shanghai' or 'America/New_York'.
     """
     try:
-        # Create timezone object
         tz = pytz.timezone(timezone)
-        # Get current time in that timezone
         local_time = datetime.datetime.now(tz).strftime("%Y-%m-%d %H:%M:%S")
         return f"The current local time in {timezone} is: {local_time}"
     except Exception as e:
         return f"Error fetching time for timezone '{timezone}': {str(e)}"
 
 
+# -----------------------------
+# Final answer tool
+# -----------------------------
 final_answer = FinalAnswerTool()
 
-# If the agent does not answer, the model is overloaded, please use another model or the following Hugging Face Endpoint that also contains qwen2.5 coder:
-# model_id='https://pflgm2locj2t89co.us-east-1.aws.endpoints.huggingface.cloud' 
 
+# -----------------------------
+# Model
+# -----------------------------
 model = HfApiModel(
-max_tokens=2096,
-temperature=0.5,
-model_id='Qwen/Qwen2.5-Coder-32B-Instruct',# it is possible that this model may be overloaded
-custom_role_conversions=None,
+    max_tokens=2048,
+    temperature=0.2,
+    model_id="Qwen/Qwen2.5-Coder-32B-Instruct",
+    custom_role_conversions=None,
 )
 
-# Search tool
-search_tool = DuckDuckGoSearchTool()
-
-# Import tool from Hub
-image_generation_tool = load_tool("agents-course/text-to-image", trust_remote_code=True)
 
-with open("prompts.yaml", 'r') as stream:
-    prompt_templates = yaml.safe_load(stream)
-    
-agent = CodeAgent(
+# -----------------------------
+# Prompt templates
+# -----------------------------
+fallback_prompt_templates = {
+    "system_prompt": (
+        "You are a helpful assistant.\n"
+        "Rules:\n"
+        "1. If the user asks about weather, use the get_weather tool.\n"
+        "2. If the user asks about NBA games or scores, use the get_nba_games tool.\n"
+        "3. If the user asks about current time in a timezone, use the get_current_time_in_timezone tool.\n"
+        "4. Do not invent tools or functions that are not provided.\n"
+        "5. If a tool returns an error, explain the error clearly.\n"
+    )
+}
+
+if os.path.exists("prompts.yaml"):
+    with open("prompts.yaml", "r", encoding="utf-8") as stream:
+        prompt_templates = yaml.safe_load(stream)
+else:
+    prompt_templates = fallback_prompt_templates
+
+
+# -----------------------------
+# Agent
+# -----------------------------
+agent = ToolCallingAgent(
     model=model,
-    tools=[final_answer, get_nba_games, get_weather, get_current_time_in_timezone, search_tool, image_generation_tool],
-    max_steps=6,
-    verbosity_level=1,
-    grammar=None,
-    planning_interval=None,
+    tools=[
+        final_answer,
+        get_weather,
+        get_nba_games,
+        get_current_time_in_timezone,
+    ],
+    max_steps=4,
     name="Chen_Qiang",
-    description=None,
-    prompt_templates=prompt_templates
+    description="An agent for weather, NBA results, and timezone queries.",
+    prompt_templates=prompt_templates,
 )
 
 
+# -----------------------------
+# Launch UI
+# -----------------------------
 GradioUI(agent).launch()