Spaces:
Running
Running
File size: 12,200 Bytes
7cc81cb | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 | from __future__ import annotations
import base64
import hashlib
from datetime import datetime, timedelta, timezone
from pathlib import Path
import pytest
from fastapi.testclient import TestClient
from sqlalchemy import select
from app.container import build_container
from app.core.config import Settings
from app.mcp.registry import MCPRegistry
from app.security.context import auth_context
from app.security.errors import APIKeyConflictError, ForbiddenError, RateLimitError, UnauthorizedError
from app.security.models import APIKey, AuditLog
from app.security.schemas import APIKeyCreate
from app.security.service import APIKeyService
from main import create_app
def security_settings(tmp_path: Path, **overrides: object) -> Settings:
values: dict[str, object] = {
"_env_file": None,
"temp_dir": tmp_path / "temp",
"output_dir": tmp_path / "outputs",
"database_url": f"sqlite+aiosqlite:///{tmp_path / 'security.db'}",
"auth_enabled": True,
"auth_last_used_update_seconds": 0,
"cleanup_interval_seconds": 3600,
"whisper_model": "tiny",
"max_workers": 1,
}
values.update(overrides)
return Settings(**values)
@pytest.fixture
async def security_container(tmp_path: Path):
container = build_container(security_settings(tmp_path))
await container.security_database.initialize()
try:
yield container
finally:
await container.security_database.close()
async def create_key(container, **overrides: object) -> tuple[APIKey, str]:
values: dict[str, object] = {
"name": "Automation",
"environment": "test",
"role": None,
"scopes": ["templates:read"],
}
values.update(overrides)
return await container.api_keys.create(APIKeyCreate(**values), created_by="tests")
async def test_key_generation_has_256_bits_and_database_never_stores_secret(
security_container,
) -> None:
record, secret = await create_key(security_container)
environment, encoded_secret = secret.split("_", 2)[1:]
raw_secret = base64.urlsafe_b64decode(encoded_secret + "=")
assert environment == "test"
assert len(raw_secret) == 32
assert record.key_prefix == f"mp_test_{encoded_secret[:8]}"
assert record.key_hash == hashlib.sha256(secret.encode()).hexdigest()
async with security_container.security_database.session() as session:
stored = await session.get(APIKey, record.id)
assert stored is not None
assert secret not in vars(stored).values()
assert not hasattr(stored, "api_key")
async def test_authentication_rejects_invalid_expired_disabled_and_revoked_keys(
security_container,
) -> None:
active, active_secret = await create_key(security_container)
assert (await security_container.api_keys.authenticate(active_secret)).api_key_id == active.id
replacement = "A" if active_secret[-1] != "A" else "B"
with pytest.raises(UnauthorizedError):
await security_container.api_keys.authenticate(active_secret[:-1] + replacement)
_, expired_secret = await create_key(
security_container,
name="Expired",
expires_at=datetime.now(timezone.utc) - timedelta(seconds=1),
)
with pytest.raises(UnauthorizedError):
await security_container.api_keys.authenticate(expired_secret)
await security_container.api_keys.set_status(active.id, "disabled")
with pytest.raises(UnauthorizedError):
await security_container.api_keys.authenticate(active_secret)
await security_container.api_keys.set_status(active.id, "active")
assert (await security_container.api_keys.authenticate(active_secret)).api_key_id == active.id
await security_container.api_keys.set_status(active.id, "revoked")
with pytest.raises(UnauthorizedError):
await security_container.api_keys.authenticate(active_secret)
with pytest.raises(APIKeyConflictError):
await security_container.api_keys.set_status(active.id, "disabled")
with pytest.raises(APIKeyConflictError):
await security_container.api_keys.set_status(active.id, "active")
async def test_scope_enforcement_and_rotation_grace_period(security_container) -> None:
old, old_secret = await create_key(security_container)
context = await security_container.api_keys.authenticate(old_secret)
security_container.api_keys.authorize(context, "templates:read")
with pytest.raises(ForbiddenError):
security_container.api_keys.authorize(context, "operations:execute")
replacement, replacement_secret = await security_container.api_keys.rotate(
old.id, 60, created_by="tests"
)
assert replacement.rotated_from_id == old.id
assert (await security_container.api_keys.authenticate(old_secret)).api_key_id == old.id
assert (
await security_container.api_keys.authenticate(replacement_secret)
).api_key_id == replacement.id
with pytest.raises(APIKeyConflictError):
await security_container.api_keys.set_status(old.id, "disabled")
async with security_container.security_database.session() as session:
rotating = await session.get(APIKey, old.id)
assert rotating is not None
rotating.grace_expires_at = datetime.now(timezone.utc) - timedelta(seconds=1)
await session.commit()
with pytest.raises(UnauthorizedError):
await security_container.api_keys.authenticate(old_secret)
assert (await security_container.api_keys.get(old.id)).status == "revoked"
async def test_per_key_request_and_concurrent_job_limits(security_container) -> None:
_, request_secret = await create_key(
security_container, name="RPM", requests_per_minute=1
)
request_context = await security_container.api_keys.authenticate(request_secret)
lease = await security_container.rate_limiter.acquire(
request_context, is_job=False, is_upload=False, uploaded_bytes=0
)
await lease.release()
with pytest.raises(RateLimitError) as rate_error:
await security_container.rate_limiter.acquire(
request_context, is_job=False, is_upload=False, uploaded_bytes=0
)
assert rate_error.value.retry_after >= 1
_, job_secret = await create_key(
security_container, name="Concurrency", concurrent_jobs=1
)
job_context = await security_container.api_keys.authenticate(job_secret)
running = await security_container.rate_limiter.acquire(
job_context, is_job=True, is_upload=False, uploaded_bytes=0
)
with pytest.raises(RateLimitError):
await security_container.rate_limiter.acquire(
job_context, is_job=True, is_upload=False, uploaded_bytes=0
)
await running.release()
next_job = await security_container.rate_limiter.acquire(
job_context, is_job=True, is_upload=False, uploaded_bytes=0
)
await next_job.release()
async def test_stdio_mcp_uses_shared_context_scopes_rate_limits_and_audit(
security_container,
) -> None:
_, secret = await create_key(
security_container, name="MCP Reader", scopes=["mcp:read"]
)
context = await security_container.api_keys.authenticate(secret)
registry = MCPRegistry(security_container)
unauthorized = await registry.run_metadata_tool("system_info", registry.system_info_data)
token = auth_context.set(context)
try:
resource = await registry.safe_resource("version", registry.version_data)
forbidden = await registry.run_metadata_tool("system_info", registry.system_info_data)
finally:
auth_context.reset(token)
assert unauthorized["success"] is False
assert unauthorized["error"]["code"] == "UNAUTHORIZED"
assert resource["success"] is True
assert forbidden["success"] is False
assert forbidden["error"]["code"] == "FORBIDDEN"
async with security_container.security_database.session() as session:
logs = list((await session.scalars(select(AuditLog))).all())
assert {log.endpoint for log in logs} >= {
"mcp://tools/resource.version",
"mcp://tools/system_info",
}
def test_http_middleware_public_and_authentication_contracts(tmp_path: Path) -> None:
material = APIKeyService.generate_material("test")
settings = security_settings(
tmp_path,
auth_bootstrap_key_hash=material.key_hash,
auth_bootstrap_key_prefix=material.key_prefix,
auth_bootstrap_environment="test",
auth_default_requests_per_minute=1000,
)
application = create_app(settings)
authorization = {"Authorization": f"Bearer {material.api_key}"}
with TestClient(application) as client:
for path in ("/", "/health", "/version", "/docs", "/openapi.json", "/redoc"):
assert client.get(path).status_code == 200
missing = client.get("/v1/auth/context")
malformed = client.get(
"/v1/auth/context", headers={"Authorization": "Basic not-a-mediarouter-key"}
)
invalid = client.get(
"/v1/auth/context", headers={"Authorization": "Bearer mp_test_invalid"}
)
for response in (missing, malformed, invalid):
assert response.status_code == 401
assert response.json() == {
"error": "Unauthorized",
"message": "Invalid or expired API key.",
}
assert response.headers["www-authenticate"] == "Bearer"
mcp_missing = client.post("/mcp/", json={"jsonrpc": "2.0", "id": 1})
assert mcp_missing.status_code == 401
identity = client.get("/v1/auth/context", headers=authorization)
assert identity.status_code == 200
assert identity.json()["key_prefix"] == material.key_prefix
assert "admin" in identity.json()["scopes"]
created = client.post(
"/v1/api-keys",
headers=authorization,
json={
"name": "Template Reader",
"environment": "test",
"role": None,
"scopes": ["templates:read"],
},
)
assert created.status_code == 201
limited_authorization = {
"Authorization": f"Bearer {created.json()['api_key']}"
}
assert client.get("/v1/auth/context", headers=limited_authorization).status_code == 200
forbidden = client.get("/v1/health", headers=limited_authorization)
assert forbidden.status_code == 403
assert forbidden.json() == {
"error": "Forbidden",
"message": "Missing required scope.",
}
mcp_forbidden = client.post(
"/mcp/",
headers=limited_authorization,
json={
"jsonrpc": "2.0",
"id": 1,
"method": "tools/call",
"params": {"name": "health", "arguments": {}},
},
)
assert mcp_forbidden.status_code == 403
audit_logs = client.get("/v1/audit-logs", headers=authorization)
assert audit_logs.status_code == 200
entries = audit_logs.json()
assert any(
entry["endpoint"] == "/v1/auth/context"
and entry["api_key_id"] == identity.json()["id"]
and entry["response_code"] == 200
for entry in entries
)
def test_http_rate_limit_returns_retry_after(tmp_path: Path) -> None:
material = APIKeyService.generate_material("test")
application = create_app(
security_settings(
tmp_path,
auth_bootstrap_key_hash=material.key_hash,
auth_bootstrap_key_prefix=material.key_prefix,
auth_bootstrap_environment="test",
auth_default_requests_per_minute=1,
)
)
headers = {"Authorization": f"Bearer {material.api_key}"}
with TestClient(application) as client:
assert client.get("/v1/auth/context", headers=headers).status_code == 200
limited = client.get("/v1/auth/context", headers=headers)
assert limited.status_code == 429
assert limited.json() == {
"error": "Rate limit exceeded",
"message": "Retry later.",
}
assert int(limited.headers["retry-after"]) >= 1
|