File size: 21,637 Bytes
7cc81cb
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
"""Phase 6A LinkedIn OIDC and organization-discovery coverage.

All LinkedIn traffic is mocked. Normal CI needs no developer application,
member credential, organization role, or interactive authorization flow.
"""

from __future__ import annotations

from datetime import datetime, timedelta, timezone
from pathlib import Path
from urllib.parse import parse_qs, urlparse

import httpx
import pytest
from pydantic import ValidationError
from sqlalchemy import func, select

from app.container import build_container
from app.core.config import Settings
from app.social.domain.errors import (
    SocialAccountNotFoundError,
    SocialCapabilityUnsupportedError,
    SocialOAuthStateError,
    SocialPermissionDeniedError,
    SocialReauthRequiredError,
)
from app.social.models import OAuthState, SocialAccountToken
from app.social.providers.linkedin import LINKEDIN_API_VERSION, LinkedInProvider
from app.social.schemas.accounts import SocialAccountConnectRequest

_REDIRECT_URI = "https://api.example.com/v1/social/accounts/linkedin/callback"


def linkedin_settings(tmp_path: Path) -> Settings:
    return Settings(
        _env_file=None,
        auth_enabled=False,
        database_url=f"sqlite+aiosqlite:///{tmp_path / 'security.db'}",
        social_database_url=f"sqlite+aiosqlite:///{tmp_path / 'social.db'}",
        social_auto_migrate=True,
        social_worker_enabled=False,
        social_oauth_encryption_key="phase-6a-linkedin-test-encryption-material",
        social_oauth_redirect_base_url="https://api.example.com",
        linkedin_client_id="linkedin-client-id",
        linkedin_client_secret="linkedin-client-secret",
        linkedin_redirect_uri=_REDIRECT_URI,
        temp_dir=tmp_path / "temp",
        output_dir=tmp_path / "outputs",
        cleanup_interval_seconds=3600,
        whisper_model="tiny",
    )


async def test_linkedin_member_authorization_uses_official_oidc_without_pkce(
    tmp_path: Path,
) -> None:
    provider = LinkedInProvider(linkedin_settings(tmp_path))
    try:
        url = await provider.get_authorization_url(
            state="s" * 43,
            redirect_uri=_REDIRECT_URI,
        )
        with pytest.raises(SocialPermissionDeniedError):
            await provider.get_authorization_url(
                state="s" * 43,
                redirect_uri=_REDIRECT_URI,
                code_challenge="undocumented-pkce-challenge",
            )
        with pytest.raises(SocialCapabilityUnsupportedError):
            await provider.get_authorization_url(
                state="s" * 43,
                redirect_uri=_REDIRECT_URI,
                additional_scopes=["w_member_social"],
            )
    finally:
        await provider.close()

    parsed = urlparse(url)
    query = parse_qs(parsed.query)
    assert f"{parsed.scheme}://{parsed.netloc}{parsed.path}" == (
        "https://www.linkedin.com/oauth/v2/authorization"
    )
    assert query == {
        "client_id": ["linkedin-client-id"],
        "redirect_uri": [_REDIRECT_URI],
        "response_type": ["code"],
        "state": ["s" * 43],
        "scope": ["openid profile"],
    }
    assert "code_challenge" not in query


async def test_linkedin_exchange_member_and_organization_discovery_use_official_apis(
    tmp_path: Path,
) -> None:
    calls: list[str] = []

    async def handler(request: httpx.Request) -> httpx.Response:
        calls.append(request.url.path)
        if request.url.path == "/oauth/v2/accessToken":
            assert request.url.host == "www.linkedin.com"
            form = parse_qs(request.content.decode())
            assert form == {
                "grant_type": ["authorization_code"],
                "code": ["authorization-code"],
                "redirect_uri": [_REDIRECT_URI],
                "client_id": ["linkedin-client-id"],
                "client_secret": ["linkedin-client-secret"],
            }
            return httpx.Response(
                200,
                json={
                    "access_token": "linkedin-access-token",
                    "expires_in": 5184000,
                    "token_type": "Bearer",
                },
            )
        assert request.headers["authorization"] == "Bearer linkedin-access-token"
        if request.url.path == "/v2/userinfo":
            return httpx.Response(
                200,
                json={
                    "sub": "oidc-member-subject_123",
                    "name": "Ada Lovelace",
                    "given_name": "Ada",
                    "family_name": "Lovelace",
                    "picture": "https://media.licdn.com/member.jpg",
                    "locale": {"country": "US", "language": "en"},
                    "email": "not-persisted@example.com",
                    "email_verified": True,
                },
            )
        assert request.headers["linkedin-version"] == LINKEDIN_API_VERSION
        assert request.headers["x-restli-protocol-version"] == "2.0.0"
        if request.url.path == "/rest/organizationAcls":
            assert parse_qs(request.url.query.decode()) == {
                "q": ["roleAssignee"],
                "role": ["ADMINISTRATOR"],
                "state": ["APPROVED"],
                "count": ["100"],
                "start": ["0"],
            }
            return httpx.Response(
                200,
                json={
                    "elements": [
                        {"organization": "urn:li:organization:123456"},
                        {
                            "organizationTarget": "urn:li:organization:789012"
                        },
                    ],
                    "paging": {"start": 0, "count": 2, "total": 2, "links": []},
                },
            )
        organization_id = request.url.path.rsplit("/", 1)[-1]
        return httpx.Response(
            200,
            json={
                "id": int(organization_id),
                "localizedName": f"Organization {organization_id}",
                "vanityName": f"organization-{organization_id}",
                "logoV2": {
                    "digitalmediaAsset": "urn:li:digitalmediaAsset:logo_asset",
                    "original~": {
                        "elements": [
                            {
                                "identifiers": [
                                    {
                                        "identifier": f"https://media.licdn.com/{organization_id}.png"
                                    }
                                ]
                            }
                        ]
                    },
                },
                "primaryOrganizationType": "NONE",
                "defaultLocale": {"country": "US", "language": "en"},
                "localizedWebsite": "https://example.com",
            },
        )

    client = httpx.AsyncClient(transport=httpx.MockTransport(handler))
    provider = LinkedInProvider(linkedin_settings(tmp_path), http_client=client)
    try:
        token = await provider.exchange_code(
            code="authorization-code",
            redirect_uri=_REDIRECT_URI,
        )
        accounts = await provider.discover_accounts(
            token, account_type="linkedin_organization"
        )
    finally:
        await client.aclose()

    member, first, second = accounts
    assert member["external_account_id"] == "oidc-member-subject_123"
    assert member["account_type"] == "linkedin_member"
    assert member["connection_status"] == "connected"
    assert member["metadata"]["email_verified"] is True
    assert "email" not in member["metadata"]
    assert [first["external_account_id"], second["external_account_id"]] == [
        "123456",
        "789012",
    ]
    assert first["account_type"] == "linkedin_organization"
    assert first["connection_status"] == "pending"
    assert first["avatar_url"] == "https://media.licdn.com/123456.png"
    assert first["metadata"]["parent_member_id"] == "oidc-member-subject_123"
    assert first["metadata"]["logo_asset"] == (
        "urn:li:digitalmediaAsset:logo_asset"
    )
    assert calls == [
        "/oauth/v2/accessToken",
        "/v2/userinfo",
        "/rest/organizationAcls",
        "/rest/organizations/123456",
        "/rest/organizations/789012",
    ]


async def test_linkedin_organization_scope_is_explicit_and_bound_to_state(
    tmp_path: Path,
) -> None:
    container = build_container(linkedin_settings(tmp_path))
    await container.social.initialize()
    try:
        member = await container.social.oauth.connect(
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            payload=SocialAccountConnectRequest(),
        )
        member_query = parse_qs(urlparse(member.authorization_url or "").query)
        assert member_query["scope"] == ["openid profile"]
        assert "code_challenge" not in member_query

        organization = await container.social.oauth.connect(
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            payload=SocialAccountConnectRequest(
                account_type="linkedin_organization"
            ),
        )
        organization_query = parse_qs(
            urlparse(organization.authorization_url or "").query
        )
        assert organization_query["scope"] == [
            "openid profile rw_organization_admin"
        ]
        assert "w_organization_social" not in organization_query["scope"][0]
        state = await container.social.oauth.states.consume(
            state=organization_query["state"][0], provider="linkedin"
        )
        assert state.workspace_id == "workspace-a"
        assert state.user_id == "user-a"
        assert state.requested_account_type == "linkedin_organization"
        assert state.requested_scopes == [
            "openid",
            "profile",
            "rw_organization_admin",
        ]

        with pytest.raises(SocialCapabilityUnsupportedError):
            await container.social.oauth.connect(
                provider="linkedin",
                workspace_id="workspace-a",
                user_id="user-a",
                payload=SocialAccountConnectRequest(account_type="organization"),
            )
    finally:
        await container.social.close()
        await container.security_database.close()


async def test_linkedin_callback_is_duplicate_safe_selectable_and_workspace_bound(
    tmp_path: Path,
) -> None:
    container = build_container(linkedin_settings(tmp_path))
    await container.social.initialize()
    adapter = container.social.accounts.providers.get("linkedin")
    assert isinstance(adapter, LinkedInProvider)
    await adapter._client.aclose()

    async def handler(request: httpx.Request) -> httpx.Response:
        if request.url.path == "/oauth/v2/accessToken":
            return httpx.Response(
                200,
                json={
                    "access_token": "linkedin-token-that-must-remain-encrypted",
                    "expires_in": 3600,
                    "token_type": "Bearer",
                },
            )
        if request.url.path == "/v2/userinfo":
            return httpx.Response(
                200,
                json={"sub": "stable-member-sub", "name": "Workspace Member"},
            )
        if request.url.path == "/rest/organizationAcls":
            return httpx.Response(
                200,
                json={
                    "elements": [
                        {"organization": "urn:li:organization:123456"}
                    ],
                    "paging": {"start": 0, "count": 1, "total": 1},
                },
            )
        return httpx.Response(
            200,
            json={
                "id": 123456,
                "localizedName": "Workspace Organization",
                "vanityName": "workspace-organization",
            },
        )

    adapter._client = httpx.AsyncClient(transport=httpx.MockTransport(handler))
    adapter._owns_client = True
    try:
        connect = await container.social.oauth.connect(
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            payload=SocialAccountConnectRequest(
                account_type="linkedin_organization"
            ),
        )
        state = parse_qs(urlparse(connect.authorization_url or "").query)["state"][0]
        member = await container.social.oauth.callback(
            provider="linkedin", state=state, code="first-code"
        )
        assert member.account_type == "linkedin_member"
        assert member.status.value == "connected"
        with pytest.raises(SocialOAuthStateError):
            await container.social.oauth.callback(
                provider="linkedin", state=state, code="replayed-code"
            )

        accounts = await container.social.accounts.list("workspace-a")
        assert len(accounts) == 2
        organization = next(
            item
            for item in accounts
            if item.account_type == "linkedin_organization"
        )
        assert organization.status.value == "pending"
        assert "linkedin-token-that-must-remain-encrypted" not in (
            organization.model_dump_json()
        )

        with pytest.raises(SocialAccountNotFoundError):
            await container.social.accounts.select_discovered(
                "workspace-b", [organization.id]
            )
        selected = await container.social.accounts.select_discovered(
            "workspace-a", [organization.id, organization.id]
        )
        assert len(selected) == 1
        assert selected[0].status.value == "connected"

        second_connect = await container.social.oauth.connect(
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            payload=SocialAccountConnectRequest(
                account_type="linkedin_organization"
            ),
        )
        second_state = parse_qs(
            urlparse(second_connect.authorization_url or "").query
        )["state"][0]
        await container.social.oauth.callback(
            provider="linkedin", state=second_state, code="second-code"
        )
        duplicate_safe = await container.social.accounts.list("workspace-a")
        assert len(duplicate_safe) == 2
        assert next(
            item
            for item in duplicate_safe
            if item.account_type == "linkedin_organization"
        ).status.value == "connected"

        async with container.social.database.session("workspace-a") as session:
            token_count = await session.scalar(select(func.count(SocialAccountToken.id)))
            encrypted_payloads = list(
                (
                    await session.scalars(
                        select(SocialAccountToken.encrypted_payload)
                    )
                ).all()
            )
        assert token_count == 2
        assert all(encrypted_payloads)
        assert all(
            "linkedin-token-that-must-remain-encrypted" not in str(payload)
            for payload in encrypted_payloads
        )
    finally:
        await container.social.close()
        await container.security_database.close()


async def test_linkedin_state_redirect_expiry_and_provider_binding(
    tmp_path: Path,
) -> None:
    container = build_container(linkedin_settings(tmp_path))
    await container.social.initialize()
    try:
        assert container.social.oauth._redirect_uri("linkedin", None) == _REDIRECT_URI
        with pytest.raises(SocialPermissionDeniedError):
            container.social.oauth._redirect_uri(
                "linkedin",
                "https://attacker.example/v1/social/accounts/linkedin/callback",
            )
        state = await container.social.oauth.states.create(
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            redirect_uri=_REDIRECT_URI,
            requested_account_type="linkedin_member",
            requested_scopes=["openid", "profile"],
        )
        with pytest.raises(SocialOAuthStateError):
            await container.social.oauth.states.consume(
                state=state.state, provider="x"
            )
        consumed = await container.social.oauth.states.consume(
            state=state.state, provider="linkedin"
        )
        assert consumed.workspace_id == "workspace-a"

        expired = OAuthState(
            state="expired-linkedin-state-value-that-is-long-enough",
            provider="linkedin",
            workspace_id="workspace-a",
            user_id="user-a",
            redirect_uri=_REDIRECT_URI,
            requested_account_type="linkedin_member",
            requested_scopes=["openid", "profile"],
            expires_at=datetime.now(timezone.utc) - timedelta(seconds=1),
        )
        async with container.social.database.session("workspace-a") as session:
            session.add(expired)
            await session.commit()
        with pytest.raises(SocialOAuthStateError):
            await container.social.oauth.states.consume(
                state=expired.state, provider="linkedin"
            )
    finally:
        await container.social.close()
        await container.security_database.close()


async def test_linkedin_invalid_code_and_refresh_rules_do_not_leak_secrets(
    tmp_path: Path,
) -> None:
    secret_code = "linkedin-code-that-must-not-leak"

    async def handler(_: httpx.Request) -> httpx.Response:
        return httpx.Response(
            400,
            json={
                "error": "invalid_grant",
                "error_description": f"bad code {secret_code}",
            },
        )

    client = httpx.AsyncClient(transport=httpx.MockTransport(handler))
    provider = LinkedInProvider(linkedin_settings(tmp_path), http_client=client)
    try:
        with pytest.raises(SocialPermissionDeniedError) as raised:
            await provider.exchange_code(
                code=secret_code, redirect_uri=_REDIRECT_URI
            )
        with pytest.raises(SocialReauthRequiredError):
            await provider.refresh_token({"access_token": "expired"})
    finally:
        await client.aclose()
    assert secret_code not in str(raised.value)
    assert "linkedin-client-secret" not in str(raised.value)


async def test_linkedin_refresh_is_used_only_when_provider_issued_it(
    tmp_path: Path,
) -> None:
    async def handler(request: httpx.Request) -> httpx.Response:
        form = parse_qs(request.content.decode())
        assert form == {
            "grant_type": ["refresh_token"],
            "refresh_token": ["partner-refresh-token"],
            "client_id": ["linkedin-client-id"],
            "client_secret": ["linkedin-client-secret"],
        }
        return httpx.Response(
            200,
            json={
                "access_token": "refreshed-access-token",
                "expires_in": 5184000,
                "token_type": "Bearer",
            },
        )

    client = httpx.AsyncClient(transport=httpx.MockTransport(handler))
    provider = LinkedInProvider(linkedin_settings(tmp_path), http_client=client)
    try:
        refreshed = await provider.refresh_token(
            {
                "access_token": "expired-access-token",
                "refresh_token": "partner-refresh-token",
            }
        )
    finally:
        await client.aclose()

    assert refreshed["access_token"] == "refreshed-access-token"
    assert refreshed["refresh_token"] == "partner-refresh-token"


async def test_linkedin_capabilities_are_discovery_only(tmp_path: Path) -> None:
    container = build_container(linkedin_settings(tmp_path))
    try:
        linkedin = container.social.accounts.get_provider("linkedin")
        assert linkedin.available
        assert linkedin.configured
        assert linkedin.capabilities.implementation_status == "implemented"
        assert linkedin.capabilities.account_types == [
            "linkedin_member",
            "linkedin_organization",
        ]
        assert linkedin.capabilities.required_scopes == ["openid", "profile"]
        assert linkedin.capabilities.optional_scopes == ["rw_organization_admin"]
        assert not linkedin.capabilities.video
        assert not linkedin.capabilities.image
        assert not linkedin.capabilities.direct_publish
        assert not linkedin.capabilities.draft_upload
        assert not linkedin.capabilities.scheduled_publish
        assert not linkedin.capabilities.analytics
        assert not linkedin.capabilities.delete_post
        assert not linkedin.capabilities.personal_publishing
        assert not linkedin.capabilities.organization_publishing
        assert linkedin.capabilities.publish_metadata_schema == {}
    finally:
        await container.social.close()
        await container.security_database.close()


def test_linkedin_redirect_configuration_is_fail_closed() -> None:
    invalid = [
        "https://attacker.example/not-the-linkedin-callback",
        "http://api.example.com/v1/social/accounts/linkedin/callback",
        "https://api.example.com/v1/social/accounts/linkedin/callback?next=bad",
        "ftp://localhost/v1/social/accounts/linkedin/callback",
    ]
    for redirect in invalid:
        with pytest.raises(ValidationError):
            Settings(_env_file=None, linkedin_redirect_uri=redirect)
    local = Settings(
        _env_file=None,
        linkedin_redirect_uri=(
            "http://localhost/v1/social/accounts/linkedin/callback"
        ),
    )
    assert local.linkedin_redirect_uri.startswith("http://localhost/")