Spaces:
Sleeping
Sleeping
File size: 40,741 Bytes
f871fed |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 |
import os
from pathlib import Path
from typing import Any, List, Optional
from fastapi import (
APIRouter,
Depends,
File,
Form,
HTTPException,
Query,
UploadFile,
)
from fastapi.responses import FileResponse, Response
from loguru import logger
from surreal_commands import execute_command_sync
from api.command_service import CommandService
from api.models import (
AssetModel,
CreateSourceInsightRequest,
SourceCreate,
SourceInsightResponse,
SourceListResponse,
SourceResponse,
SourceStatusResponse,
SourceUpdate,
)
from commands.source_commands import SourceProcessingInput
from open_notebook.config import UPLOADS_FOLDER
from open_notebook.database.repository import ensure_record_id, repo_query
from open_notebook.domain.notebook import Notebook, Source
from open_notebook.domain.transformation import Transformation
from open_notebook.exceptions import InvalidInputError
router = APIRouter()
def generate_unique_filename(original_filename: str, upload_folder: str) -> str:
"""Generate unique filename like Streamlit app (append counter if file exists)."""
file_path = Path(upload_folder)
file_path.mkdir(parents=True, exist_ok=True)
# Split filename and extension
stem = Path(original_filename).stem
suffix = Path(original_filename).suffix
# Check if file exists and generate unique name
counter = 0
while True:
if counter == 0:
new_filename = original_filename
else:
new_filename = f"{stem} ({counter}){suffix}"
full_path = file_path / new_filename
if not full_path.exists():
return str(full_path)
counter += 1
async def save_uploaded_file(upload_file: UploadFile) -> str:
"""Save uploaded file to uploads folder and return file path."""
if not upload_file.filename:
raise ValueError("No filename provided")
# Generate unique filename
file_path = generate_unique_filename(upload_file.filename, UPLOADS_FOLDER)
try:
# Save file
with open(file_path, "wb") as f:
content = await upload_file.read()
f.write(content)
logger.info(f"Saved uploaded file to: {file_path}")
return file_path
except Exception as e:
logger.error(f"Failed to save uploaded file: {e}")
# Clean up partial file if it exists
if os.path.exists(file_path):
os.unlink(file_path)
raise
def parse_source_form_data(
type: str = Form(...),
notebook_id: Optional[str] = Form(None),
notebooks: Optional[str] = Form(None), # JSON string of notebook IDs
url: Optional[str] = Form(None),
content: Optional[str] = Form(None),
title: Optional[str] = Form(None),
transformations: Optional[str] = Form(None), # JSON string of transformation IDs
embed: str = Form("false"), # Accept as string, convert to bool
delete_source: str = Form("false"), # Accept as string, convert to bool
async_processing: str = Form("false"), # Accept as string, convert to bool
file: Optional[UploadFile] = File(None),
) -> tuple[SourceCreate, Optional[UploadFile]]:
"""Parse form data into SourceCreate model and return upload file separately."""
import json
# Convert string booleans to actual booleans
def str_to_bool(value: str) -> bool:
return value.lower() in ("true", "1", "yes", "on")
embed_bool = str_to_bool(embed)
delete_source_bool = str_to_bool(delete_source)
async_processing_bool = str_to_bool(async_processing)
# Parse JSON strings
notebooks_list = None
if notebooks:
try:
notebooks_list = json.loads(notebooks)
except json.JSONDecodeError:
logger.error(f"DEBUG - Invalid JSON in notebooks field: {notebooks}")
raise ValueError("Invalid JSON in notebooks field")
transformations_list = []
if transformations:
try:
transformations_list = json.loads(transformations)
except json.JSONDecodeError:
logger.error(
f"DEBUG - Invalid JSON in transformations field: {transformations}"
)
raise ValueError("Invalid JSON in transformations field")
# Create SourceCreate instance
try:
source_data = SourceCreate(
type=type,
notebook_id=notebook_id,
notebooks=notebooks_list,
url=url,
content=content,
title=title,
file_path=None, # Will be set later if file is uploaded
transformations=transformations_list,
embed=embed_bool,
delete_source=delete_source_bool,
async_processing=async_processing_bool,
)
pass # SourceCreate instance created successfully
except Exception as e:
logger.error(f"Failed to create SourceCreate instance: {e}")
raise
return source_data, file
@router.get("/sources", response_model=List[SourceListResponse])
async def get_sources(
notebook_id: Optional[str] = Query(None, description="Filter by notebook ID"),
limit: int = Query(50, ge=1, le=100, description="Number of sources to return (1-100)"),
offset: int = Query(0, ge=0, description="Number of sources to skip"),
sort_by: str = Query("updated", description="Field to sort by (created or updated)"),
sort_order: str = Query("desc", description="Sort order (asc or desc)"),
):
"""Get sources with pagination and sorting support."""
try:
# Validate sort parameters
if sort_by not in ["created", "updated"]:
raise HTTPException(status_code=400, detail="sort_by must be 'created' or 'updated'")
if sort_order.lower() not in ["asc", "desc"]:
raise HTTPException(status_code=400, detail="sort_order must be 'asc' or 'desc'")
# Build ORDER BY clause
order_clause = f"ORDER BY {sort_by} {sort_order.upper()}"
# Build the query
if notebook_id:
# Verify notebook exists first
notebook = await Notebook.get(notebook_id)
if not notebook:
raise HTTPException(status_code=404, detail="Notebook not found")
# Query sources for specific notebook - include command field
query = f"""
SELECT id, asset, created, title, updated, topics, command,
(SELECT VALUE count() FROM source_insight WHERE source = $parent.id GROUP ALL)[0].count OR 0 AS insights_count,
((SELECT VALUE id FROM source_embedding WHERE source = $parent.id LIMIT 1)) != NONE AS embedded
FROM (select value in from reference where out=$notebook_id)
{order_clause}
LIMIT $limit START $offset
"""
result = await repo_query(
query, {
"notebook_id": ensure_record_id(notebook_id),
"limit": limit,
"offset": offset
}
)
else:
# Query all sources - include command field
query = f"""
SELECT id, asset, created, title, updated, topics, command,
(SELECT VALUE count() FROM source_insight WHERE source = $parent.id GROUP ALL)[0].count OR 0 AS insights_count,
((SELECT VALUE id FROM source_embedding WHERE source = $parent.id LIMIT 1)) != NONE AS embedded
FROM source
{order_clause}
LIMIT $limit START $offset
"""
result = await repo_query(query, {"limit": limit, "offset": offset})
# Extract command IDs for batch status fetching
command_ids = []
command_to_source = {}
for row in result:
command = row.get("command")
if command:
command_str = str(command)
command_ids.append(command_str)
command_to_source[command_str] = row["id"]
# Batch fetch command statuses
command_statuses = {}
if command_ids:
try:
# Get status for all commands in batch (if the library supports it)
# If not, we'll fall back to individual calls, but limit concurrent requests
import asyncio
from surreal_commands import get_command_status
async def get_status_safe(command_id: str):
try:
status = await get_command_status(command_id)
return (command_id, status)
except Exception as e:
logger.warning(
f"Failed to get status for command {command_id}: {e}"
)
return (command_id, None)
# Limit concurrent requests to avoid overwhelming the command service
semaphore = asyncio.Semaphore(10)
async def get_status_with_limit(command_id: str):
async with semaphore:
return await get_status_safe(command_id)
# Fetch statuses concurrently but with limit
status_tasks = [get_status_with_limit(cmd_id) for cmd_id in command_ids]
status_results = await asyncio.gather(
*status_tasks, return_exceptions=True
)
# Process results
for result_item in status_results:
if isinstance(result_item, Exception):
continue
if isinstance(result_item, tuple) and len(result_item) == 2:
cmd_id, status = result_item
command_statuses[cmd_id] = status
except Exception as e:
logger.warning(f"Failed to batch fetch command statuses: {e}")
# Convert result to response model
response_list = []
for row in result:
command = row.get("command")
command_id = str(command) if command else None
status = None
processing_info = None
# Get status information if command exists
if command_id and command_id in command_statuses:
status_obj = command_statuses[command_id]
if status_obj:
status = status_obj.status
# Extract execution metadata from nested result structure
result_data: dict[str, Any] | None = getattr(status_obj, "result", None)
execution_metadata: dict[str, Any] = result_data.get("execution_metadata", {}) if isinstance(result_data, dict) else {}
processing_info = {
"started_at": execution_metadata.get("started_at"),
"completed_at": execution_metadata.get("completed_at"),
"error": getattr(status_obj, "error_message", None),
}
elif command_id:
# Command exists but status couldn't be fetched
status = "unknown"
response_list.append(
SourceListResponse(
id=row["id"],
title=row.get("title"),
topics=row.get("topics") or [],
asset=AssetModel(
file_path=row["asset"].get("file_path")
if row.get("asset")
else None,
url=row["asset"].get("url") if row.get("asset") else None,
)
if row.get("asset")
else None,
embedded=row.get("embedded", False),
embedded_chunks=0, # Removed from query - not needed in list view
insights_count=row.get("insights_count", 0),
created=str(row["created"]),
updated=str(row["updated"]),
# Status fields
command_id=command_id,
status=status,
processing_info=processing_info,
)
)
return response_list
except HTTPException:
raise
except Exception as e:
logger.error(f"Error fetching sources: {str(e)}")
raise HTTPException(status_code=500, detail=f"Error fetching sources: {str(e)}")
@router.post("/sources", response_model=SourceResponse)
async def create_source(
form_data: tuple[SourceCreate, Optional[UploadFile]] = Depends(
parse_source_form_data
),
):
"""Create a new source with support for both JSON and multipart form data."""
source_data, upload_file = form_data
try:
# Verify all specified notebooks exist (backward compatibility support)
for notebook_id in (source_data.notebooks or []):
notebook = await Notebook.get(notebook_id)
if not notebook:
raise HTTPException(
status_code=404, detail=f"Notebook {notebook_id} not found"
)
# Handle file upload if provided
file_path = None
if upload_file and source_data.type == "upload":
try:
file_path = await save_uploaded_file(upload_file)
except Exception as e:
logger.error(f"File upload failed: {e}")
raise HTTPException(
status_code=400, detail=f"File upload failed: {str(e)}"
)
# Prepare content_state for processing
content_state: dict[str, Any] = {}
if source_data.type == "link":
if not source_data.url:
raise HTTPException(
status_code=400, detail="URL is required for link type"
)
content_state["url"] = source_data.url
elif source_data.type == "upload":
# Use uploaded file path or provided file_path (backward compatibility)
final_file_path = file_path or source_data.file_path
if not final_file_path:
raise HTTPException(
status_code=400,
detail="File upload or file_path is required for upload type",
)
content_state["file_path"] = final_file_path
content_state["delete_source"] = source_data.delete_source
elif source_data.type == "text":
if not source_data.content:
raise HTTPException(
status_code=400, detail="Content is required for text type"
)
content_state["content"] = source_data.content
else:
raise HTTPException(
status_code=400,
detail="Invalid source type. Must be link, upload, or text",
)
# Validate transformations exist
transformation_ids = source_data.transformations or []
for trans_id in transformation_ids:
transformation = await Transformation.get(trans_id)
if not transformation:
raise HTTPException(
status_code=404, detail=f"Transformation {trans_id} not found"
)
# Branch based on processing mode
if source_data.async_processing:
# ASYNC PATH: Create source record first, then queue command
logger.info("Using async processing path")
# Create minimal source record - let SurrealDB generate the ID
source = Source(
title=source_data.title or "Processing...",
topics=[],
)
await source.save()
# Add source to notebooks immediately so it appears in the UI
# The source_graph will skip adding duplicates
for notebook_id in (source_data.notebooks or []):
await source.add_to_notebook(notebook_id)
try:
# Import command modules to ensure they're registered
import commands.source_commands # noqa: F401
# Submit command for background processing
command_input = SourceProcessingInput(
source_id=str(source.id),
content_state=content_state,
notebook_ids=source_data.notebooks,
transformations=transformation_ids,
embed=source_data.embed,
)
command_id = await CommandService.submit_command_job(
"open_notebook", # app name
"process_source", # command name
command_input.model_dump(),
)
logger.info(f"Submitted async processing command: {command_id}")
# Update source with command reference immediately
# command_id already includes 'command:' prefix
source.command = ensure_record_id(command_id)
await source.save()
# Return source with command info
return SourceResponse(
id=source.id or "",
title=source.title,
topics=source.topics or [],
asset=None, # Will be populated after processing
full_text=None, # Will be populated after processing
embedded=False, # Will be updated after processing
embedded_chunks=0,
created=str(source.created),
updated=str(source.updated),
command_id=command_id,
status="new",
processing_info={"async": True, "queued": True},
)
except Exception as e:
logger.error(f"Failed to submit async processing command: {e}")
# Clean up source record on command submission failure
try:
await source.delete()
except Exception:
pass
# Clean up uploaded file if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise HTTPException(
status_code=500, detail=f"Failed to queue processing: {str(e)}"
)
else:
# SYNC PATH: Execute synchronously using execute_command_sync
logger.info("Using sync processing path")
try:
# Import command modules to ensure they're registered
import commands.source_commands # noqa: F401
# Create source record - let SurrealDB generate the ID
source = Source(
title=source_data.title or "Processing...",
topics=[],
)
await source.save()
# Add source to notebooks immediately so it appears in the UI
# The source_graph will skip adding duplicates
for notebook_id in (source_data.notebooks or []):
await source.add_to_notebook(notebook_id)
# Execute command synchronously
command_input = SourceProcessingInput(
source_id=str(source.id),
content_state=content_state,
notebook_ids=source_data.notebooks,
transformations=transformation_ids,
embed=source_data.embed,
)
result = execute_command_sync(
"open_notebook", # app name
"process_source", # command name
command_input.model_dump(),
timeout=300, # 5 minute timeout for sync processing
)
if not result.is_success():
logger.error(f"Sync processing failed: {result.error_message}")
# Clean up source record
try:
await source.delete()
except Exception:
pass
# Clean up uploaded file if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise HTTPException(
status_code=500,
detail=f"Processing failed: {result.error_message}",
)
# Get the processed source
if not source.id:
raise HTTPException(
status_code=500, detail="Source ID is missing"
)
processed_source = await Source.get(source.id)
if not processed_source:
raise HTTPException(
status_code=500, detail="Processed source not found"
)
embedded_chunks = await processed_source.get_embedded_chunks()
return SourceResponse(
id=processed_source.id or "",
title=processed_source.title,
topics=processed_source.topics or [],
asset=AssetModel(
file_path=processed_source.asset.file_path
if processed_source.asset
else None,
url=processed_source.asset.url
if processed_source.asset
else None,
)
if processed_source.asset
else None,
full_text=processed_source.full_text,
embedded=embedded_chunks > 0,
embedded_chunks=embedded_chunks,
created=str(processed_source.created),
updated=str(processed_source.updated),
# No command_id or status for sync processing (legacy behavior)
)
except Exception as e:
logger.error(f"Sync processing failed: {e}")
# Clean up uploaded file if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise
except HTTPException:
# Clean up uploaded file on HTTP exceptions if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise
except InvalidInputError as e:
# Clean up uploaded file on validation errors if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise HTTPException(status_code=400, detail=str(e))
except Exception as e:
logger.error(f"Error creating source: {str(e)}")
# Clean up uploaded file on unexpected errors if we created it
if file_path and upload_file:
try:
os.unlink(file_path)
except Exception:
pass
raise HTTPException(status_code=500, detail=f"Error creating source: {str(e)}")
@router.post("/sources/json", response_model=SourceResponse)
async def create_source_json(source_data: SourceCreate):
"""Create a new source using JSON payload (legacy endpoint for backward compatibility)."""
# Convert to form data format and call main endpoint
form_data = (source_data, None)
return await create_source(form_data)
async def _resolve_source_file(source_id: str) -> tuple[str, str]:
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
file_path = source.asset.file_path if source.asset else None
if not file_path:
raise HTTPException(status_code=404, detail="Source has no file to download")
safe_root = os.path.realpath(UPLOADS_FOLDER)
resolved_path = os.path.realpath(file_path)
if not resolved_path.startswith(safe_root):
logger.warning(
f"Blocked download outside uploads directory for source {source_id}: {resolved_path}"
)
raise HTTPException(status_code=403, detail="Access to file denied")
if not os.path.exists(resolved_path):
raise HTTPException(status_code=404, detail="File not found on server")
filename = os.path.basename(resolved_path)
return resolved_path, filename
def _is_source_file_available(source: Source) -> Optional[bool]:
if not source or not source.asset or not source.asset.file_path:
return None
file_path = source.asset.file_path
safe_root = os.path.realpath(UPLOADS_FOLDER)
resolved_path = os.path.realpath(file_path)
if not resolved_path.startswith(safe_root):
return False
return os.path.exists(resolved_path)
@router.get("/sources/{source_id}", response_model=SourceResponse)
async def get_source(source_id: str):
"""Get a specific source by ID."""
try:
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
# Get status information if command exists
status = None
processing_info = None
if source.command:
try:
status = await source.get_status()
processing_info = await source.get_processing_progress()
except Exception as e:
logger.warning(f"Failed to get status for source {source_id}: {e}")
status = "unknown"
embedded_chunks = await source.get_embedded_chunks()
# Get associated notebooks
notebooks_query = await repo_query(
"SELECT VALUE out FROM reference WHERE in = $source_id",
{"source_id": ensure_record_id(source.id or source_id)}
)
notebook_ids = [str(nb_id) for nb_id in notebooks_query] if notebooks_query else []
return SourceResponse(
id=source.id or "",
title=source.title,
topics=source.topics or [],
asset=AssetModel(
file_path=source.asset.file_path if source.asset else None,
url=source.asset.url if source.asset else None,
)
if source.asset
else None,
full_text=source.full_text,
embedded=embedded_chunks > 0,
embedded_chunks=embedded_chunks,
file_available=_is_source_file_available(source),
created=str(source.created),
updated=str(source.updated),
# Status fields
command_id=str(source.command) if source.command else None,
status=status,
processing_info=processing_info,
# Notebook associations
notebooks=notebook_ids,
)
except HTTPException:
raise
except Exception as e:
logger.error(f"Error fetching source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail=f"Error fetching source: {str(e)}")
@router.head("/sources/{source_id}/download")
async def check_source_file(source_id: str):
"""Check if a source has a downloadable file."""
try:
await _resolve_source_file(source_id)
return Response(status_code=200)
except HTTPException:
raise
except Exception as e:
logger.error(f"Error checking file for source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail="Failed to verify file")
@router.get("/sources/{source_id}/download")
async def download_source_file(source_id: str):
"""Download the original file associated with an uploaded source."""
try:
resolved_path, filename = await _resolve_source_file(source_id)
return FileResponse(
path=resolved_path,
filename=filename,
media_type="application/octet-stream",
)
except HTTPException:
raise
except Exception as e:
logger.error(f"Error downloading file for source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail="Failed to download source file")
@router.get("/sources/{source_id}/status", response_model=SourceStatusResponse)
async def get_source_status(source_id: str):
"""Get processing status for a source."""
try:
# First, verify source exists
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
# Check if this is a legacy source (no command)
if not source.command:
return SourceStatusResponse(
status=None,
message="Legacy source (completed before async processing)",
processing_info=None,
command_id=None,
)
# Get command status and processing info
try:
status = await source.get_status()
processing_info = await source.get_processing_progress()
# Generate descriptive message based on status
if status == "completed":
message = "Source processing completed successfully"
elif status == "failed":
message = "Source processing failed"
elif status == "running":
message = "Source processing in progress"
elif status == "queued":
message = "Source processing queued"
elif status == "unknown":
message = "Source processing status unknown"
else:
message = f"Source processing status: {status}"
return SourceStatusResponse(
status=status,
message=message,
processing_info=processing_info,
command_id=str(source.command) if source.command else None,
)
except Exception as e:
logger.warning(f"Failed to get status for source {source_id}: {e}")
return SourceStatusResponse(
status="unknown",
message="Failed to retrieve processing status",
processing_info=None,
command_id=str(source.command) if source.command else None,
)
except HTTPException:
raise
except Exception as e:
logger.error(f"Error fetching status for source {source_id}: {str(e)}")
raise HTTPException(
status_code=500, detail=f"Error fetching source status: {str(e)}"
)
@router.put("/sources/{source_id}", response_model=SourceResponse)
async def update_source(source_id: str, source_update: SourceUpdate):
"""Update a source."""
try:
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
# Update only provided fields
if source_update.title is not None:
source.title = source_update.title
if source_update.topics is not None:
source.topics = source_update.topics
await source.save()
embedded_chunks = await source.get_embedded_chunks()
return SourceResponse(
id=source.id or "",
title=source.title,
topics=source.topics or [],
asset=AssetModel(
file_path=source.asset.file_path if source.asset else None,
url=source.asset.url if source.asset else None,
)
if source.asset
else None,
full_text=source.full_text,
embedded=embedded_chunks > 0,
embedded_chunks=embedded_chunks,
created=str(source.created),
updated=str(source.updated),
)
except HTTPException:
raise
except InvalidInputError as e:
raise HTTPException(status_code=400, detail=str(e))
except Exception as e:
logger.error(f"Error updating source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail=f"Error updating source: {str(e)}")
@router.post("/sources/{source_id}/retry", response_model=SourceResponse)
async def retry_source_processing(source_id: str):
"""Retry processing for a failed or stuck source."""
try:
# First, verify source exists
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
# Check if source already has a running command
if source.command:
try:
status = await source.get_status()
if status in ["running", "queued"]:
raise HTTPException(
status_code=400,
detail="Source is already processing. Cannot retry while processing is active.",
)
except Exception as e:
logger.warning(
f"Failed to check current status for source {source_id}: {e}"
)
# Continue with retry if we can't check status
# Get notebooks that this source belongs to
query = "SELECT notebook FROM reference WHERE source = $source_id"
references = await repo_query(query, {"source_id": source_id})
notebook_ids = [str(ref["notebook"]) for ref in references]
if not notebook_ids:
raise HTTPException(
status_code=400, detail="Source is not associated with any notebooks"
)
# Prepare content_state based on source asset
content_state = {}
if source.asset:
if source.asset.file_path:
content_state = {
"file_path": source.asset.file_path,
"delete_source": False, # Don't delete on retry
}
elif source.asset.url:
content_state = {"url": source.asset.url}
else:
raise HTTPException(
status_code=400, detail="Source asset has no file_path or url"
)
else:
# Check if it's a text source by trying to get full_text
if source.full_text:
content_state = {"content": source.full_text}
else:
raise HTTPException(
status_code=400, detail="Cannot determine source content for retry"
)
try:
# Import command modules to ensure they're registered
import commands.source_commands # noqa: F401
# Submit new command for background processing
command_input = SourceProcessingInput(
source_id=str(source.id),
content_state=content_state,
notebook_ids=notebook_ids,
transformations=[], # Use default transformations on retry
embed=True, # Always embed on retry
)
command_id = await CommandService.submit_command_job(
"open_notebook", # app name
"process_source", # command name
command_input.model_dump(),
)
logger.info(
f"Submitted retry processing command: {command_id} for source {source_id}"
)
# Update source with new command ID
source.command = ensure_record_id(f"command:{command_id}")
await source.save()
# Get current embedded chunks count
embedded_chunks = await source.get_embedded_chunks()
# Return updated source response
return SourceResponse(
id=source.id or "",
title=source.title,
topics=source.topics or [],
asset=AssetModel(
file_path=source.asset.file_path if source.asset else None,
url=source.asset.url if source.asset else None,
)
if source.asset
else None,
full_text=source.full_text,
embedded=embedded_chunks > 0,
embedded_chunks=embedded_chunks,
created=str(source.created),
updated=str(source.updated),
command_id=command_id,
status="queued",
processing_info={"retry": True, "queued": True},
)
except Exception as e:
logger.error(
f"Failed to submit retry processing command for source {source_id}: {e}"
)
raise HTTPException(
status_code=500, detail=f"Failed to queue retry processing: {str(e)}"
)
except HTTPException:
raise
except Exception as e:
logger.error(f"Error retrying source processing for {source_id}: {str(e)}")
raise HTTPException(
status_code=500, detail=f"Error retrying source processing: {str(e)}"
)
@router.delete("/sources/{source_id}")
async def delete_source(source_id: str):
"""Delete a source."""
try:
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
await source.delete()
return {"message": "Source deleted successfully"}
except HTTPException:
raise
except Exception as e:
logger.error(f"Error deleting source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail=f"Error deleting source: {str(e)}")
@router.get("/sources/{source_id}/insights", response_model=List[SourceInsightResponse])
async def get_source_insights(source_id: str):
"""Get all insights for a specific source."""
try:
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
insights = await source.get_insights()
return [
SourceInsightResponse(
id=insight.id or "",
source_id=source_id,
insight_type=insight.insight_type,
content=insight.content,
created=str(insight.created),
updated=str(insight.updated),
)
for insight in insights
]
except HTTPException:
raise
except Exception as e:
logger.error(f"Error fetching insights for source {source_id}: {str(e)}")
raise HTTPException(
status_code=500, detail=f"Error fetching insights: {str(e)}"
)
@router.post("/sources/{source_id}/insights", response_model=SourceInsightResponse)
async def create_source_insight(source_id: str, request: CreateSourceInsightRequest):
"""Create a new insight for a source by running a transformation."""
try:
# Get source
source = await Source.get(source_id)
if not source:
raise HTTPException(status_code=404, detail="Source not found")
# Get transformation
transformation = await Transformation.get(request.transformation_id)
if not transformation:
raise HTTPException(status_code=404, detail="Transformation not found")
# Run transformation graph
from open_notebook.graphs.transformation import graph as transform_graph
await transform_graph.ainvoke(
input=dict(source=source, transformation=transformation) # type: ignore[arg-type]
)
# Get the newly created insight (last one)
insights = await source.get_insights()
if insights:
newest = insights[-1]
return SourceInsightResponse(
id=newest.id or "",
source_id=source_id,
insight_type=newest.insight_type,
content=newest.content,
created=str(newest.created),
updated=str(newest.updated),
)
else:
raise HTTPException(status_code=500, detail="Failed to create insight")
except HTTPException:
raise
except Exception as e:
logger.error(f"Error creating insight for source {source_id}: {str(e)}")
raise HTTPException(status_code=500, detail=f"Error creating insight: {str(e)}")
|