fix: prevent analyze loop - skip redundant API calls when text unchanged

src/js/editor.js

@@ -10,6 +10,9 @@ const MAX_ANALYZE_LENGTH = 5000;
 // Pipeline Hardening v3.3: Guard to prevent input events during suggestion apply
 let _isApplyingSuggestion = false;
 
+// Track last analyzed text to prevent redundant API calls
+let _lastAnalyzedText = '';
+
 // ── Custom Undo/Redo Stack ──
 const _undoStack = [];
 const _redoStack = [];
@@ -243,7 +246,7 @@ function findSuggestionElement(id) {
   return document.querySelector(`[data-suggestion-id="${id}"]`);
 }
 
-async function analyzeText() {
+async function analyzeText(forceReanalyze = false) {
   const text = getEditorText();
   updateEditorStats();
   updatePlaceholder();
@@ -255,9 +258,14 @@ async function analyzeText() {
     updateSuggestionsList([]);
     window.currentSuggestions = [];
     updateAnalysisLimitBanner(false);
+    _lastAnalyzedText = '';
     return;
   }
 
+  // Skip redundant analysis if text hasn't changed (prevents overlay→input→analyze loop)
+  if (!forceReanalyze && text === _lastAnalyzedText) return;
+  _lastAnalyzedText = text;
+
   const isTruncated = text.length > MAX_ANALYZE_LENGTH;
   const textForApi = isTruncated ? text.substring(0, MAX_ANALYZE_LENGTH) : text;
   updateAnalysisLimitBanner(isTruncated);
@@ -522,6 +530,8 @@ function applySuggestionAtOffsets(suggestion) {
   }
   // P2/User Request: Auto re-analyze after applying suggestion
   // Calls analyzeText() DIRECTLY (not delayed) for instant re-analysis.
+  // forceReanalyze=true because the text changed (suggestion was applied)
+  _lastAnalyzedText = ''; // Reset so analysis isn't skipped
   setTimeout(() => { analyzeText(); }, 300);
 }
 
@@ -607,6 +617,7 @@ function applyAlternativeCorrection(suggestion, correctionText) {
     _isApplyingSuggestion = false;
   }
   // P2/User Request: Auto re-analyze after applying alternative correction
+  _lastAnalyzedText = ''; // Reset so analysis isn't skipped
   setTimeout(() => { analyzeText(); }, 300);
 }
 
@@ -688,6 +699,7 @@ function applyAllSuggestions() {
     _isApplyingSuggestion = false;
   }
   // P2/User Request: Auto re-analyze after applying all suggestions
+  _lastAnalyzedText = ''; // Reset so analysis isn't skipped
   setTimeout(() => { analyzeText(); }, 300);
 }